From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A41C43381 for ; Fri, 29 Mar 2019 20:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A1CC218A3 for ; Fri, 29 Mar 2019 20:02:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="wSREtca1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730051AbfC2UCT (ORCPT ); Fri, 29 Mar 2019 16:02:19 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:56338 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729953AbfC2UCS (ORCPT ); Fri, 29 Mar 2019 16:02:18 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2TJxMuZ113246; Fri, 29 Mar 2019 20:02:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=rbc7ZqYGmUwG4MFihWfnywk7NVHKjqZu0Jqw+OVWYWA=; b=wSREtca12Nh1T+ho3H3tA8yz6Z46GNxMUwi8uRRQHEt0lkStEUDmMyz+4q84Hmg+KhJV fohgA4B08eN5M4HJdKOOJeM497zZni6KkRVFGtMsmONLvUq2IIPPCt9S2Qs1AurtNBb/ SfDKTyE2yzn+9gOpl4maEiSzUWeY8nDUiUN/DqyzFnIWNjWqz3b8Icx6whK0+eMGkDzE Adv/S0MqYNQFlLql0x+KDHs8BSgXD5J6RfJ4zFLf1yILrXi1S/PEUvd1+7paf0u/+zy9 OEsK2ku464kE+tQra5fbs9woGcjYgIi7kXvkz8OuXTNl7g0G57wuSZHw8Yb20YYC64nf mA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2re6g1egpc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Mar 2019 20:02:09 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2TK26gO000436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Mar 2019 20:02:07 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2TK24av032536; Fri, 29 Mar 2019 20:02:04 GMT Received: from [10.159.154.152] (/10.159.154.152) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 29 Mar 2019 13:02:04 -0700 Subject: Re: [PATCH net v4] failover: allow name change on IFF_UP slave interfaces To: Jiri Pirko , Stephen Hemminger References: <1553816847-28121-1-git-send-email-si-wei.liu@oracle.com> <20190329081512.2f231508@shemminger-XPS-13-9360> <20190329153423.GZ14297@nanopsycho> Cc: mst@redhat.com, sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com From: si-wei liu Organization: Oracle Corporation Message-ID: <4b45a702-e074-c43d-658e-3ac9fbc55b28@oracle.com> Date: Fri, 29 Mar 2019 13:01:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20190329153423.GZ14297@nanopsycho> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9211 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=935 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903290137 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/29/2019 8:34 AM, Jiri Pirko wrote: > Fri, Mar 29, 2019 at 04:15:12PM CET, stephen@networkplumber.org wrote: >> On Thu, 28 Mar 2019 19:47:27 -0400 >> Si-Wei Liu wrote: >> >>> + if (unlikely(dev->flags & IFF_UP)) { >>> + struct netdev_notifier_change_info change_info; >>> + >>> + change_info.flags_changed = 0; >> Simpler to use structure initialization, which also avoid any chance >> of unititialized fields. >> >> struct netdev_notifier_change_info change_info >> = { .flags_changed = 0 }; > > In fact, you can do just: > struct netdev_notifier_change_info change_info = {}; > to achieve the same. Hmm, although it's same in effect, I'd opt for keeping explicit initialization around flags_changed, which has the benefit in terms of cscope/tags referencing. Just very minor point though. Let me if you think it otherwise... -Siwei