From mboxrd@z Thu Jan  1 00:00:00 1970
From: andre.przywara@arm.com (Andre Przywara)
Date: Fri, 6 Jul 2018 16:46:08 +0100
Subject: [linux-sunxi] Re: [PATCH 05/10] arm64: dts: allwinner: a64:
 Olinuxino: enable USB
In-Reply-To: <52713A44-E2BB-4388-A98F-D49AA3B6EAC3@aosc.io>
References: <20180706085210.17952-1-andre.przywara@arm.com>
 <20180706085210.17952-6-andre.przywara@arm.com>
 <20180706150401.mhqse677vdqtxdzy@nodbug.lucina.net>
 <548f2eb5-b457-8fcd-c043-b897a447d96c@arm.com>
 <52713A44-E2BB-4388-A98F-D49AA3B6EAC3@aosc.io>
Message-ID: <4b4d1662-4266-593c-79a9-39eea8fb668c@arm.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi,

On 06/07/18 16:36, Icenowy Zheng wrote:
> 
> 
> ? 2018?7?6? GMT+08:00 ??11:35:38, Andre Przywara <andre.przywara@arm.com> ??:
>> Hi,
>>
>> On 06/07/18 16:04, Martin Lucina wrote:
>>> On Friday, 06.07.2018 at?09:52, Andre Przywara wrote:
>>>> The Olinuxino has two USB socket:
>>>> USB0 is connected to a micro B socket. As it has the ID pin wired,
>> we
>>>> describe it as a proper OTG socket, which switches between host and
>>>> device automatically.
>>>> USB1 is connected to a normal USB A socket. PG9 enables the power
>> line,
>>>> so add the required regulator as well.
>>>>
>>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>>> ---
>>>
>>> This is not sufficient. Booting with this change results in the
>> following
>>> in dmesg:
>>>
>>> musb-sunxi 1c19000.usb: Invalid or missing 'dr_mode' property
>>> musb-sunxi: probe of 1c19000.usb failed with error -22
>>> [...]
>>> usb0-vbus: disabling
>>>
>>> ... and neither of the USB ports work.
>>>
>>> Adding
>>>
>>>     dr_mode = "host";
>>
>> Argh, right, I remember you mentioned this before.
>> Still it should not affect the other USB port, and actually it is a
>> proper OTG port, so host is not right here. So this points to some
>> other
>> oddity or incorrect description. I need to go back to the schematics
>> and
>> our previous thread.
> 
> OTG needs dr_mode = "otg"; and a ID pin.

Yes, and we have the ID pin in the usbphy node.
Martin, can you please check if dr_mode = "otg"; works for you?

Icenowy: still, how does it affect USB1? I mean, even if MUSB does not
initialise, it should leave the other host controller working? Is that
related to them sharing the usbphy? And this one gives up and tears
*everything* down, including the power for USB1?

Cheers,
Andre.

>>>
>>> to the &usb_otg node fixes this -- the above messages go away and
>> both
>>> ports work as expected.
>>>
>>> -mato
>>>