From: Daniel Rosenberg <drosen@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH] staging: android: ion: check for kref overflow
Date: Fri, 31 Aug 2018 14:31:38 -0700 [thread overview]
Message-ID: <4b4e64a4-bf6f-b3d0-4221-2a0d3206a6a9@google.com> (raw)
In-Reply-To: <20180831155657.GA25066@kroah.com>
On 08/31/2018 08:56 AM, Greg Kroah-Hartman wrote:
> On Thu, Aug 30, 2018 at 06:36:18PM -0700, Daniel Rosenberg wrote:
>> The sign off was on the 4.4.y version that I cherry-picked this from.
> Ah that wasn't obvious at all. What is that git commit id? You need to
> give us a hint as to what is going on when you do that :)
b84ec04bae905901("staging: android: ion: check for kref overflow") in 4.4.y
>> There was a trivial conflict moving it to 4.9, but it did not modify
>> any changed lines, so I hadn't thought that was worth noting on the
>> patch. I apologise if leaving the signed-off-by was incorrect here.
> Why did I only apply this to 4.4 and not 4.9 when the original patch was
> submitted? That seems odd.
>
> thanks,
>
> greg k-h
I don't know. I had included it in the range of kernel versions it
should be applied to in the original patch, and noted the minor conflict
for later kernel versions. You added it in 3.18 and 4.4, and I assumed
not 4.9 because of the conflict in applying the patch, so I sent this
version.
b1fa6d8acb50c8e9 ("staging: android: ion: Pull out ion ioctls to a
separate file") is the patch that causes the minor conflict in applying
the original patch.
4c23cbff073f3b9b ("staging: android: ion: Remove import interface") is
the patch that removes the affected code altogether in later kernels
versions.
next prev parent reply other threads:[~2018-08-31 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 23:09 [PATCH] staging: android: ion: check for kref overflow Daniel Rosenberg
2018-08-31 0:41 ` Greg Kroah-Hartman
2018-08-31 1:36 ` Daniel Rosenberg
2018-08-31 15:56 ` Greg Kroah-Hartman
2018-08-31 21:31 ` Daniel Rosenberg [this message]
2018-09-03 16:31 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2018-08-21 1:30 Daniel Rosenberg
2018-08-21 5:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b4e64a4-bf6f-b3d0-4221-2a0d3206a6a9@google.com \
--to=drosen@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.