From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76A65C433F5 for ; Sun, 20 Mar 2022 23:59:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 48D2683AAC; Mon, 21 Mar 2022 00:58:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mZrVRYEj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D79A383ADC; Mon, 21 Mar 2022 00:58:57 +0100 (CET) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CAE56830AF for ; Mon, 21 Mar 2022 00:58:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf35.google.com with SMTP id k7so4978770qvc.4 for ; Sun, 20 Mar 2022 16:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LhgooLuPh9AjypgoIGG2HRRwCYt8eNAvCmbRe76uN9s=; b=mZrVRYEjntrDCDnWv3pnnR6NCQx8zHlY8ueBKISstJthrAAsHfwMJcUvD84ZFISSgQ nndthSz5aToe2ufsl/3oNrOVu612FHPyLpyajbO4LAq6vo8vANvgXecaeSSUg9Capquv i/4MZTAyTSox0oEeDM3nBQEvTKCj7XwUDIn9rbogw+4xFcrbY0PNy0+GmyqTaGTEBMiU Iah/5jsAQlQxsWGP3qioO4xDFrBJ5IA4Lx7NQVC/TIPyhBgqU4Jrf0SCQ9dkEOKFoAXL Un8Q4/md85rhGSBIIrAyN3nNJxf81rWUYiy3igqnlb7swYY4YI7zDvquvOCzccEjK0Yz M6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LhgooLuPh9AjypgoIGG2HRRwCYt8eNAvCmbRe76uN9s=; b=P8E8uSQkYTo4LzLvNfM3PgkSPQyf81NnZBUU+ocJAKT5FemRxi63HUJhGTh9utsS5P xft+Ai1D3L/AkDaT2uGC9VFqeHYNe72aMCVT+mMRi22l6a8RJkJWB3VnLfrVizC8TDX3 ZPnR0LrDScRPsSnAxTxq/E8u0tFM13gkrVNwEZXZSckf1fnn6yVQ5NULrHzTyEVHgZ4j MsBqmGVgiTejmBrCsnUlSnztyJ1JXpjy8QnHuH4TuD+VzAgwsJjMHMgmfSMZmNqI10QY rzGoiPKg469/8UQbvURmYnvkFu8bztdn+9Nt10AHaac/G9Gq5W5BBDeCm5eWcvTJJ4sg 8L/g== X-Gm-Message-State: AOAM532eDNmQqTbQLQGFftv2jfeKwKWqGqZJbof4pDuZ2iP2PoyNUaT9 yaJpIemgxexuUYrP9gpKlHkaEBJG02E= X-Google-Smtp-Source: ABdhPJzAZZuXM+KUtpJ1H7k8qiqzh8cPs3mqxHrYXgEgSLbZdDunFIBoUn79xNFzagwtDnNcNS76hA== X-Received: by 2002:a05:6214:240d:b0:440:a2ec:eaa9 with SMTP id fv13-20020a056214240d00b00440a2eceaa9mr13873433qvb.37.1647820733670; Sun, 20 Mar 2022 16:58:53 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id i18-20020ac85c12000000b002e1ce74f1a8sm10472112qti.27.2022.03.20.16.58.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 16:58:53 -0700 (PDT) Subject: Re: [PATCH v4 4/4] clk: imx8m: remove code duplication To: Angus Ainslie , u-boot@lists.denx.de, Marek Vasut Cc: lukma@denx.de, sbabic@denx.de, festevam@gmail.com, kernel@puri.sm, uboot-imx@nxp.com, peng.fan@nxp.com References: <20220315130820.1054186-1-angus@akkea.ca> <20220315130820.1054186-5-angus@akkea.ca> From: Sean Anderson Message-ID: <4b714cbf-a7b8-032b-0792-f9bf1c99be8a@gmail.com> Date: Sun, 20 Mar 2022 19:58:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20220315130820.1054186-5-angus@akkea.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Angus, On 3/15/22 9:08 AM, Angus Ainslie wrote: > All of the imx8m[nmpq] use the same clk_ops functions so move them > to a common file. > > Signed-off-by: Angus Ainslie > Reviewed-by: Marek Vasut > --- > drivers/clk/imx/Makefile | 8 +-- > drivers/clk/imx/clk-imx8m.c | 108 +++++++++++++++++++++++++++++++++++ > drivers/clk/imx/clk-imx8m.h | 12 ++++ > drivers/clk/imx/clk-imx8mm.c | 89 +---------------------------- > drivers/clk/imx/clk-imx8mn.c | 89 +---------------------------- > drivers/clk/imx/clk-imx8mp.c | 91 +---------------------------- > drivers/clk/imx/clk-imx8mq.c | 91 +---------------------------- > 7 files changed, 132 insertions(+), 356 deletions(-) > create mode 100644 drivers/clk/imx/clk-imx8m.c > create mode 100644 drivers/clk/imx/clk-imx8m.h Looks like this is accomplishing the same thing as [1], which also covers at91 and mpfs. Great minds think alike :) Would it be possible for you to rebase your series on mine? --Sean [1] https://patchwork.ozlabs.org/project/uboot/patch/20220320203446.740178-2-seanga2@gmail.com/