From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-acpi@vger.kernel.org,
netdev@vger.kernel.org, Jason Baron <jbaron@akamai.com>,
Jonathan Corbet <corbet@lwn.net>,
Jim Cromie <jim.cromie@gmail.com>
Subject: Re: [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask
Date: Wed, 10 Jun 2020 00:24:25 -0700 [thread overview]
Message-ID: <4b77ebf589ccc8ce0983539ce2fca4eba8f72a2a.camel@perches.com> (raw)
In-Reply-To: <20200610070949.GB1923109@kroah.com>
On Wed, 2020-06-10 at 09:09 +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 09, 2020 at 11:35:31PM -0700, Joe Perches wrote:
> > On Wed, 2020-06-10 at 08:31 +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Jun 09, 2020 at 09:58:07AM -0700, Joe Perches wrote:
> > > > On Tue, 2020-06-09 at 13:16 +0200, Greg Kroah-Hartman wrote:
> > > > > What is wrong with the existing control of dynamic
> > > > > debug messages that you want to add another type of arbitrary grouping
> > > > > to it?
> > > >
> > > > There is no existing grouping mechanism.
> > >
> > > info/warn/err/dbg is what I am referring to.
This is specifically about dbg so that's not relevant is it.
> But each "level" you all come up with will be intrepreted differently
> per driver, causing total confusion (like we have today.) Try to make
> it better by just removing that mess.
Or add value as it allows the developer to do what's
necessary for their development.
> > > In the beginning, yes, adding loads of different types of debugging
> > > options to a driver is needed by the author, but by the time it is added
> > > to the kernel, all of that should be able to be removed and only a
> > > single "enable debug" should be all that is needed.
> >
> > No one does that.
>
> We did that for USB drivers a decade ago, it can be done.
And nearly no one does it.
btw: look up usbip_debug_flag and usbip_dbg_<foo> or the uhci driver
next prev parent reply other threads:[~2020-06-10 7:24 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 10:45 [PATCH v3 0/7] Venus dynamic debug Stanimir Varbanov
2020-06-09 10:45 ` [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask Stanimir Varbanov
2020-06-09 11:09 ` Matthew Wilcox
2020-06-09 11:16 ` Greg Kroah-Hartman
2020-06-09 16:58 ` Joe Perches
2020-06-09 17:42 ` Edward Cree
2020-06-09 17:56 ` Joe Perches
2020-06-09 18:08 ` Edward Cree
2020-06-10 6:31 ` Greg Kroah-Hartman
2020-06-10 6:35 ` Joe Perches
2020-06-10 7:09 ` Greg Kroah-Hartman
2020-06-10 7:24 ` Joe Perches [this message]
2020-06-10 10:29 ` Stanimir Varbanov
2020-06-10 12:26 ` Greg Kroah-Hartman
2020-06-09 10:45 ` [PATCH v3 2/7] dynamic_debug: Group debug messages by " Stanimir Varbanov
2020-06-09 12:27 ` Petr Mladek
2020-06-09 10:46 ` [PATCH v3 3/7] dev_printk: Add dev_dbg_level macro over dynamic one Stanimir Varbanov
2020-06-09 10:46 ` [PATCH v3 4/7] printk: Add pr_debug_level " Stanimir Varbanov
2020-06-09 11:12 ` Greg Kroah-Hartman
2020-06-09 10:46 ` [PATCH v3 5/7] venus: Add debugfs interface to set firmware log level Stanimir Varbanov
2020-06-09 11:12 ` Greg Kroah-Hartman
2020-06-11 11:51 ` Stanimir Varbanov
2020-06-09 10:46 ` [PATCH v3 6/7] venus: Make debug infrastructure more flexible Stanimir Varbanov
2020-06-09 11:14 ` Greg Kroah-Hartman
2020-06-10 13:29 ` Stanimir Varbanov
2020-06-10 13:37 ` Greg Kroah-Hartman
2020-06-10 19:49 ` Joe Perches
2020-06-10 20:23 ` Joe Perches
2020-06-11 6:26 ` Greg Kroah-Hartman
2020-06-11 6:42 ` Joe Perches
2020-06-11 10:52 ` Daniel Thompson
2020-06-11 11:31 ` Stanimir Varbanov
2020-06-11 12:18 ` Daniel Thompson
2020-06-11 21:19 ` jim.cromie
2020-06-11 21:59 ` Jason Baron
2020-06-11 22:33 ` Joe Perches
2020-06-12 0:08 ` jim.cromie
2020-06-10 18:32 ` WIP generic module->debug_flags and dynamic_debug jim.cromie
2020-06-10 20:24 ` Joe Perches
2020-06-11 11:26 ` Rasmus Villemoes
2020-06-11 14:09 ` jim.cromie
2020-06-09 10:46 ` [PATCH v3 7/7] venus: Add a debugfs file for SSR trigger Stanimir Varbanov
2020-06-09 11:13 ` [PATCH v3 0/7] Venus dynamic debug Matthew Wilcox
2020-06-09 16:03 ` Randy Dunlap
2020-06-09 16:49 ` Joe Perches
2020-06-09 21:21 ` jim.cromie
2020-06-09 22:23 ` Joe Perches
2020-06-10 1:58 ` Joe Perches
2020-06-10 3:10 ` jim.cromie
2020-06-09 16:40 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b77ebf589ccc8ce0983539ce2fca4eba8f72a2a.camel@perches.com \
--to=joe@perches.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.