All of lore.kernel.org
 help / color / mirror / Atom feed
From: "ying.huang@intel.com" <ying.huang@intel.com>
To: Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc: songmuchun@bytedance.com, hch@infradead.org, willy@infradead.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] mm/vmscan: add a comment about MADV_FREE pages check in folio_check_dirty_writeback
Date: Mon, 11 Apr 2022 19:50:42 +0800	[thread overview]
Message-ID: <4b7923585e07b0238545ebb997af92eeadcdaf78.camel@intel.com> (raw)
In-Reply-To: <20220409093500.10329-2-linmiaohe@huawei.com>

On Sat, 2022-04-09 at 17:34 +0800, Miaohe Lin wrote:
> The MADV_FREE pages check in folio_check_dirty_writeback is a bit hard to
> follow. Add a comment to make the code clear.
> 
> Suggested-by: Huang, Ying <ying.huang@intel.com>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  mm/vmscan.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index c77d5052f230..4a76be47bed1 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1436,6 +1436,9 @@ static void folio_check_dirty_writeback(struct folio
> *folio,
>         /*
>          * Anonymous pages are not handled by flushers and must be written
>          * from reclaim context. Do not stall reclaim based on them
> +        * MADV_FREE anonymous pages are put into inactive file list too.
> +        * They could be mistakenly treated as file lru. So further anon
> +        * test is needed.
>          */

How about something as follows,

	/*
         * Anonymous pages (including MADV_FREE ones) are not handled
by	 * flushers and must be written from reclaim context. Do not stall
	 * reclaim based on them
	 */.

Best Regards,
Huang, Ying

>         if (!folio_is_file_lru(folio) ||
>             (folio_test_anon(folio) && !folio_test_swapbacked(folio))) {



  reply	other threads:[~2022-04-11 11:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09  9:34 [PATCH v2 0/9] A few cleanup and fixup patches for vmscan Miaohe Lin
2022-04-09  9:34 ` [PATCH v2 1/9] mm/vmscan: add a comment about MADV_FREE pages check in folio_check_dirty_writeback Miaohe Lin
2022-04-11 11:50   ` ying.huang [this message]
2022-04-12  3:07     ` Miaohe Lin
2022-04-11 14:16   ` Christoph Hellwig
2022-04-12  3:15     ` Miaohe Lin
2022-04-12  8:44   ` Oscar Salvador
2022-04-09  9:34 ` [PATCH v2 2/9] mm/vmscan: remove unneeded can_split_huge_page check Miaohe Lin
2022-04-11 14:18   ` Christoph Hellwig
2022-04-12  3:14     ` Miaohe Lin
2022-04-12  0:52   ` ying.huang
2022-04-12  8:59   ` Oscar Salvador
2022-04-12 13:42     ` Miaohe Lin
2022-04-12 14:59       ` David Hildenbrand
2022-04-13  1:26         ` ying.huang
2022-04-13  2:17           ` Miaohe Lin
2022-04-15  3:07           ` ying.huang
2022-04-16  2:34             ` Miaohe Lin
2022-04-09  9:34 ` [PATCH v2 3/9] mm/vmscan: introduce helper function reclaim_page_list() Miaohe Lin
2022-04-09 13:44   ` Matthew Wilcox
2022-04-11  1:53     ` Miaohe Lin
2022-04-11  3:17       ` Matthew Wilcox
2022-04-11  3:26         ` Miaohe Lin
2022-04-09  9:34 ` [PATCH v2 4/9] mm/vmscan: save a bit of stack space in shrink_lruvec Miaohe Lin
2022-04-12  0:57   ` ying.huang
2022-04-12  3:13     ` Miaohe Lin
2022-04-09  9:34 ` [PATCH v2 5/9] mm/vmscan: activate swap-backed executable folios after first usage Miaohe Lin
2022-04-12  0:59   ` ying.huang
2022-04-09  9:34 ` [PATCH v2 6/9] mm/vmscan: take all base pages of THP into account when race with speculative reference Miaohe Lin
2022-04-09  9:34 ` [PATCH v2 7/9] mm/vmscan: take min_slab_pages into account when try to call shrink_node Miaohe Lin
2022-04-12  1:36   ` ying.huang
2022-04-09  9:34 ` [PATCH v2 8/9] mm/vmscan: remove obsolete comment in kswapd_run Miaohe Lin
2022-04-09  9:35 ` [PATCH v2 9/9] mm/vmscan: use helper folio_is_file_lru() Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b7923585e07b0238545ebb997af92eeadcdaf78.camel@intel.com \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=songmuchun@bytedance.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.