All of lore.kernel.org
 help / color / mirror / Atom feed
From: maobibo <maobibo@loongson.cn>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: add access/dirty bit on numa page fault
Date: Thu, 17 Mar 2022 09:09:16 +0800	[thread overview]
Message-ID: <4bb3e4ef-29f9-448b-22ad-1ae7c2d008ff@loongson.cn> (raw)
In-Reply-To: <dad20ecc-efcd-4d3b-9d60-b5ad0b2c2c4b@arm.com>



On 03/16/2022 05:42 PM, Anshuman Khandual wrote:
> 
> 
> On 3/16/22 12:33, maobibo wrote:
>>
>> On 03/16/2022 02:43 PM, Anshuman Khandual wrote:
>>>
>>> On 3/16/22 06:38, Bibo Mao wrote:
>>>> During numa page fault, dirty bit can be added for old pte if
>>>> fail to migrate on write fault. And if it succeeds to migrate,
>>>> access bit can be added for migrated new pte, also dirty bit
>>>> can be added for write fault.
>>> The current code does not set the access and dirty bits when ever
>>> applicable i.e on FAULT_FLAG_WRITE, on the pte (old if migration
>>> fails, new if migration succeeds) ? Did not this cause any problem
>>> earlier ? I am wondering how this might have gone unnoticed.
> 
>> On arm/x86 platform hw will set access/dirty bits automatically,
>> however on MIPS platform access/dirty bits are set by software in next
>> page fault, it is relatively easier to watch on MIPS platform.
> 
> Could you please update this in the commit message as well ?

sure, will do. 

regards
bibo, mao


      reply	other threads:[~2022-03-17  1:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16  1:08 [PATCH] mm: add access/dirty bit on numa page fault Bibo Mao
2022-03-16  6:43 ` Anshuman Khandual
2022-03-16  7:03   ` maobibo
2022-03-16  9:42     ` Anshuman Khandual
2022-03-17  1:09       ` maobibo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bb3e4ef-29f9-448b-22ad-1ae7c2d008ff@loongson.cn \
    --to=maobibo@loongson.cn \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.