From: Bart Van Assche <bvanassche@acm.org>
To: Arthur Simchaev <Arthur.Simchaev@sandisk.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: alim.akhtar@samsung.com, Bean Huo <beanhuo@micron.com>,
Arthur Simchaev <arthur.simchaev@wdc.com>
Subject: Re: [PATCH] scsi: ufs: sysfs: add is_ascii_output entry
Date: Wed, 10 Feb 2021 19:35:25 -0800 [thread overview]
Message-ID: <4bba4245-df01-f23d-65ba-4ff133cae0bc@acm.org> (raw)
In-Reply-To: <1612954425-6705-1-git-send-email-Arthur.Simchaev@sandisk.com>
On 2/10/21 2:53 AM, Arthur Simchaev wrote:
> +static bool is_ascii_output = true;
[ ... ]
> static const char *ufschd_uic_link_state_to_string(
> enum uic_link_state state)
> {
> @@ -693,7 +695,15 @@ static ssize_t _name##_show(struct device *dev, \
> SD_ASCII_STD); \
> if (ret < 0) \
> goto out; \
> - ret = sysfs_emit(buf, "%s\n", desc_buf); \
> + if (is_ascii_output) { \
> + ret = sysfs_emit(buf, "%s\n", desc_buf); \
> + } else { \
> + int i; \
> + \
> + for (i = 0; i < desc_buf[0]; i++) \
> + hex_byte_pack(buf + i * 2, desc_buf[i]); \
> + ret = sysfs_emit(buf, "%s\n", buf); \
> + } \
> out: \
> pm_runtime_put_sync(hba->dev); \
> kfree(desc_buf); \
Please do not introduce a mode variable but instead introduce a new
attribute such that there is one attribute for the unicode output and
one attribute for the ASCII output. Mode variables are troublesome when
e.g. two scripts try to set the mode attribute concurrently.
Thanks,
Bart.
next prev parent reply other threads:[~2021-02-11 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 10:53 [PATCH] scsi: ufs: sysfs: add is_ascii_output entry Arthur Simchaev
2021-02-11 3:35 ` Bart Van Assche [this message]
2021-02-14 9:53 ` Greg KH
2021-02-14 14:21 ` Arthur Simchaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bba4245-df01-f23d-65ba-4ff133cae0bc@acm.org \
--to=bvanassche@acm.org \
--cc=Arthur.Simchaev@sandisk.com \
--cc=alim.akhtar@samsung.com \
--cc=arthur.simchaev@wdc.com \
--cc=beanhuo@micron.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.