From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: [RFC][PATCH] Remove duplicate setting of the B field in tlbie Date: Tue, 13 Sep 2016 17:45:34 +1000 Message-ID: <4bbac7fd-ed99-a5c4-1bda-94345b88f18c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, "Aneesh Kumar K.V" To: Paul Mackerras Return-path: Received: from mail-pa0-f68.google.com ([209.85.220.68]:32898 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbcIMHpk (ORCPT ); Tue, 13 Sep 2016 03:45:40 -0400 Sender: kvm-owner@vger.kernel.org List-ID: Remove duplicate setting of the the "B" field when doing a tlbie(l). In compute_tlbie_rb(), the "B" field is set again just before returning the rb value to be used for tlbie(l). Signed-off-by: Balbir Singh --- Quickly boot tested a VM with these changes in kvm with 64k as the page size for the guest. arch/powerpc/include/asm/kvm_book3s_64.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h index 88d17b4..63b6900 100644 --- a/arch/powerpc/include/asm/kvm_book3s_64.h +++ b/arch/powerpc/include/asm/kvm_book3s_64.h @@ -159,7 +159,6 @@ static inline unsigned long compute_tlbie_rb(unsigned long v, unsigned long r, /* This covers 14..54 bits of va*/ rb = (v & ~0x7fUL) << 16; /* AVA field */ - rb |= (v >> HPTE_V_SSIZE_SHIFT) << 8; /* B field */ /* * AVA in v had cleared lower 23 bits. We need to derive * that from pteg index -- 2.5.5 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Date: Tue, 13 Sep 2016 07:45:34 +0000 Subject: [RFC][PATCH] Remove duplicate setting of the B field in tlbie Message-Id: <4bbac7fd-ed99-a5c4-1bda-94345b88f18c@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mackerras Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, "Aneesh Kumar K.V" Remove duplicate setting of the the "B" field when doing a tlbie(l). In compute_tlbie_rb(), the "B" field is set again just before returning the rb value to be used for tlbie(l). Signed-off-by: Balbir Singh --- Quickly boot tested a VM with these changes in kvm with 64k as the page size for the guest. arch/powerpc/include/asm/kvm_book3s_64.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h index 88d17b4..63b6900 100644 --- a/arch/powerpc/include/asm/kvm_book3s_64.h +++ b/arch/powerpc/include/asm/kvm_book3s_64.h @@ -159,7 +159,6 @@ static inline unsigned long compute_tlbie_rb(unsigned long v, unsigned long r, /* This covers 14..54 bits of va*/ rb = (v & ~0x7fUL) << 16; /* AVA field */ - rb |= (v >> HPTE_V_SSIZE_SHIFT) << 8; /* B field */ /* * AVA in v had cleared lower 23 bits. We need to derive * that from pteg index -- 2.5.5