From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 2/5] blkdebug: move post-resume handling to resume_req_by_tag
Date: Mon, 31 May 2021 22:50:39 +0300 [thread overview]
Message-ID: <4bbc70d3-2862-db73-9286-34d969a41a54@virtuozzo.com> (raw)
In-Reply-To: <20210517145049.55268-3-eesposit@redhat.com>
17.05.2021 17:50, Emanuele Giuseppe Esposito wrote:
> We want to move qemu_coroutine_yield() after the loop on rules,
> because QLIST_FOREACH_SAFE is wrong if the rule list is modified
> while the coroutine has yielded. Therefore move the suspended
> request to the heap and clean it up from the remove side.
> All that is left is for blkdebug_debug_event to handle the
> yielding.
>
> Co-developed-by: Paolo Bonzini<pbonzini@redhat.com>
> Signed-off-by: Emanuele Giuseppe Esposito<eesposit@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-05-31 19:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 14:50 [PATCH v3 0/5] blkdebug: fix racing condition when iterating on Emanuele Giuseppe Esposito
2021-05-17 14:50 ` [PATCH v3 1/5] blkdebug: refactor removal of a suspended request Emanuele Giuseppe Esposito
2021-05-31 19:44 ` Vladimir Sementsov-Ogievskiy
2021-05-17 14:50 ` [PATCH v3 2/5] blkdebug: move post-resume handling to resume_req_by_tag Emanuele Giuseppe Esposito
2021-05-31 19:50 ` Vladimir Sementsov-Ogievskiy [this message]
2021-05-17 14:50 ` [PATCH v3 3/5] blkdebug: track all actions Emanuele Giuseppe Esposito
2021-05-31 19:57 ` Vladimir Sementsov-Ogievskiy
2021-05-17 14:50 ` [PATCH v3 4/5] blkdebug: do not suspend in the middle of QLIST_FOREACH_SAFE Emanuele Giuseppe Esposito
2021-06-01 7:58 ` Vladimir Sementsov-Ogievskiy
2021-05-17 14:50 ` [PATCH v3 5/5] blkdebug: protect rules and suspended_reqs with a lock Emanuele Giuseppe Esposito
2021-06-01 8:39 ` Vladimir Sementsov-Ogievskiy
2021-06-02 12:59 ` Emanuele Giuseppe Esposito
2021-06-02 13:24 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bbc70d3-2862-db73-9286-34d969a41a54@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=eesposit@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.