From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751283AbdGQEIW (ORCPT ); Mon, 17 Jul 2017 00:08:22 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.102]:39120 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbdGQEIV (ORCPT ); Mon, 17 Jul 2017 00:08:21 -0400 Subject: Re: [PATCH] i2c: designware-slave: constify i2c_algorithm structure To: Andy Shevchenko , Jarkko Nikula , Mika Westerberg , Wolfram Sang References: <20170709213517.GA31846@embeddedgus> <1499682392.22624.320.camel@linux.intel.com> Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: <4bcd6609-963b-e64c-8c77-8badde089e6e@embeddedor.com> Date: Sun, 16 Jul 2017 23:08:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1499682392.22624.320.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWxKW-002n7Q-HZ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:38828 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 29 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 07/10/2017 05:26 AM, Andy Shevchenko wrote: > On Sun, 2017-07-09 at 16:35 -0500, Gustavo A. R. Silva wrote: >> Check for i2c_algorithm structures that are only stored in >> the algo field of an i2c_adapter structure. This field is >> declared const, so i2c_algorithm structures that have this >> property can be declared as const also. >> >> This issue was identified using Coccinelle and the following >> semantic patch: >> >> @r disable optional_qualifier@ >> identifier i; >> position p; >> @@ >> static struct i2c_algorithm i@p = { ... }; >> >> @ok@ >> identifier r.i; >> struct i2c_adapter e; >> position p; >> @@ >> e.algo = &i@p; >> >> @bad@ >> position p != {r.p,ok.p}; >> identifier r.i; >> @@ >> i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r.i; >> @@ >> static >> +const >> struct i2c_algorithm i = { ... }; > I don't think it's a good idea to copy'n'paste patch to each change > where you fixing the issue. Can you create a github repository of the > coccinelle recipes and give just a link? I will take note of that, thanks for the suggestion. > Other than that, I'm fine with the change as long as it compiles without > troubles (had seen recently similar patch that has been sent without > actual testing). > > Acked-by: Andy Shevchenko Thank you >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/i2c/busses/i2c-designware-slave.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-designware-slave.c >> b/drivers/i2c/busses/i2c-designware-slave.c >> index 4012c74..e62799e 100644 >> --- a/drivers/i2c/busses/i2c-designware-slave.c >> +++ b/drivers/i2c/busses/i2c-designware-slave.c >> @@ -344,7 +344,7 @@ static irqreturn_t i2c_dw_isr_slave(int this_irq, >> void *dev_id) >> return IRQ_RETVAL(ret); >> } >> >> -static struct i2c_algorithm i2c_dw_algo = { >> +static const struct i2c_algorithm i2c_dw_algo = { >> .functionality = i2c_dw_func, >> .reg_slave = i2c_dw_reg_slave, >> .unreg_slave = i2c_dw_unreg_slave, -- Gustavo A. R. Silva