From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Liang He <windhl@126.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] memory/tegra: Add missing of_node_get() in tegra_emc_find_node_by_ram_code
Date: Wed, 22 Jun 2022 11:09:10 +0200 [thread overview]
Message-ID: <4bd9d2bd-ec24-4d93-a6a7-fef625d09b26@linaro.org> (raw)
In-Reply-To: <b3a0b35e-33fc-f7f3-a111-1a88498b4019@linaro.org>
On 22/06/2022 11:08, Krzysztof Kozlowski wrote:
>>> The patch was not even compiled... I consider it harmful approach. NAK.
>>> See: https://lwn.net/Articles/854645/
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Sorry, Krzysztof.
>>
>> As the patch is so simple two lines , I thought I can handle it without compiling it.
>>
>> Thanks very much for your notice about the article and I hope I have not done anyother harmful things.
>>
>> And I will take care of my patch code in future no matter how simple it is.
>
>
> Never send patches which were not built. It seems you didn't build them
> in the past either, even though setting up cross compile is trivial (few
> commands). QEMU is also an easy option.
>
> Even though your contribution might be valuable, lack of building is a
> sign for me that approach is not serious, so I am not going to take
> risky code.
Unless of course someone's reviews your code. :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-22 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 4:28 [PATCH] memory/tegra: Add missing of_node_get() in tegra_emc_find_node_by_ram_code Liang He
2022-06-22 6:50 ` Krzysztof Kozlowski
2022-06-22 6:56 ` Liang He
2022-06-22 8:35 ` kernel test robot
2022-06-22 8:41 ` Krzysztof Kozlowski
2022-06-22 8:49 ` Liang He
2022-06-22 9:08 ` Krzysztof Kozlowski
2022-06-22 9:09 ` Krzysztof Kozlowski [this message]
2022-06-22 9:20 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bd9d2bd-ec24-4d93-a6a7-fef625d09b26@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.