From: Adrian Hunter <adrian.hunter@intel.com>
To: Piotr Stankiewicz <piotr.stankiewicz@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate
Date: Tue, 2 Jun 2020 16:16:04 +0300 [thread overview]
Message-ID: <4be034bd-c11d-4f8b-153d-f771c1ea71e7@intel.com> (raw)
In-Reply-To: <20200602092059.32146-1-piotr.stankiewicz@intel.com>
On 2/06/20 12:20 pm, Piotr Stankiewicz wrote:
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
>
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-pci-gli.c | 3 +--
> drivers/mmc/host/sdhci-pci-o2micro.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index fd76aa672e02..d14997f9cbf9 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -271,8 +271,7 @@ static void gli_pcie_enable_msi(struct sdhci_pci_slot *slot)
> {
> int ret;
>
> - ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
> if (ret < 0) {
> pr_warn("%s: enable PCI MSI failed, error=%d\n",
> mmc_hostname(slot->host->mmc), ret);
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index fa8105087d68..498c51207bfb 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -470,8 +470,7 @@ static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
> return;
> }
>
> - ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + ret = pci_alloc_irq_vectors(chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
> if (ret < 0) {
> pr_err("%s: enable PCI MSI failed, err=%d\n",
> mmc_hostname(host->mmc), ret);
>
next prev parent reply other threads:[~2020-06-02 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 9:20 [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-02 12:08 ` Ulf Hansson
2020-06-02 13:16 ` Adrian Hunter [this message]
2020-06-03 5:26 ` Christoph Hellwig
2020-06-03 6:16 ` Stankiewicz, Piotr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4be034bd-c11d-4f8b-153d-f771c1ea71e7@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=piotr.stankiewicz@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.