From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD2AC4167B for ; Fri, 11 Nov 2022 14:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234605AbiKKOwJ (ORCPT ); Fri, 11 Nov 2022 09:52:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234618AbiKKOv5 (ORCPT ); Fri, 11 Nov 2022 09:51:57 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87510532CE for ; Fri, 11 Nov 2022 06:51:54 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id l12so8657830lfp.6 for ; Fri, 11 Nov 2022 06:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WpJrWqQ4CmduKv0xmnoR71zLFn6VuVuiVCxb/WoP7jw=; b=fqxlXcq+FU5VCkPezsP78XhBSunFUXqWZOGoLYNGWvIlsFzDrxH+fffvMyy8/zyQz7 7aVn6RAHyDHtwmUbiie5n7b5fsdBa0s64JmTGm+mqRM+bt10Rk7/XHhXwCdAx51WOnmR SZv2DFEna/mE8TJ6qpoMczqimg2TQFH7kvC3Cn/oo+D0bbOD3buxxpMGHGqqymqNNVBN Z0mOmBaaa+8sWxTCDXyxI7JJqC8HsZYwe+jiF/FccH+v3o7Q/4CdWSZb7/buaw0X7Q2K mJOVSQXYMZ5wYhCyS6tOE25ezrGtn3tNSKeU+yRCAGAYULNK6vWB7wxSS11k1vJPIMZ0 9fqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WpJrWqQ4CmduKv0xmnoR71zLFn6VuVuiVCxb/WoP7jw=; b=dPLwhC43N9wpVRYr8ykyGdkePyJPKogAMJGIMtTda8u2vJ2nkMzgWpkw2R4wPLhRD/ WHRdH4UWeIwpWoLFYYiz4l1mg66+eXEl5+/aDlYFj2GzJfspE/UkmKboa6+iwLxhLHSm cFtY7TEFxXmAXRlgUkobxF1763OIjNsBCHWzDkt0qt16ISQV8Y+z+Gw5TY5l4ujdcerp JewFdf1fQsac9wZJheuf0p9IFnP0d9ugD08Y+0klL0/Tte1Y4plEBGgSY/xr6zE8/nds /ikbHqBYuQ6f4XOph+ZZIOuF30rAMVBFtAMTkNBsHGdHzuAk25R9E946hDAr2q+reh3A KxsA== X-Gm-Message-State: ANoB5pkbPlATOO5U0Ur/KO+CIo8OilDMNWez34AoERq+4Y6cQALPvOxF aGRiXKqPV41v64GE5FJYgzsemw== X-Google-Smtp-Source: AA0mqf6s1mgFbp0tWuMwPtCgw1cwtoLS3J09NnMzCfNlJmqztP9DDfkjd2V5z39BtLIJeTuIt490jQ== X-Received: by 2002:ac2:48b4:0:b0:497:ca2:4e74 with SMTP id u20-20020ac248b4000000b004970ca24e74mr868206lfg.488.1668178312891; Fri, 11 Nov 2022 06:51:52 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id w26-20020ac2443a000000b004acbfa4a18bsm360465lfl.173.2022.11.11.06.51.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 06:51:52 -0800 (PST) Message-ID: <4be61c49-c16a-0725-3b90-216ac808eaa1@linaro.org> Date: Fri, 11 Nov 2022 15:51:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 4/9] dt-bindings: mfd: mediatek: Add bindings for MT6357 PMIC Content-Language: en-US To: Alexandre Mergnat , Fabien Parent , Alexandre Belloni , Krzysztof Kozlowski , Sean Wang , Mark Brown , Matthias Brugger , Lee Jones , Chen Zhong , Alessandro Zummo , Pavel Machek , Rob Herring , Liam Girdwood , Dmitry Torokhov Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, AngeloGioacchino Del Regno , Fabien Parent , linux-rtc@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, Mattijs Korpershoek References: <20221005-mt6357-support-v4-0-5d2bb58e6087@baylibre.com> <20221005-mt6357-support-v4-4-5d2bb58e6087@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20221005-mt6357-support-v4-4-5d2bb58e6087@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 08/11/2022 19:43, Alexandre Mergnat wrote: > Currently, almost all MT63XX PMIC are documented mfd/mt6397.txt. > Unfortunately, the PMICs haven't always similar HW sub-features. > To have a better human readable schema, I chose to make one PMIC schema > to match the exact HW capabilities instead of convert mt6397.txt to > mediatek,mt63xx.yaml and put a bunch of properties behind > "if contain ... then ..." > > - add interrupt property > - change property refs to match with new yaml documentation > > Signed-off-by: Alexandre Mergnat > --- > .../devicetree/bindings/mfd/mediatek,mt6357.yaml | 102 +++++++++++++++++++++ > 1 file changed, 102 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml > new file mode 100644 > index 000000000000..7b421f21d3f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/mediatek,mt6357.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6357 Multifunction Device Driver Multifunction Device is Linux specific, drop. Driver is not hardware related, drop. Instead describe the hardware. It's PMIC right? So call it a PMIC. > + > +maintainers: > + - Alexandre Mergnat > + > +description: | > + MT6357 is a power management system chip containing 5 buck > + converters and 29 LDOs. Supported features are audio codec, > + USB battery charging, fuel gauge, RTC > + > + This is a multifunction device with the following sub modules: > + - Regulator > + - RTC > + - Keys > + > + It is interfaced to host controller using SPI interface by a proprietary hardware > + called PMIC wrapper or pwrap. This MFD is a child device of pwrap. > + See the following for pwrap node definitions: > + ../soc/mediatek/mediatek,pwrap.yaml > + > +properties: > + compatible: > + const: mediatek,mt6357 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 2 > + > + regulators: > + type: object > + $ref: ../regulator/mediatek,mt6357-regulator.yaml Full path, so /schemas/regulator/...... > + description: > + Child node that specify the regulator. Improve your descriptions. "Child node" - it is obvious, it's an object. "Specify" - no need. "the regulator" one regulator? > + > + rtc: > + type: object > + $ref: ../rtc/mediatek,mt6397-rtc.yaml Ditto > + description: > + Child node that specify the RTC. MT6357 Real Time Clock > + > + keys: > + type: object > + $ref: ../input/mediatek,pmic-keys.yaml ditto > + description: > + Child node that specify the keys. MT6357 ... > + > +required: > + - compatible > + - regulators > + Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F5A6C4332F for ; Fri, 11 Nov 2022 14:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pnA7SGajPKxkb371qlROvGLjdQTvPazePES4UbA9ReY=; b=X2FO+T8guHS3Ql 6vFONCWowx3BJTVkIkMdqyFRhpq4Pq5LzXvaSaCJpV56ay7zq+USlS5rtoTRfjZnGZJ0xH2QupMMR u+xxP/QcoDqkqm9/+JycaZ/B1qoh7py1icYC0ihYjRfgstWiwAZrRO4s2U+hmiUyNfMyM4t8SPP9c qSm5NqYOy6NHK4ECUaSIUZ8ZEEeDWxVnRb3lds6xBUTd2gM48Wdl7Zfg1hfsD+jj0oRp3jC/r5lsb v6gdLdQUU4LCR2F0s92n4jgwyqyCJsjPcbkP25DEZUa4eXDsPgSVjzQTQaWK1FMOLu2LNkzFwS1bU VnayYr4YqOJp92EoWtKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otVNt-00GLvD-QR; Fri, 11 Nov 2022 14:51:57 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otVNq-00GLtD-Ik for linux-arm-kernel@lists.infradead.org; Fri, 11 Nov 2022 14:51:56 +0000 Received: by mail-lf1-x131.google.com with SMTP id be13so8672261lfb.4 for ; Fri, 11 Nov 2022 06:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WpJrWqQ4CmduKv0xmnoR71zLFn6VuVuiVCxb/WoP7jw=; b=fqxlXcq+FU5VCkPezsP78XhBSunFUXqWZOGoLYNGWvIlsFzDrxH+fffvMyy8/zyQz7 7aVn6RAHyDHtwmUbiie5n7b5fsdBa0s64JmTGm+mqRM+bt10Rk7/XHhXwCdAx51WOnmR SZv2DFEna/mE8TJ6qpoMczqimg2TQFH7kvC3Cn/oo+D0bbOD3buxxpMGHGqqymqNNVBN Z0mOmBaaa+8sWxTCDXyxI7JJqC8HsZYwe+jiF/FccH+v3o7Q/4CdWSZb7/buaw0X7Q2K mJOVSQXYMZ5wYhCyS6tOE25ezrGtn3tNSKeU+yRCAGAYULNK6vWB7wxSS11k1vJPIMZ0 9fqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WpJrWqQ4CmduKv0xmnoR71zLFn6VuVuiVCxb/WoP7jw=; b=R1v/S2NxCKD6or0QmGTlvAQO3gJrFnF7GYB6CFcRgd3EEd0CMkx0Jitm65SynCiHlJ 2E5kbTDVmw1WLwph1VYEdMgkzZuHCzoa6Gs8IAkz8e+Ftogniq6Zip+FC0Vyc5pW+rts jHgZirbeCqZ/KTgtoes11dGs4NDmPlnGHGODXwy0QPyVjeckFVG1DfRnekXXPkl1tlZk SnBjaNT3IhVeTRD5uaP3x2kPKOfQzNT/sfMyEU1YEuxPCqwGnI9+PDgebMgnlT4yWAU5 qRI0MoX1ZzE5nWunxiaFMqdR1fManCEDcKTdh5bvdE9Rp4nS9Cy6cVwE1reM4h0GB9b0 svEA== X-Gm-Message-State: ANoB5pn0oBCQ84SEwXp0HEvVX6pJZ3HTb4er/cY6qBaZrtTPpiOviU80 RC7ZhshE9KRVRU+3gkfCQn9YuA== X-Google-Smtp-Source: AA0mqf6s1mgFbp0tWuMwPtCgw1cwtoLS3J09NnMzCfNlJmqztP9DDfkjd2V5z39BtLIJeTuIt490jQ== X-Received: by 2002:ac2:48b4:0:b0:497:ca2:4e74 with SMTP id u20-20020ac248b4000000b004970ca24e74mr868206lfg.488.1668178312891; Fri, 11 Nov 2022 06:51:52 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id w26-20020ac2443a000000b004acbfa4a18bsm360465lfl.173.2022.11.11.06.51.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 06:51:52 -0800 (PST) Message-ID: <4be61c49-c16a-0725-3b90-216ac808eaa1@linaro.org> Date: Fri, 11 Nov 2022 15:51:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 4/9] dt-bindings: mfd: mediatek: Add bindings for MT6357 PMIC Content-Language: en-US To: Alexandre Mergnat , Fabien Parent , Alexandre Belloni , Krzysztof Kozlowski , Sean Wang , Mark Brown , Matthias Brugger , Lee Jones , Chen Zhong , Alessandro Zummo , Pavel Machek , Rob Herring , Liam Girdwood , Dmitry Torokhov Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, AngeloGioacchino Del Regno , Fabien Parent , linux-rtc@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, Mattijs Korpershoek References: <20221005-mt6357-support-v4-0-5d2bb58e6087@baylibre.com> <20221005-mt6357-support-v4-4-5d2bb58e6087@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20221005-mt6357-support-v4-4-5d2bb58e6087@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221111_065154_657662_C3CCB8E5 X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/11/2022 19:43, Alexandre Mergnat wrote: > Currently, almost all MT63XX PMIC are documented mfd/mt6397.txt. > Unfortunately, the PMICs haven't always similar HW sub-features. > To have a better human readable schema, I chose to make one PMIC schema > to match the exact HW capabilities instead of convert mt6397.txt to > mediatek,mt63xx.yaml and put a bunch of properties behind > "if contain ... then ..." > > - add interrupt property > - change property refs to match with new yaml documentation > > Signed-off-by: Alexandre Mergnat > --- > .../devicetree/bindings/mfd/mediatek,mt6357.yaml | 102 +++++++++++++++++++++ > 1 file changed, 102 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml > new file mode 100644 > index 000000000000..7b421f21d3f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/mediatek,mt6357.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6357 Multifunction Device Driver Multifunction Device is Linux specific, drop. Driver is not hardware related, drop. Instead describe the hardware. It's PMIC right? So call it a PMIC. > + > +maintainers: > + - Alexandre Mergnat > + > +description: | > + MT6357 is a power management system chip containing 5 buck > + converters and 29 LDOs. Supported features are audio codec, > + USB battery charging, fuel gauge, RTC > + > + This is a multifunction device with the following sub modules: > + - Regulator > + - RTC > + - Keys > + > + It is interfaced to host controller using SPI interface by a proprietary hardware > + called PMIC wrapper or pwrap. This MFD is a child device of pwrap. > + See the following for pwrap node definitions: > + ../soc/mediatek/mediatek,pwrap.yaml > + > +properties: > + compatible: > + const: mediatek,mt6357 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 2 > + > + regulators: > + type: object > + $ref: ../regulator/mediatek,mt6357-regulator.yaml Full path, so /schemas/regulator/...... > + description: > + Child node that specify the regulator. Improve your descriptions. "Child node" - it is obvious, it's an object. "Specify" - no need. "the regulator" one regulator? > + > + rtc: > + type: object > + $ref: ../rtc/mediatek,mt6397-rtc.yaml Ditto > + description: > + Child node that specify the RTC. MT6357 Real Time Clock > + > + keys: > + type: object > + $ref: ../input/mediatek,pmic-keys.yaml ditto > + description: > + Child node that specify the keys. MT6357 ... > + > +required: > + - compatible > + - regulators > + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel