From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v8 for-4.9 2/5] hvm/dmop: Make copy_buf_{from, to}_guest for a buffer not big enough an error. Date: Fri, 21 Apr 2017 14:09:14 +0000 Message-ID: <4be7faa6ba6649b7b512d899530b273f@AMSPEX02CL03.citrite.net> References: <1492783552-29472-1-git-send-email-jennifer.herbert@citrix.com> <1492783552-29472-2-git-send-email-jennifer.herbert@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1492783552-29472-2-git-send-email-jennifer.herbert@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Xen-devel Cc: Andrew Cooper , Julien Grall , Jennifer Herbert , Jan Beulich List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IGplbm5pZmVyLmhlcmJlcnRAY2l0 cml4LmNvbSBbbWFpbHRvOmplbm5pZmVyLmhlcmJlcnRAY2l0cml4LmNvbV0KPiBTZW50OiAyMSBB cHJpbCAyMDE3IDE1OjA2Cj4gVG86IFhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+ Cj4gQ2M6IEplbm5pZmVyIEhlcmJlcnQgPGplbm5pZmVyLmhlcmJlcnRAY2l0cml4LmNvbT47IEpl bm5pZmVyIEhlcmJlcnQKPiA8amVubmlmZXIuaGVyYmVydEBjaXRyaXguY29tPjsgUGF1bCBEdXJy YW50IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT47Cj4gQW5kcmV3IENvb3BlciA8QW5kcmV3LkNv b3BlcjNAY2l0cml4LmNvbT47IEphbiBCZXVsaWNoCj4gPEpCZXVsaWNoQHN1c2UuY29tPjsgSnVs aWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiBTdWJqZWN0OiBbUEFUQ0ggdjggZm9y LTQuOSAyLzVdIGh2bS9kbW9wOiBNYWtlIGNvcHlfYnVmX3tmcm9tLAo+IHRvfV9ndWVzdCBmb3Ig YSBidWZmZXIgbm90IGJpZyBlbm91Z2ggYW4gZXJyb3IuCj4gCj4gRnJvbTogSmVubmlmZXIgSGVy YmVydCA8amVubmlmZXIuaGVyYmVydEBjaXRyaXguY29tPgo+IAo+IFRoaXMgbWFrZXMgY29weWlu ZyB0byBvciBmcm9tIGEgYnVmIHRoYXQgaXNuJ3QgYmlnIGVub3VnaCBhbiBlcnJvci4KPiBJZiB0 aGUgYnVmZmVyIGlzbnQgYmlnIGVub3VnaCwgdHJ5aW5nIHRvIGNhcnJ5IG9uIHJlZ2FyZGxlc3MK PiBjYW4gb25seSBjYXVzZSB0cm91YmxlIGxhdGVyIG9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEpl bm5pZmVyIEhlcmJlcnQgPEplbm5pZmVyLkhlcmJlcnRAY2l0cml4LmNvbT4KClJldmlld2VkLWJ5 OiBQYXVsIER1cnJhbnQgPHBhdWwuZHVycmFudEBjaXRyaXguY29tPgoKPiAtLQo+IENDOiBQYXVs IER1cnJhbnQgPHBhdWwuZHVycmFudEBjaXRyaXguY29tPgo+IENDOiBBbmRyZXcgQ29vcGVyIDxh bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgo+IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3Vz ZS5jb20+Cj4gQ0M6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+Cj4gLS0tCj4g U3dpdGNoIGJ1Zl9ieXRlcyB0byB7ZHN0LCBzcmN9X2J5dGVzIGZvciBjb3B5X3tmcm9tLHRvfV9n dWVzdAo+IC0tLQo+ICB4ZW4vYXJjaC94ODYvaHZtL2RtLmMgfCAxOCArKysrKysrKysrLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vZG0uYyBiL3hlbi9hcmNoL3g4Ni9odm0v ZG0uYwo+IGluZGV4IGU1ODNlNDEuLjg5MTg2ZDIgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2 L2h2bS9kbS5jCj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS9kbS5jCj4gQEAgLTM2LDMwICszNiwz MiBAQCBzdGF0aWMgYm9vbCBjb3B5X2J1Zl9mcm9tX2d1ZXN0KGNvbnN0Cj4geGVuX2RtX29wX2J1 Zl90IGJ1ZnNbXSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp bnQgbnJfYnVmcywgdm9pZCAqZHN0LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHVuc2lnbmVkIGludCBpZHgsIHNpemVfdCBkc3Rfc2l6ZSkKPiAgewo+IC0gICAgc2l6ZV90IHNp emU7Cj4gKyAgICBzaXplX3QgYnVmX2J5dGVzOwo+IAo+ICAgICAgaWYgKCBpZHggPj0gbnJfYnVm cyApCj4gICAgICAgICAgcmV0dXJuIGZhbHNlOwo+IAo+IC0gICAgbWVtc2V0KGRzdCwgMCwgZHN0 X3NpemUpOwo+IC0KPiAtICAgIHNpemUgPSBtaW5fdChzaXplX3QsIGRzdF9zaXplLCBidWZzW2lk eF0uc2l6ZSk7Cj4gKyAgICBidWZfYnl0ZXMgPSBidWZzW2lkeF0uc2l6ZTsKPiArICAgIGlmICgg ZHN0X3NpemUgPiBidWZfYnl0ZXMgKQo+ICsgICAgICAgIHJldHVybiBmYWxzZTsKPiAKPiAtICAg IHJldHVybiAhY29weV9mcm9tX2d1ZXN0KGRzdCwgYnVmc1tpZHhdLmgsIHNpemUpOwo+ICsgICAg cmV0dXJuICFjb3B5X2Zyb21fZ3Vlc3QoZHN0LCBidWZzW2lkeF0uaCwgZHN0X3NpemUpOwo+ICB9 Cj4gCj4gIHN0YXRpYyBib29sIGNvcHlfYnVmX3RvX2d1ZXN0KGNvbnN0IHhlbl9kbV9vcF9idWZf dCBidWZzW10sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBu cl9idWZzLCB1bnNpZ25lZCBpbnQgaWR4LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb25zdCB2b2lkICpzcmMsIHNpemVfdCBzcmNfc2l6ZSkKPiAgewo+IC0gICAgc2l6ZV90IHNp emU7Cj4gKyAgICBzaXplX3QgYnVmX2J5dGVzOwo+IAo+ICAgICAgaWYgKCBpZHggPj0gbnJfYnVm cyApCj4gICAgICAgICAgcmV0dXJuIGZhbHNlOwo+IAo+IC0gICAgc2l6ZSA9IG1pbl90KHNpemVf dCwgYnVmc1tpZHhdLnNpemUsIHNyY19zaXplKTsKPiArICAgIGJ1Zl9ieXRlcyA9IGJ1ZnNbaWR4 XS5zaXplOwo+ICsgICAgaWYgKCBzcmNfc2l6ZSA+IGJ1Zl9ieXRlcyApCj4gKyAgICAgICAgcmV0 dXJuIGZhbHNlOwo+IAo+IC0gICAgcmV0dXJuICFjb3B5X3RvX2d1ZXN0KGJ1ZnNbaWR4XS5oLCBz cmMsIHNpemUpOwo+ICsgICAgcmV0dXJuICFjb3B5X3RvX2d1ZXN0KGJ1ZnNbaWR4XS5oLCBzcmMs IHNyY19zaXplKTsKPiAgfQo+IAo+ICBzdGF0aWMgaW50IHRyYWNrX2RpcnR5X3ZyYW0oc3RydWN0 IGRvbWFpbiAqZCwgeGVuX3Bmbl90IGZpcnN0X3BmbiwKPiAtLQo+IDIuMS40CgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRl dmVsCg==