From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f179.google.com ([209.85.192.179]:36148 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbeBVTbE (ORCPT ); Thu, 22 Feb 2018 14:31:04 -0500 Received: by mail-pf0-f179.google.com with SMTP id 68so2489110pfx.3 for ; Thu, 22 Feb 2018 11:31:03 -0800 (PST) Subject: Re: [PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple To: David Miller Cc: netdev@vger.kernel.org, idosch@idosch.org, tom@herbertland.com, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com References: <20180221184954.28875-1-dsahern@gmail.com> <20180222.142717.203011955445542097.davem@davemloft.net> From: David Ahern Message-ID: <4bf77f0d-465e-c225-f789-f3f611cb3489@gmail.com> Date: Thu, 22 Feb 2018 12:31:01 -0700 MIME-Version: 1.0 In-Reply-To: <20180222.142717.203011955445542097.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/22/18 12:27 PM, David Miller wrote: > From: David Ahern > Date: Wed, 21 Feb 2018 10:49:47 -0800 > >> Patch 5 adds the L4 hash support. > > Please address Ido's feedback about how the ports aren't actually being > taken into consideration because they aren't present in the flow > information being used. It's the forwarding case; I need to add the skb to the route lookup functions. I'll send a v2 with that change in the next few days.