All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Christophe LEROY <christophe.leroy@c-s.fr>,
	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
	mpe@ellerman.id.au
Cc: "Michal Suchánek" <msuchanek@suse.de>,
	linuxppc-dev@lists.ozlabs.org,
	"Haren Myneni" <haren@linux.vnet.ibm.com>,
	"Nicholas Piggin" <npiggin@gmail.com>
Subject: Re: [PATCH v2] powerpc: Avoid code patching freed init sections
Date: Thu, 13 Sep 2018 15:48:50 +1000	[thread overview]
Message-ID: <4bfd06d41f21f6e3a57ce20e3ce155f6545a1ac3.camel@neuling.org> (raw)
In-Reply-To: <7d32de2e-b390-527d-cd5c-2c5eacc19a2c@c-s.fr>

On Thu, 2018-09-13 at 07:38 +0200, Christophe LEROY wrote:
>=20
> Le 13/09/2018 =C3=A0 03:21, Tyrel Datwyler a =C3=A9crit :
> > On 09/12/2018 05:36 PM, Michael Neuling wrote:
> > >=20
> > > >=20
> > > > > +			(unsigned long)patch_addr);
> > > >=20
> > > > Please align second line as per Codying style.
> > >=20
> > > Sorry I can't see what's wrong. You're (or Cody :-P) going to have to
> > > spell it
> > > this out for me...
> >=20
> > I suspect that the suggestion is the opening parenthesis of "(unsigned
> > long)" should sit directly under the "K" of "KERN_DEBUG". I'm pretty su=
re
> > Documentation/process/coding-style.rst is very adamant that all identat=
ion
> > is always 8 characters and spaces should never be used, but there still
> > seems to be a lot of places/suggestions that argument lists that spill =
over
> > multiple lines should be space indented to align with the very first
> > argument at the top level. So, I guess I'm not sure what the desire is =
here.
> > Although moving to pr_debug might fit it to a single line anyways. ;)
>=20
> It is exactly that, as reported by checkpatch, look at=20
> https://patchwork.ozlabs.org/patch/968850/

Sweet... looks like v3 is clean

https://patchwork.ozlabs.org/patch/969241/

Mikey

  reply	other threads:[~2018-09-13  5:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12  5:20 [PATCH v2] powerpc: Avoid code patching freed init sections Michael Neuling
2018-09-12  6:23 ` Christophe LEROY
2018-09-13  0:36   ` Michael Neuling
2018-09-13  1:21     ` Tyrel Datwyler
2018-09-13  5:38       ` Christophe LEROY
2018-09-13  5:48         ` Michael Neuling [this message]
2018-09-13  5:45     ` Christophe LEROY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bfd06d41f21f6e3a57ce20e3ce155f6545a1ac3.camel@neuling.org \
    --to=mikey@neuling.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=haren@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=msuchanek@suse.de \
    --cc=npiggin@gmail.com \
    --cc=tyreld@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.