From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFFDC43381 for ; Wed, 27 Jan 2021 20:57:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 505B564D9F for ; Wed, 27 Jan 2021 20:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344103AbhA0U52 (ORCPT ); Wed, 27 Jan 2021 15:57:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52748 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233701AbhA0U4v (ORCPT ); Wed, 27 Jan 2021 15:56:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611780916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xmqnn8rbcg26NVO4vw3SRhcUP24nD170tfktCoPpjrs=; b=ZPd/wQ9hnw95cS/MOPHuW0gUCHCZZ2inUE187aM7pECWGZzafCaEcFnjUPef/aIuquU2xn JLbvw0YH0jmvkI2g4ZuEwnsOeI4rh+6C2uFfJcUEHScwnSU4gVXpVWkCFKrwiPIMKwChm9 JMN1AEpYRJNYTlyTGysLu22ffRzVS/Q= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-C7QUd0cvOCm5W3EigL93Lw-1; Wed, 27 Jan 2021 15:55:14 -0500 X-MC-Unique: C7QUd0cvOCm5W3EigL93Lw-1 Received: by mail-ed1-f70.google.com with SMTP id j12so2026285edq.10 for ; Wed, 27 Jan 2021 12:55:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xmqnn8rbcg26NVO4vw3SRhcUP24nD170tfktCoPpjrs=; b=YTPa6JdUcoFI86ZkLVtUOxXJhvVl+fCssHzbNDcphv0D6h7ZC5bdnKQs+GLAoc8Tzt EAjAcVn4eVeuHjzI8pbh0jtOLNH4PNWdW3ChdZ+HRGtp6HdcNAliNymr9/2Rap90cuoZ arP3vBwCyTCmSKxB5PZRyDyWYZpo+rijFXltnc16S/GO98b7rMd0LzyMExQWQTu7t3ze 4+ySKGnfB0mfSO+x+7nMfM79UshabXWGTVB6nZCA1xiuB/zEAA/aDN5Q+DKp6GTOJpA5 Jv2q+w8jAvm4Xome7WPPQ5w7FMypywVOLv3jbS5F8ZSuQ752n5Wk5O5AxR++kyFjigvT u+Sw== X-Gm-Message-State: AOAM531U6Pi0zR183LSNGvd3hfWZDOznpIeNfyjgE9e65JquXS1FLWEn vPq4ZaoO6x9SQYLAaZ9Dl3hliq79fkwcJ4FisO/FNsrCJ3EpceodeWmIzZ2I4cO2iUrjOCt1jKL 7Oqhj42lkjJPugPeVes87kAss X-Received: by 2002:a17:906:3e96:: with SMTP id a22mr6365584ejj.144.1611780913252; Wed, 27 Jan 2021 12:55:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqcwMloOiDIYYh5oyrCeUlD0mjUpjFJIikqBtvrKRgSHlSo5DKK/tY/ETaq8fcb7fS7bCNTA== X-Received: by 2002:a17:906:3e96:: with SMTP id a22mr6365574ejj.144.1611780913130; Wed, 27 Jan 2021 12:55:13 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j25sm1960596edy.13.2021.01.27.12.55.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jan 2021 12:55:12 -0800 (PST) Subject: Re: [PATCH 15/24] kvm: mmu: Wrap mmu_lock cond_resched and needbreak To: Ben Gardon Cc: Sean Christopherson , LKML , kvm , Peter Xu , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20210112181041.356734-1-bgardon@google.com> <20210112181041.356734-16-bgardon@google.com> <460d38b9-d920-9339-1293-5900d242db37@redhat.com> From: Paolo Bonzini Message-ID: <4c0d4c30-a95b-7954-d344-fb991270f79a@redhat.com> Date: Wed, 27 Jan 2021 21:55:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/01/21 21:08, Ben Gardon wrote: > I'm not entirely sure I understand this suggestion. Are you suggesting > we'd have the spinlock and rwlock in a union in struct kvm but then > use a static define to choose which one is used by other functions? It > seems like if we're using static defines the union doesn't add value. Of course you're right. You'd just place the #ifdef in the struct kvm definition. You can place static inline functions for lock/unlock in virt/kvm/mmu_lock.h, in order to avoid a proliferation of #ifdefs. Paolo