All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Hao Wu" <wuhaotsh@google.com>,
	"Patrick Venture" <venture@google.com>
Cc: <cminyard@mvista.com>, <thuth@redhat.com>, <lvivier@redhat.com>,
	<pbonzini@redhat.com>, <f4bug@amsat.org>, <qemu-devel@nongnu.org>,
	Doug Evans <dje@google.com>, Titus Rwantare <titusr@google.com>
Subject: Re: [PATCH v4 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface
Date: Tue, 7 Feb 2023 10:34:31 +0100	[thread overview]
Message-ID: <4c11d47e-5d34-758f-52a8-97b99fd91486@kaod.org> (raw)
In-Reply-To: <98911d1f-59fe-4939-b022-c27b1013d9c1@linaro.org>

[ Cc: Titus, since he is maintainer of some sensor models already ]

On 2/7/23 07:51, Philippe Mathieu-Daudé wrote:
> On 7/2/23 00:24, Hao Wu wrote:
>> Hi,
>>
>> It seems like this patch set is reviewed but never merged. Who should take this patch set? What are our next steps for them?
> 
> Having some interest in interaction with emulated analog world,
> I could have an overall look at hw/sensor/. Co-maintainers welcomed!
>
>> On Mon, Jan 31, 2022 at 2:29 PM Patrick Venture <venture@google.com <mailto:venture@google.com>> wrote:
>>
>>     From: Hao Wu <wuhaotsh@google.com <mailto:wuhaotsh@google.com>>
>>
>>     SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible
>>     interface that reports AMD SoC's Ttcl (normalized temperature),
>>     and resembles a typical 8-pin remote temperature sensor's I2C interface
>>     to BMC.
>>
>>     This patch implements a basic AMD SB-TSI sensor that is
>>     compatible with the open-source data sheet from AMD and Linux
>>     kernel driver.
>>
>>     Reference:
>>     Linux kernel driver:
>>     https://lkml.org/lkml/2020/12/11/968
>>     <https://lkml.org/lkml/2020/12/11/968>
>>     Register Map:
>>     https://developer.amd.com/wp-content/resources/56255_3_03.PDF
>>     <https://developer.amd.com/wp-content/resources/56255_3_03.PDF>
>>     (Chapter 6)
>>
>>     Signed-off-by: Hao Wu <wuhaotsh@google.com <mailto:wuhaotsh@google.com>>
>>     Signed-off-by: Patrick Venture <venture@google.com
>>     <mailto:venture@google.com>>
>>     Reviewed-by: Doug Evans <dje@google.com <mailto:dje@google.com>>
>>     Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org
>>     <mailto:f4bug@amsat.org>>
>>     Acked-by: Corey Minyard <cminyard@mvista.com
>>     <mailto:cminyard@mvista.com>>
>>     ---
>>       meson.build               |   1 +
>>       hw/sensor/trace.h         |   1 +
>>       include/hw/sensor/sbtsi.h |  45 +++++
>>       hw/sensor/tmp_sbtsi.c     | 369 ++++++++++++++++++++++++++++++++++++++
>>       hw/sensor/Kconfig         |   4 +
>>       hw/sensor/meson.build     |   1 +
>>       hw/sensor/trace-events    |   5 +
>>       7 files changed, 426 insertions(+)
>>       create mode 100644 hw/sensor/trace.h
>>       create mode 100644 include/hw/sensor/sbtsi.h
>>       create mode 100644 hw/sensor/tmp_sbtsi.c
>>       create mode 100644 hw/sensor/trace-events
> 



  reply	other threads:[~2023-02-07  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 22:29 [PATCH v4 0/2] hw/sensor: Add SB-TSI Temperature Sensor Interface Patrick Venture
2022-01-31 22:29 ` [PATCH v4 1/2] " Patrick Venture
2023-02-06 23:24   ` Hao Wu
2023-02-07  6:51     ` Philippe Mathieu-Daudé
2023-02-07  9:34       ` Cédric Le Goater [this message]
2022-01-31 22:29 ` [PATCH v4 2/2] tests: add qtest for hw/sensor/sbtsi Patrick Venture

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c11d47e-5d34-758f-52a8-97b99fd91486@kaod.org \
    --to=clg@kaod.org \
    --cc=cminyard@mvista.com \
    --cc=dje@google.com \
    --cc=f4bug@amsat.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=titusr@google.com \
    --cc=venture@google.com \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.