From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIJjI-0003vM-4S for qemu-devel@nongnu.org; Mon, 14 May 2018 16:05:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIJjH-0002SN-8L for qemu-devel@nongnu.org; Mon, 14 May 2018 16:05:56 -0400 References: <20180509162637.15575-1-kwolf@redhat.com> <20180509162637.15575-10-kwolf@redhat.com> From: John Snow Message-ID: <4c227998-a548-4337-e919-eba33ba73ca6@redhat.com> Date: Mon, 14 May 2018 16:05:47 -0400 MIME-Version: 1.0 In-Reply-To: <20180509162637.15575-10-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/42] job: Rename BlockJobType into JobType List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, jcody@redhat.com, armbru@redhat.com, mreitz@redhat.com On 05/09/2018 12:26 PM, Kevin Wolf wrote: > QAPI types aren't externally visible, so we can rename them without > causing problems. Before we add a job type to Job, rename the enum > so it can be used for more than just block jobs. > So we will be registering all jobs in a central place. > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake Seems fine. Reviewed-by: John Snow