From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2A76C43334 for ; Mon, 13 Jun 2022 05:36:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232173AbiFMFf6 (ORCPT ); Mon, 13 Jun 2022 01:35:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231950AbiFMFfZ (ORCPT ); Mon, 13 Jun 2022 01:35:25 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF88713D70 for ; Sun, 12 Jun 2022 22:34:44 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id s6so7071642lfo.13 for ; Sun, 12 Jun 2022 22:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=vVFg1kFJ1ZrAuYqNU+G4M2YG4vffoF6tfug6s1kVYgc=; b=Tu0ulCRi9G/dXEAfgaijmX0Oo+JHLmSXnmrJ+MEuxOIvzY3vhXf0LacSOeN87REMdt 0EqL9howlhfqHTYOCyGIVa5yxvuBcSAQ+J5glfRzw1ieygNZvfqcNJp/hQEadqGHIoBk cVwK70e7kA/PCPZ5d4ZK0wPzt33x/rXcNf75GLCkQJ4/9yah+076fyA0Mwtpd4DFVtTE OEe7Av8QYdWetO9Jfkjje1xVuCyvJXcNowOmDKUgUK2/xylEl0nTMyJoPhlRkQlkUliw H6ZJSkmEBCbS2XIUcoiGJCr8kg+4ug0gZ3OfnLNzV6l/B7ci7LgBuBznFgJr3hgP3NQw hYDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=vVFg1kFJ1ZrAuYqNU+G4M2YG4vffoF6tfug6s1kVYgc=; b=pbi/rpIIlXyJw5tgqdYjznyXtuAtwmrNionhWyHrwbBcro4LuatLE5RCHWRdkEnBP1 SlSRRtaRn0FpS3FJXwakWcLQ6usB1vYvdQqiu8HshkT58y6ceslIpiPesB1w//KH2eO8 0MgaPyO7cvdRRCO3GIIk8T7q+gdcXTxN0KlYYOTAhR9drVAA4KC9SppJ7cIuS4l+uabB 6l1/SNXgYQGO3n57ZDHLOXNBnNerjJOgZNB1P2P8frMc4ZnzQ1wzczYHGfwoYkFh9riP IsKYF2IUqB/V7iR+gu2mJecLBPFtzApRiLRHx74pWVZ9CRhC+iHqzH3OwPnvQiWE8Ji2 JzgA== X-Gm-Message-State: AOAM533anyUiay8xiiHbiO2uT0R9QghCVfy3phzr4cI/vSUwtomFFtcr cVtc1pQFRQaej3CYu/VXi5QWrg== X-Google-Smtp-Source: ABdhPJz9g22UtbqUqRQrAPjssQkh/JLrsa/hrQftvJymHjpwcOduOutW0vw/76d3RMB9I39vIXRfzw== X-Received: by 2002:a19:5f1d:0:b0:478:f072:8dc9 with SMTP id t29-20020a195f1d000000b00478f0728dc9mr35072871lfb.440.1655098483186; Sun, 12 Jun 2022 22:34:43 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.129]) by smtp.gmail.com with ESMTPSA id p13-20020ac246cd000000b0047db8b30670sm845259lfo.136.2022.06.12.22.34.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jun 2022 22:34:42 -0700 (PDT) Message-ID: <4c393a46-f6cf-ce8a-7771-81cbbc9ca278@openvz.org> Date: Mon, 13 Jun 2022 08:34:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Vasily Averin Subject: [PATCH mm v4 1/9] memcg: enable accounting for struct cgroup To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups@vger.kernel.org References: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab@openvz.org> Content-Language: en-US In-Reply-To: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Creating each new cgroup allocates 4Kb for struct cgroup. This is the largest memory allocation in this scenario and is epecially important for small VMs with 1-2 CPUs. Common part of the cgroup creation: Allocs Alloc $1*$2 Sum Allocation number size -------------------------------------------- 16 ~ 352 5632 5632 KERNFS 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) 1 192 192 10504 (__d_alloc+0x29) 2 72 144 10648 (avc_alloc_node+0x27) 2 64 128 10776 (percpu_ref_init+0x6a) 1 64 64 10840 (memcg_list_lru_alloc+0x21a) percpu: 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f 2 12 24 312 call_site=percpu_ref_init+0x23 1 6 6 318 call_site=__percpu_counter_init+0x22 '+' -- to be accounted, '~' -- partially accounted Accounting of this memory helps to avoid misuse inside memcg-limited containers. Signed-off-by: Vasily Averin Reviewed-by: Roman Gushchin Reviewed-by: Michal Koutný Acked-by: Shakeel Butt Reviewed-by: Muchun Song --- kernel/cgroup/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 90a654cb8a1e..9adf4ad4b623 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -5353,7 +5353,7 @@ static struct cgroup *cgroup_create(struct cgroup *parent, const char *name, /* allocate the cgroup and its ID, 0 is reserved for the root */ cgrp = kzalloc(struct_size(cgrp, ancestor_ids, (level + 1)), - GFP_KERNEL); + GFP_KERNEL_ACCOUNT); if (!cgrp) return ERR_PTR(-ENOMEM); -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: [PATCH mm v4 1/9] memcg: enable accounting for struct cgroup Date: Mon, 13 Jun 2022 08:34:42 +0300 Message-ID: <4c393a46-f6cf-ce8a-7771-81cbbc9ca278@openvz.org> References: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab@openvz.org> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=vVFg1kFJ1ZrAuYqNU+G4M2YG4vffoF6tfug6s1kVYgc=; b=Tu0ulCRi9G/dXEAfgaijmX0Oo+JHLmSXnmrJ+MEuxOIvzY3vhXf0LacSOeN87REMdt 0EqL9howlhfqHTYOCyGIVa5yxvuBcSAQ+J5glfRzw1ieygNZvfqcNJp/hQEadqGHIoBk cVwK70e7kA/PCPZ5d4ZK0wPzt33x/rXcNf75GLCkQJ4/9yah+076fyA0Mwtpd4DFVtTE OEe7Av8QYdWetO9Jfkjje1xVuCyvJXcNowOmDKUgUK2/xylEl0nTMyJoPhlRkQlkUliw H6ZJSkmEBCbS2XIUcoiGJCr8kg+4ug0gZ3OfnLNzV6l/B7ci7LgBuBznFgJr3hgP3NQw hYDA== Content-Language: en-US In-Reply-To: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> List-ID: Content-Type: text/plain; charset="macroman" To: Andrew Morton Cc: kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Q3JlYXRpbmcgZWFjaCBuZXcgY2dyb3VwIGFsbG9jYXRlcyA0S2IgZm9yIHN0cnVjdCBjZ3JvdXAu IFRoaXMgaXMgdGhlCmxhcmdlc3QgbWVtb3J5IGFsbG9jYXRpb24gaW4gdGhpcyBzY2VuYXJpbyBh bmQgaXMgZXBlY2lhbGx5IGltcG9ydGFudApmb3Igc21hbGwgVk1zIHdpdGggMS0yIENQVXMuCgpD b21tb24gcGFydCBvZiB0aGUgY2dyb3VwIGNyZWF0aW9uOgpBbGxvY3MgIEFsbG9jICAgJDEqJDIg ICBTdW0gICAgIEFsbG9jYXRpb24KbnVtYmVyICBzaXplCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCjE2ICB+ICAgMzUyICAgICA1NjMyICAgIDU2MzIgICAgS0VS TkZTCjEgICArICAgNDA5NiAgICA0MDk2ICAgIDk3MjggICAgKGNncm91cF9ta2RpcisweGU0KQox ICAgICAgIDU4NCAgICAgNTg0ICAgICAxMDMxMiAgIChyYWRpeF90cmVlX25vZGVfYWxsb2MuY29u c3Rwcm9wLjArMHg4OSkKMSAgICAgICAxOTIgICAgIDE5MiAgICAgMTA1MDQgICAoX19kX2FsbG9j KzB4MjkpCjIgICAgICAgNzIgICAgICAxNDQgICAgIDEwNjQ4ICAgKGF2Y19hbGxvY19ub2RlKzB4 MjcpCjIgICAgICAgNjQgICAgICAxMjggICAgIDEwNzc2ICAgKHBlcmNwdV9yZWZfaW5pdCsweDZh KQoxICAgICAgIDY0ICAgICAgNjQgICAgICAxMDg0MCAgIChtZW1jZ19saXN0X2xydV9hbGxvYysw eDIxYSkKcGVyY3B1OgoxICAgKyAgIDE5MiAgICAgMTkyICAgICAxOTIgICAgIGNhbGxfc2l0ZT1w c2lfY2dyb3VwX2FsbG9jKzB4MWUKMSAgICsgICA5NiAgICAgIDk2ICAgICAgMjg4ICAgICBjYWxs X3NpdGU9Y2dyb3VwX3JzdGF0X2luaXQrMHg1ZgoyICAgICAgIDEyICAgICAgMjQgICAgICAzMTIg ICAgIGNhbGxfc2l0ZT1wZXJjcHVfcmVmX2luaXQrMHgyMwoxICAgICAgIDYgICAgICAgNiAgICAg ICAzMTggICAgIGNhbGxfc2l0ZT1fX3BlcmNwdV9jb3VudGVyX2luaXQrMHgyMgoKICcrJyAtLSB0 byBiZSBhY2NvdW50ZWQsCiAnficgLS0gcGFydGlhbGx5IGFjY291bnRlZAoKQWNjb3VudGluZyBv ZiB0aGlzIG1lbW9yeSBoZWxwcyB0byBhdm9pZCBtaXN1c2UgaW5zaWRlIG1lbWNnLWxpbWl0ZWQK Y29udGFpbmVycy4KClNpZ25lZC1vZmYtYnk6IFZhc2lseSBBdmVyaW4gPHZ2cy1HRUZBUXpaWDdy OGRubSt5Uk9mRTBBQHB1YmxpYy5nbWFuZS5vcmc+ClJldmlld2VkLWJ5OiBSb21hbiBHdXNoY2hp biA8cm9tYW4uZ3VzaGNoaW4tZnhVVlhmdElGRG55RzF6RU9iWHRmQUBwdWJsaWMuZ21hbmUub3Jn PgpSZXZpZXdlZC1ieTogTWljaGFsIEtvdXRuw70gPG1rb3V0bnktSUJpOVJHL2I2N2tAcHVibGlj LmdtYW5lLm9yZz4KQWNrZWQtYnk6IFNoYWtlZWwgQnV0dCA8c2hha2VlbGItaHBJcXNENEFLbGZR VDBkWlIrQWxmQUBwdWJsaWMuZ21hbmUub3JnPgpSZXZpZXdlZC1ieTogTXVjaHVuIFNvbmcgPHNv bmdtdWNodW4tRUM4VXhsNk5weWRsNTdNSWRSQ0ZEZ0BwdWJsaWMuZ21hbmUub3JnPgotLS0KIGtl cm5lbC9jZ3JvdXAvY2dyb3VwLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9rZXJuZWwvY2dyb3VwL2Nncm91cC5jIGIv a2VybmVsL2Nncm91cC9jZ3JvdXAuYwppbmRleCA5MGE2NTRjYjhhMWUuLjlhZGY0YWQ0YjYyMyAx MDA2NDQKLS0tIGEva2VybmVsL2Nncm91cC9jZ3JvdXAuYworKysgYi9rZXJuZWwvY2dyb3VwL2Nn cm91cC5jCkBAIC01MzUzLDcgKzUzNTMsNyBAQCBzdGF0aWMgc3RydWN0IGNncm91cCAqY2dyb3Vw X2NyZWF0ZShzdHJ1Y3QgY2dyb3VwICpwYXJlbnQsIGNvbnN0IGNoYXIgKm5hbWUsCiAKIAkvKiBh bGxvY2F0ZSB0aGUgY2dyb3VwIGFuZCBpdHMgSUQsIDAgaXMgcmVzZXJ2ZWQgZm9yIHRoZSByb290 ICovCiAJY2dycCA9IGt6YWxsb2Moc3RydWN0X3NpemUoY2dycCwgYW5jZXN0b3JfaWRzLCAobGV2 ZWwgKyAxKSksCi0JCSAgICAgICBHRlBfS0VSTkVMKTsKKwkJICAgICAgIEdGUF9LRVJORUxfQUND T1VOVCk7CiAJaWYgKCFjZ3JwKQogCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKIAotLSAKMi4z Ni4xCgo=