From: John Snow <jsnow@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: peter.maydell@linaro.org, crosa@redhat.com,
qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza
Date: Tue, 14 Jul 2020 15:15:57 -0400 [thread overview]
Message-ID: <4c3cc9f4-475f-d2d1-6ef3-c5a1e5856b43@redhat.com> (raw)
In-Reply-To: <87365v1qsx.fsf@linaro.org>
On 7/13/20 9:35 AM, Alex Bennée wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
>> I'm proposing that I split the actual Python library off from the other
>> miscellaneous python scripts we have and declare it maintained. Add
>> myself as a maintainer of this folder, along with Cleber.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> MAINTAINERS | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6aa54f7f8f..fe1dcd5a76 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2280,11 +2280,18 @@ S: Maintained
>> F: include/sysemu/cryptodev*.h
>> F: backends/cryptodev*.c
>>
>> +Python library
>> +M: John Snow <jsnow@redhat.com>
>> +M: Cleber Rosa <crosa@redhat.com>
>> +R: Eduardo Habkost <ehabkost@redhat.com>
>> +S: Maintained
>> +F: python/*
>
> I don't think that's equivalent to what you drop bellow:
>
> F: drivers/net/ all files in and below drivers/net
> F: drivers/net/* all files in drivers/net, but not below
>
> So I think you should drop the *
>
>> +T: git https://gitlab.com/jsnow/qemu.git python
>> +
>> Python scripts
>> M: Eduardo Habkost <ehabkost@redhat.com>
>> M: Cleber Rosa <crosa@redhat.com>
>> S: Odd fixes
>> -F: python/qemu/*py
>> F: scripts/*.py
>> F: tests/*.py
>
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
ACK on the edit, I think otherwise I'm still technically waiting for
Cleber to approve this before I would ask for someone to stage it.
--js
next prev parent reply other threads:[~2020-07-14 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 21:57 [PATCH 0/1] MAINTAINERS: Add Python library stanza John Snow
2020-07-10 21:57 ` [PATCH 1/1] " John Snow
2020-07-13 8:19 ` Philippe Mathieu-Daudé
2020-07-13 13:35 ` Alex Bennée
2020-07-13 13:59 ` John Snow
2020-07-13 14:03 ` Philippe Mathieu-Daudé
2020-07-13 14:23 ` Eduardo Habkost
2020-07-14 19:15 ` John Snow [this message]
2020-07-20 21:06 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c3cc9f4-475f-d2d1-6ef3-c5a1e5856b43@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.