From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EADCC433FE for ; Fri, 15 Apr 2022 02:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348647AbiDOCZv (ORCPT ); Thu, 14 Apr 2022 22:25:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239639AbiDOCZu (ORCPT ); Thu, 14 Apr 2022 22:25:50 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE93D433A1; Thu, 14 Apr 2022 19:23:22 -0700 (PDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kfg7F6cDXzgYSS; Fri, 15 Apr 2022 10:21:29 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Apr 2022 10:23:20 +0800 Received: from [10.174.178.178] (10.174.178.178) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Apr 2022 10:23:18 +0800 Message-ID: <4c416f09-5304-07fd-cb53-5c9c8c75f6fa@huawei.com> Date: Fri, 15 Apr 2022 10:23:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH v10 06/14] mm: multi-gen LRU: minimal implementation To: Yu Zhao CC: Stephen Rothwell , , Andi Kleen , Andrew Morton , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , "Hillf Danton" , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , "Matthew Wilcox" , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , , , , , , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-7-yuzhao@google.com> <71af92d2-0777-c318-67fb-8f7d52c800bb@huawei.com> From: Chen Wandun In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.178] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/4/15 4:53, Yu Zhao 写道: > On Thu, Apr 14, 2022 at 07:47:54PM +0800, Chen Wandun wrote: >> On 2022/4/7 11:15, Yu Zhao wrote: >>> +static void inc_min_seq(struct lruvec *lruvec) >>> +{ >>> + int type; >>> + struct lru_gen_struct *lrugen = &lruvec->lrugen; >>> + >>> + VM_BUG_ON(!seq_is_valid(lruvec)); >>> + >>> + for (type = 0; type < ANON_AND_FILE; type++) { >>> + if (get_nr_gens(lruvec, type) != MAX_NR_GENS) >>> + continue; >> I'm confused about relation between aging and LRU list operation. >> >> In function inc_max_seq,  both min_seq and max_seq will increase， >> the lrugen->lists[] indexed by lru_gen_from_seq(max_seq + 1) may >> be non-empty? > Yes. > >> for example, >> before inc_max_seq: >> min_seq == 0, lrugen->lists[0][type][zone] >> max_seq ==3, lrugen->lists[3][type][zone] >> >> after inc_max_seq: >> min_seq ==1, lrugen->lists[1][type][zone] >> max_seq ==4, lrugen->lists[0][type][zone] >> >> If lrugen->lists[0][type][zone] is not empty before inc_max_seq and it is >> the most inactive list，however lurgen->lists[0][type][zone] will become >> the most active list after inc_max_seq. > Correct. > >> So,  in this place, >> >> if (get_nr_gens(lruvec, type) != MAX_NR_GENS) >> continue; >> >> should change to >> >> if (get_nr_gens(lruvec, type) == MAX_NR_GENS) >> continue; > No, because max/min_seq will overlap if we do so. > > lrugen->lists[max_seq+1] can only be non-empty for anon LRU, for a > couple of reasons: > 1. We can't swap at all. > 2. Swapping is constrained, e.g., swapfile is full. > > Both cases are similar to a producer (the aging) overrunning a > consumer (the eviction). We used to handle them, but I simplified the > code because I don't feel they are worth handling [1]. Can lrugen->lists[max_seq+1]  also be non-empty for file LRU？ such as in dont reclaim mapped file page case(isolation will fail). If so, after aging, eviction will reclaim memory start from lrugen->lists[min_seq+1], but some oldest file page still remain in lrugen->lists[max_seq+1]. sort_folio can help to put misplaced pages to the right LRU list, but in this case, it does't help, because sort_folio only sort lrugen->lists[min_seq+1]. Thanks Wandun > > [1] https://lore.kernel.org/r/CAOUHufbDfwgm8PgCGkhCjbhMbm=fekfjgRR56NL-j+5iUGfVuw@mail.gmail.com/ > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CCD1C433F5 for ; Fri, 15 Apr 2022 02:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lVvn8JFtb2T+6kuNQCKVU0XIIrPno3Sh31m6MlRl2nI=; b=QZ+Da7LTObTD7m 0a0AqwhPCNYYJ8kLEAiozcsPHhhvJQptM5OzZrIID39z35C1NCLPUa1SMl0+9nQVi9NJicds1X5LQ VzYHYBiX2bXJZhIJvB7llSuNfy3ImhLwY5f3V6wyfWeBRNkG1dWCghCY7IDTWqGvWO0ZcqrhZJJWx r/KLoZGKXZdlqJAfPs7Xlx/LcW7TskGbyLUd9iblCIDIwEa8hwG7HaiHYuxL26T/iYpFT5ILJSt20 3UAoJcFM1DcD2JELAMWuur8Mt22AzksVoNmyxp6TvanpnCMUQhwQIltydWFFqs1xCcdkhc5fVqnTu CejeGsV+DhYrX8D7NXHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfBcQ-00866E-0G; Fri, 15 Apr 2022 02:23:30 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfBcM-008614-Hr for linux-arm-kernel@lists.infradead.org; Fri, 15 Apr 2022 02:23:28 +0000 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kfg7F6cDXzgYSS; Fri, 15 Apr 2022 10:21:29 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Apr 2022 10:23:20 +0800 Received: from [10.174.178.178] (10.174.178.178) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Apr 2022 10:23:18 +0800 Message-ID: <4c416f09-5304-07fd-cb53-5c9c8c75f6fa@huawei.com> Date: Fri, 15 Apr 2022 10:23:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH v10 06/14] mm: multi-gen LRU: minimal implementation To: Yu Zhao CC: Stephen Rothwell , , Andi Kleen , Andrew Morton , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , "Hillf Danton" , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , "Matthew Wilcox" , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , , , , , , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-7-yuzhao@google.com> <71af92d2-0777-c318-67fb-8f7d52c800bb@huawei.com> From: Chen Wandun In-Reply-To: X-Originating-IP: [10.174.178.178] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_192326_957528_CE1E1BEE X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgrlnKggMjAyMi80LzE1IDQ6NTMsIFl1IFpoYW8g5YaZ6YGTOgo+IE9uIFRodSwgQXByIDE0LCAy MDIyIGF0IDA3OjQ3OjU0UE0gKzA4MDAsIENoZW4gV2FuZHVuIHdyb3RlOgo+PiBPbiAyMDIyLzQv NyAxMToxNSwgWXUgWmhhbyB3cm90ZToKPj4+ICtzdGF0aWMgdm9pZCBpbmNfbWluX3NlcShzdHJ1 Y3QgbHJ1dmVjICpscnV2ZWMpCj4+PiArewo+Pj4gKwlpbnQgdHlwZTsKPj4+ICsJc3RydWN0IGxy dV9nZW5fc3RydWN0ICpscnVnZW4gPSAmbHJ1dmVjLT5scnVnZW47Cj4+PiArCj4+PiArCVZNX0JV R19PTighc2VxX2lzX3ZhbGlkKGxydXZlYykpOwo+Pj4gKwo+Pj4gKwlmb3IgKHR5cGUgPSAwOyB0 eXBlIDwgQU5PTl9BTkRfRklMRTsgdHlwZSsrKSB7Cj4+PiArCQlpZiAoZ2V0X25yX2dlbnMobHJ1 dmVjLCB0eXBlKSAhPSBNQVhfTlJfR0VOUykKPj4+ICsJCQljb250aW51ZTsKPj4gSSdtIGNvbmZ1 c2VkIGFib3V0IHJlbGF0aW9uIGJldHdlZW4gYWdpbmcgYW5kIExSVSBsaXN0IG9wZXJhdGlvbi4K Pj4KPj4gSW4gZnVuY3Rpb24gaW5jX21heF9zZXEswqAgYm90aCBtaW5fc2VxIGFuZCBtYXhfc2Vx IHdpbGwgaW5jcmVhc2XvvIwKPj4gdGhlIGxydWdlbi0+bGlzdHNbXSBpbmRleGVkIGJ5IGxydV9n ZW5fZnJvbV9zZXEobWF4X3NlcSArIDEpIG1heQo+PiBiZSBub24tZW1wdHk/Cj4gWWVzLgo+Cj4+ IGZvciBleGFtcGxlLAo+PiBiZWZvcmUgaW5jX21heF9zZXE6Cj4+IG1pbl9zZXEgPT0gMCwgbHJ1 Z2VuLT5saXN0c1swXVt0eXBlXVt6b25lXQo+PiBtYXhfc2VxID09MywgbHJ1Z2VuLT5saXN0c1sz XVt0eXBlXVt6b25lXQo+Pgo+PiBhZnRlciBpbmNfbWF4X3NlcToKPj4gbWluX3NlcSA9PTEsIGxy dWdlbi0+bGlzdHNbMV1bdHlwZV1bem9uZV0KPj4gbWF4X3NlcSA9PTQsIGxydWdlbi0+bGlzdHNb MF1bdHlwZV1bem9uZV0KPj4KPj4gSWYgbHJ1Z2VuLT5saXN0c1swXVt0eXBlXVt6b25lXSBpcyBu b3QgZW1wdHkgYmVmb3JlIGluY19tYXhfc2VxIGFuZCBpdCBpcwo+PiB0aGUgbW9zdCBpbmFjdGl2 ZSBsaXN077yMaG93ZXZlciBsdXJnZW4tPmxpc3RzWzBdW3R5cGVdW3pvbmVdIHdpbGwgYmVjb21l Cj4+IHRoZSBtb3N0IGFjdGl2ZSBsaXN0IGFmdGVyIGluY19tYXhfc2VxLgo+IENvcnJlY3QuCj4K Pj4gU28swqAgaW4gdGhpcyBwbGFjZSwKPj4KPj4gaWYgKGdldF9ucl9nZW5zKGxydXZlYywgdHlw ZSkgIT0gTUFYX05SX0dFTlMpCj4+IAljb250aW51ZTsKPj4KPj4gc2hvdWxkIGNoYW5nZSB0bwo+ Pgo+PiBpZiAoZ2V0X25yX2dlbnMobHJ1dmVjLCB0eXBlKSA9PSBNQVhfTlJfR0VOUykKPj4gCWNv bnRpbnVlOwo+IE5vLCBiZWNhdXNlIG1heC9taW5fc2VxIHdpbGwgb3ZlcmxhcCBpZiB3ZSBkbyBz by4KPgo+IGxydWdlbi0+bGlzdHNbbWF4X3NlcSsxXSBjYW4gb25seSBiZSBub24tZW1wdHkgZm9y IGFub24gTFJVLCBmb3IgYQo+IGNvdXBsZSBvZiByZWFzb25zOgo+IDEuIFdlIGNhbid0IHN3YXAg YXQgYWxsLgo+IDIuIFN3YXBwaW5nIGlzIGNvbnN0cmFpbmVkLCBlLmcuLCBzd2FwZmlsZSBpcyBm dWxsLgo+Cj4gQm90aCBjYXNlcyBhcmUgc2ltaWxhciB0byBhIHByb2R1Y2VyICh0aGUgYWdpbmcp IG92ZXJydW5uaW5nIGEKPiBjb25zdW1lciAodGhlIGV2aWN0aW9uKS4gV2UgdXNlZCB0byBoYW5k bGUgdGhlbSwgYnV0IEkgc2ltcGxpZmllZCB0aGUKPiBjb2RlIGJlY2F1c2UgSSBkb24ndCBmZWVs IHRoZXkgYXJlIHdvcnRoIGhhbmRsaW5nIFsxXS4KCkNhbiBscnVnZW4tPmxpc3RzW21heF9zZXEr MV3CoCBhbHNvIGJlIG5vbi1lbXB0eSBmb3IgZmlsZSBMUlXvvJ8Kc3VjaCBhcyBpbiBkb250IHJl Y2xhaW0gbWFwcGVkIGZpbGUgcGFnZSBjYXNlKGlzb2xhdGlvbiB3aWxsIGZhaWwpLgoKSWYgc28s IGFmdGVyIGFnaW5nLCBldmljdGlvbiB3aWxsIHJlY2xhaW0gbWVtb3J5IHN0YXJ0IGZyb20KbHJ1 Z2VuLT5saXN0c1ttaW5fc2VxKzFdLCBidXQgc29tZSBvbGRlc3QgZmlsZSBwYWdlIHN0aWxsCnJl bWFpbiBpbiBscnVnZW4tPmxpc3RzW21heF9zZXErMV0uCgpzb3J0X2ZvbGlvIGNhbiBoZWxwIHRv IHB1dCBtaXNwbGFjZWQgcGFnZXMgdG8gdGhlIHJpZ2h0CkxSVSBsaXN0LCBidXQgaW4gdGhpcyBj YXNlLCBpdCBkb2VzJ3QgaGVscCwgYmVjYXVzZSBzb3J0X2ZvbGlvCm9ubHkgc29ydCBscnVnZW4t Pmxpc3RzW21pbl9zZXErMV0uCgpUaGFua3MKV2FuZHVuCj4KPiBbMV0gaHR0cHM6Ly9sb3JlLmtl cm5lbC5vcmcvci9DQU9VSHVmYkRmd2dtOFBnQ0draENqYmhNYm09ZmVrZmpnUlI1Nk5MLWorNWlV R2ZWdXdAbWFpbC5nbWFpbC5jb20vCj4gLgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK