From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0bPF-0007gA-8Z for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:20:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0bP9-0000zU-8b for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:20:33 -0500 Received: from mx3-phx2.redhat.com ([209.132.183.24]:46689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0bP8-0000zC-UZ for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:20:27 -0500 Date: Thu, 23 Feb 2012 11:20:24 -0500 (EST) From: Federico Simoncelli Message-ID: <4c4db39d-8deb-4af0-b35b-20cf26986a93@zmail16.collab.prod.int.phx2.redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org ----- Original Message ----- > From: "Stefan Hajnoczi" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kwolf@redhat.com, mtosatti@redhat.com > Sent: Thursday, February 23, 2012 5:18:41 PM > Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver > > On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi > wrote: > > By the way, this code does not build against qemu.git/master. =C2=A0It > > uses > > interfaces which have been dropped. > > Ah, I see you changed that in Patch 2/3. Please don't do that, it's > hard to review and breaks git-bisect. Squashing is easy (anyone could do it at the commit phase), reviewing is hard (if you hide your changes in someone else's code). -- Federico