All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philip Oberfichtner <pro@denx.de>
To: u-boot@lists.denx.de
Cc: "Marek Vasut" <marex@denx.de>, "Tom Rini" <trini@konsulko.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
	"Stefano Babic" <sbabic@denx.de>,
	"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
	"Marek Behún" <kabel@kernel.org>, "Peng Fan" <peng.fan@nxp.com>,
	u-boot@dh-electronics.com
Subject: Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig
Date: Thu, 11 Aug 2022 12:17:04 +0200	[thread overview]
Message-ID: <4c55894ddf4682d79183a507c954b9bd88efc42f.camel@denx.de> (raw)
In-Reply-To: <fff105ee-eca4-ba35-13a1-817ed1125552@denx.de>

Hi,

following the whole discussion I figured using 'select SYS_l2_PL310 if
!SYS_L2CACHE_OFF' is the preferred solution.

Now the thing is, if I'd put this line under the ARCH_XXX Kconfig
entries, I would change behavior for many boards. Take, for example,
ARCH_MVEBU:

grep -lr ARCH_MVEBU configs | ./tools/moveconfig.py -d-
CONFIG_SYS_L2_PL310

Tells me that there are 30 ARCH_MVEBU defconfigs, of which 19 use
CONFIG_SYS_L2_PL310 and 11 don't. Those 11 boards not using it also do
not define CONFIG_SYS_L2CACHE_OFF. So using a 'select SYS_L2_PL310'
under ARCH_MVEBU would change behavior for those 11 boards.

There is a similar picture for other architectures, like SOCFPGA or
OMAP2. The only place where selecting based on CONFIG_ARCH does not
change behavior is ARCH_MX6, when excluding CONFIG_MX6UL(L).

If I didn't miss something here, there's no easy way out. Maybe to
define SYS_L2CACHE_OFF for respective boards would be an option, but I
don't know if there would be side effects.

Any other suggestions?

Best regards,
Philip


  reply	other threads:[~2022-08-11 10:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 10:06 [PATCH v3 0/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL Philip Oberfichtner
2022-08-09 10:07 ` [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig Philip Oberfichtner
2022-08-09 10:58   ` Pali Rohár
2022-08-09 11:16     ` Marek Vasut
2022-08-09 11:21       ` Pali Rohár
2022-08-09 11:27         ` Marek Vasut
2022-08-09 11:32           ` Pali Rohár
2022-08-09 11:38             ` Marek Vasut
2022-08-09 12:59               ` Pali Rohár
2022-08-09 13:16               ` Marek Behún
2022-08-09 13:18                 ` Marek Behún
2022-08-09 13:46             ` Tom Rini
2022-08-09 16:03               ` Marek Vasut
2022-08-09 16:36                 ` Tom Rini
2022-08-09 18:27                   ` Marek Vasut
2022-08-11 10:17                     ` Philip Oberfichtner [this message]
2022-08-16 14:42                       ` Philip Oberfichtner
2022-08-09 14:32         ` Phil Sutter
2022-08-12  8:39   ` Soeren Moch
2022-08-09 10:07 ` [PATCH v3 2/3] ARM: cache: Allow SPL to build cache-pl310.c Philip Oberfichtner
2022-08-09 10:07 ` [PATCH v3 3/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL Philip Oberfichtner
2022-08-09 11:17   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c55894ddf4682d79183a507c954b9bd88efc42f.camel@denx.de \
    --to=pro@denx.de \
    --cc=cniedermaier@dh-electronics.com \
    --cc=kabel@kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marex@denx.de \
    --cc=pali@kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@dh-electronics.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.