From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43D7268 for ; Sun, 31 Oct 2021 19:24:44 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id l13so32299335lfg.6 for ; Sun, 31 Oct 2021 12:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IOFynaXj47+DlqNhfU/d4IsE5HjN1tVc9N4cO4MmET4=; b=kLYYLH6ym+E5ktJuXPLBZX/GA3OEUMfSiDLKmPa6/lfv2h77RM0GMhSarcOIp4dXdG Pww/RZDBZL0LGxHtfPPNyDWO0HOgNuv4ysrj6aqljL45CsXSS7te598+2Lk0Q9cIbI8j hMttMDOtCe/QCXzhTrKtnn7KeW72ujCJ0qZBHzEnppvn71ysMn9CRRXmOCsudy6sAjEX Lbk1GajoXG+2kpo+tBJVi6fY0x7G2mxRN/tSv9joTeKfXJhCwLwfzGpGu6zE/aT990Uk yIzvXYZ4QM+RMllNWuW1xWda4niImeBYbEGmQy5ApWZdHxVv4OpW/kPEMxHMHEVLAExr NFsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IOFynaXj47+DlqNhfU/d4IsE5HjN1tVc9N4cO4MmET4=; b=iP1zsBR/zIb/7OkgVtGKru2EDVld/SzcPdG76hGcf+A+Qa/NInBqUGfxS7DZJXkdGI GF435ygMRTnITQQLni8OIDRKuZ2TobZAOjY/pq7+h9BXlsP3fMr0eGu9cuEK+6a2qys4 6OFIZHPAAMqc93IOBeL5GcJGg5l6/U/Ip7k3IWIb8FzQDnW2q1KjVfLGfllapDUNx8Bl WPcZcIap8r8zKbq+cm5EgRjR0x1fMSz7EesLCd0vCI6APn4lszuWzfiAhnd6Lq48Z6nl /0Ya6DG4qCMinOyzqiNbEvZwWbtq4pttrL8jvo5iYFGu0VB7eOmtSumh2rM4nAhtsmMR jKiA== X-Gm-Message-State: AOAM532OCT85vuUn4nxnlfQ8Ani3nNUms2LJg9nsrL7XBnGCcjiu+Ymi sA+HGuCD2dyC/5fc02+q8YA= X-Google-Smtp-Source: ABdhPJwhUZwQ0GJzjtU0NSS/3I7Zy/M+1iHcobVO6SbTJt0eMDNn00oT7qLB3FxdrBiwhATxabDuhQ== X-Received: by 2002:ac2:5298:: with SMTP id q24mr22998841lfm.529.1635708282338; Sun, 31 Oct 2021 12:24:42 -0700 (PDT) Received: from [192.168.1.11] ([94.103.235.8]) by smtp.gmail.com with ESMTPSA id m8sm289856lfr.28.2021.10.31.12.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Oct 2021 12:24:41 -0700 (PDT) Message-ID: <4c566e71-2426-b776-17a2-38f5f0b6f2b6@gmail.com> Date: Sun, 31 Oct 2021 22:24:41 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement Content-Language: en-US To: Saurav Girepunje , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Pavel Skripkin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/31/21 22:17, Saurav Girepunje wrote: > > > On 01/11/21 12:13 am, Pavel Skripkin wrote: >> On 10/31/21 21:10, Saurav Girepunje wrote: >>> Remove the goto statement from rtw_init_drv_sw(). In this function goto >>> can be replace by return statement. As on goto label exit, function >>> only return it is not performing any cleanup. Avoiding goto will >>> improve the function readability. >>> >>> Signed-off-by: Saurav Girepunje >>> --- >>>   drivers/staging/r8188eu/os_dep/os_intfs.c | 39 +++++++---------------- >>>   1 file changed, 12 insertions(+), 27 deletions(-) >>> >>> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c >>> index 1418c9c4916c..4b409479108e 100644 >>> --- a/drivers/staging/r8188eu/os_dep/os_intfs.c >>> +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c >>> @@ -480,48 +480,34 @@ u8 rtw_init_drv_sw(struct adapter *padapter) >>>   { >>>       u8    ret8 = _SUCCESS; >>> >> >> >> Btw, this variable can be removed completely then. It's used only for: >> >> ret8 = rtw_init_default_value(padapter); >> >> with your patch applied, but rtw_init_default_value() always returns _SUCCESS. >> > I think rtw_init_default_value should return void. It's return value is not useful. Sure, but you need to firstly remove `ret8 = rtw_init_default_value(padapter);` and then make it return bool to not break the build. With regards, Pavel Skripkin