From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C41C433EF for ; Thu, 23 Sep 2021 15:31:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9062560FDC for ; Thu, 23 Sep 2021 15:31:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9062560FDC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C8C8F833C1; Thu, 23 Sep 2021 17:31:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632411103; bh=1rR6O+stgGskk9I2tVj5+dzCcjdRf49FgDYYbyLBnss=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=0Yb1KMa9Ja0EfkH9QcW0x7tl+p8nEmzxaUK0sfnITPPtI1jllF5HjVS95R1q5/Uu5 nqqKqS0eJ2OO/2A2fg2oMz6Z8XZj2ruC5Ls/YtUJkKQ4VT3VS0RAXxnqtdLdVw+4MD Ancs9PrhbamM9tWPPHttzdVhNXdrIZUNQ4cxAg/q1BWaMd+AstLNKewmZXhTBmII9v bULaU5tBUm0HLKQ0afWb3xvmYw7/jQ9LrDah4V6DBWq3ZkUIWAlmikLycVDQO7PlFL Ik7W24Q/8jfjmMjZ9cKBryNR1g+NzR7wE9GRKlfQ5gA1M4kGVNZ1/2A7YvnZzahJTN kZzHuram7h7Sg== Received: by phobos.denx.de (Postfix, from userid 109) id EF6F6833CD; Thu, 23 Sep 2021 17:31:40 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6609983130 for ; Thu, 23 Sep 2021 17:31:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4HFfK51vqSzQjvc; Thu, 23 Sep 2021 17:31:37 +0200 (CEST) Subject: Re: [PATCH] arm: a37xx: pci: Increase PCIe IO size from 64 KiB to 1 MiB To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de References: <20210923090718.16906-1-pali@kernel.org> From: Stefan Roese Message-ID: <4c5adf92-d979-2569-5368-875f75482ba9@denx.de> Date: Thu, 23 Sep 2021 17:31:33 +0200 MIME-Version: 1.0 In-Reply-To: <20210923090718.16906-1-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 77DB7387 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 23.09.21 11:07, Pali Rohár wrote: > Commit 079b35a26111 ("arm: a37xx: pci: Increase PCIe MEM size from 16 MiB > to 127 MiB") increased size of PCIe MEM to 127 MiB, which is the maximal > possible size for allocated 128 MiB PCIe window. PCIe IO size in that > commit was unchanged. > > Armada 3720 PCIe controller supports 32-bit IO space mapping so it is > possible to assign more than 64 KiB if address space for IO. > > Currently controller has assigned 127 MiB + 64 KiB memory and therefore > there is 960 KiB of unused memory. So assign it to IO space by increasing > IO window from 64 KiB to 1 MiB. > > Signed-off-by: Pali Rohár > Fixes: 079b35a26111 ("arm: a37xx: pci: Increase PCIe MEM size from 16 MiB to 127 MiB") Reviewed-by: Stefan Roese Thanks, Stefan > --- > arch/arm/dts/armada-37xx.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/dts/armada-37xx.dtsi b/arch/arm/dts/armada-37xx.dtsi > index 2615b8c748c1..fec34609cf82 100644 > --- a/arch/arm/dts/armada-37xx.dtsi > +++ b/arch/arm/dts/armada-37xx.dtsi > @@ -335,14 +335,14 @@ > /* > * The 128 MiB address range [0xe8000000-0xf0000000] is > * dedicated for PCIe and can be assigned to 8 windows > - * with size a power of two. Use one 64 KiB window for > + * with size a power of two. Use one 1 MiB window for > * IO at the end and the remaining seven windows > * (totaling 127 MiB) for MEM. > */ > ranges = <0x82000000 0 0xe8000000 > 0 0xe8000000 0 0x7f00000 /* Port 0 MEM */ > - 0x81000000 0 0xefff0000 > - 0 0xefff0000 0 0x10000>; /* Port 0 IO*/ > + 0x81000000 0 0xeff00000 > + 0 0xeff00000 0 0x100000>; /* Port 0 IO*/ > }; > }; > }; > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de