All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anssi Hannula <anssi.hannula@bitwise.fi>
To: Jes Sorensen <jes.sorensen@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: rtl8xxxu does not handle ampdu_action properly
Date: Thu, 13 Feb 2020 12:41:45 +0200	[thread overview]
Message-ID: <4c668c56-1c77-102e-2e33-8ea77f9dc57c@bitwise.fi> (raw)

Hi!

Just a quick note that I noticed that rtl8xxxu does not seem to handle
ampdu_action properly.

The driver should react to a IEEE80211_AMPDU_TX_START by either calling
ieee80211_start_tx_ba_cb_irqsafe() or by returning
IEEE80211_AMPDU_TX_START_IMMEDIATE [1] or by just returning a failure
(ath10k, ath11k, wlcore do so for "fw-managed" case), but rtl8xxxu
simply sets ampdu_factor and ampdu_density via register writes and then
returns 0.
I didn't look through the agg-tx code thoroughly on what the end effect
of this is but looks like at least ieee80211_agg_tx_operational() will
never be called.

There is a similar issue with IEEE80211_AMPDU_TX_STOP_CONT and
ieee80211_stop_tx_ba_cb_irqsafe().

Quick grepping suggests all other drivers handle these properly.

[1]
https://www.kernel.org/doc/html/latest/driver-api/80211/mac80211-advanced.html?highlight=mac80211#c.ieee80211_ampdu_mlme_action

-- 
Anssi Hannula / Bitwise Oy
+358 503803997


             reply	other threads:[~2020-02-13 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 10:41 Anssi Hannula [this message]
2020-02-13 14:08 ` rtl8xxxu does not handle ampdu_action properly Anssi Hannula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c668c56-1c77-102e-2e33-8ea77f9dc57c@bitwise.fi \
    --to=anssi.hannula@bitwise.fi \
    --cc=jes.sorensen@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.