From: David Ahern <dsahern@gmail.com>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
Leon Romanovsky <leonro@mellanox.com>,
Maor Gottlieb <maorg@mellanox.com>,
"vfalico@gmail.com" <vfalico@gmail.com>,
"andy@greyhouse.net" <andy@greyhouse.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>,
Jason Gunthorpe <jgg@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>,
Alex Rosenbaum <alexr@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Mark Zhang <markz@mellanox.com>,
Parav Pandit <parav@mellanox.com>
Subject: Re: Expose bond_xmit_hash function
Date: Wed, 15 Jan 2020 11:12:54 -0700 [thread overview]
Message-ID: <4c78b341-b518-2409-1a7a-1fc41c792480@gmail.com> (raw)
In-Reply-To: <26054.1579111461@famine>
On 1/15/20 11:04 AM, Jay Vosburgh wrote:
>
>> Something similar is needed for xdp and not necessarily tied to a
>> specific bond mode. Some time back I was using this as a prototype:
>>
>> https://github.com/dsahern/linux/commit/2714abc1e629613e3485b7aa860fa3096e273cb2
>>
>> It is incomplete, but shows the intent - exporting bond_egress_slave for
>> use by other code to take a bond device and return an egress leg.
>
> This seems much less awful, but would it make bonding a
> dependency on pretty much everything?
>
The intent is to hide the bond details beyond the general "a bond has
multiple egress paths and we need to pick one". ie., all of the logic
and data structures are still private.
Exporting the function for use by modules is the easy part.
Making it accessible to core code (XDP) means ??? Obviously not a
concern when bond is built in but the usual case is a module. One
solution is to repeat the IPv6 stub format; not great from an indirect
call perspective. I have not followed the work on INDIRECT_CALL to know
if that mitigates the concern about the stub when bond is a module.
next prev parent reply other threads:[~2020-01-15 18:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 8:01 Expose bond_xmit_hash function Maor Gottlieb
2020-01-15 9:45 ` Jiri Pirko
2020-01-15 13:04 ` Maor Gottlieb
2020-01-15 14:15 ` Jiri Pirko
2020-01-15 14:33 ` Leon Romanovsky
2020-01-15 16:48 ` Jiri Pirko
2020-01-15 17:34 ` David Ahern
2020-01-15 18:04 ` Jay Vosburgh
2020-01-15 18:12 ` David Ahern [this message]
2020-01-15 20:46 ` Jiri Pirko
2020-01-15 20:58 ` David Ahern
2020-01-16 14:42 ` Andy Gospodarek
2020-01-16 15:55 ` Maor Gottlieb
2020-01-16 16:00 ` Jay Vosburgh
2020-01-19 14:52 ` Maor Gottlieb
2020-01-20 18:43 ` Jay Vosburgh
2020-01-22 7:53 ` Maor Gottlieb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c78b341-b518-2409-1a7a-1fc41c792480@gmail.com \
--to=dsahern@gmail.com \
--cc=alexr@mellanox.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jay.vosburgh@canonical.com \
--cc=jgg@mellanox.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=leonro@mellanox.com \
--cc=maorg@mellanox.com \
--cc=markz@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.