From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frederic.konrad@adacore.com>) id 1e7GOx-0000Ta-4k
	for qemu-devel@nongnu.org; Wed, 25 Oct 2017 03:47:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <frederic.konrad@adacore.com>) id 1e7GOw-00015i-Gq
	for qemu-devel@nongnu.org; Wed, 25 Oct 2017 03:46:59 -0400
Received: from mel.act-europe.fr ([2a02:2ab8:224:1::a0a:d2]:44255
	helo=smtp.eu.adacore.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <frederic.konrad@adacore.com>)
	id 1e7GOw-00014e-9L
	for qemu-devel@nongnu.org; Wed, 25 Oct 2017 03:46:58 -0400
References: <7df70170550e3a10152a3571012f507dd035ba7c.1508885974.git.pisa@cmp.felk.cvut.cz>
	<2edc282892a5572f90cc0c839eac5608da670cf3.1508885974.git.pisa@cmp.felk.cvut.cz>
From: KONRAD Frederic <frederic.konrad@adacore.com>
Message-ID: <4c78db19-d64b-2ac3-195d-a1fb74fc9ee3@adacore.com>
Date: Wed, 25 Oct 2017 09:46:56 +0200
MIME-Version: 1.0
In-Reply-To: <2edc282892a5572f90cc0c839eac5608da670cf3.1508885974.git.pisa@cmp.felk.cvut.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/6] Minor clean-up of can_pcm3680_pci.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: pisa@cmp.felk.cvut.cz
Cc: qemu-devel@nongnu.org, Marek Vasut <marex@denx.de>, Stefan Hajnoczi <stefanha@gmail.com>, Deniz Eren <deniz.eren@icloud.com>, Jan Kiszka <jan.kiszka@siemens.com>, Oliver Hartkopp <socketcan@hartkopp.net>

The same than the previous patch.

Fred

On 10/25/2017 01:29 AM, pisa@cmp.felk.cvut.cz wrote:
> From: Deniz Eren <deniz.eren@icloud.com>
> 
> Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> ---
>   hw/can/can_pcm3680_pci.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.c
> index bc6b164ea7..692aab6ab8 100644
> --- a/hw/can/can_pcm3680_pci.c
> +++ b/hw/can/can_pcm3680_pci.c
> @@ -255,8 +255,7 @@ static void pcm3680i_pci_exit(PCIDevice *pci_dev)
>       qemu_unregister_reset(pcm3680i_pci_reset, d);
>   
>       /*
> -     * regions d->s5920_io, d->sja_io and d->xilinx_io
> -     * are destroyed by QOM now
> +     * region d->sja_io is destroyed by QOM now
>        */
>       /* memory_region_destroy(&d->sja_io[0]); */
>       /* memory_region_destroy(&d->sja_io[1]); */
> @@ -308,8 +307,8 @@ static void pcm3680i_pci_class_init(ObjectClass *klass, void *data)
>       k->device_id = PCM3680i_PCI_DEVICE_ID1;
>       k->revision = 0x00;
>       k->class_id = 0x000c09;
> -    k->subsystem_vendor_id = 0x13fe;
> -    k->subsystem_id = 0xc002;
> +    k->subsystem_vendor_id = PCM3680i_PCI_VENDOR_ID1;
> +    k->subsystem_id = PCM3680i_PCI_DEVICE_ID1;
>       dc->desc = "Pcm3680i PCICANx";
>       dc->props = pcm3680i_pci_properties;
>       dc->vmsd = &vmstate_pcm3680i_pci;
>