From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in
 selftest mode
Date: Fri, 18 May 2018 09:45:00 -0700
Message-ID: <4c7e3657-902e-016b-0604-eef3448ae3d5@gmail.com>
References: <20180518071753.4768-1-bhole_prashant_q7@lab.ntt.co.jp>
 <20180518071753.4768-3-bhole_prashant_q7@lab.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "David S . Miller" <davem@davemloft.net>,
        Shuah Khan <shuah@kernel.org>, netdev@vger.kernel.org
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:39551 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751450AbeERQpF (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 18 May 2018 12:45:05 -0400
Received: by mail-pl0-f65.google.com with SMTP id c19-v6so4899623pls.6
        for <netdev@vger.kernel.org>; Fri, 18 May 2018 09:45:05 -0700 (PDT)
In-Reply-To: <20180518071753.4768-3-bhole_prashant_q7@lab.ntt.co.jp>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 05/18/2018 12:17 AM, Prashant Bhole wrote:
> In case of selftest mode, temporary cgroup environment is created but
> cgroup is not joined. It causes test failures. Fixed by joining the
> cgroup
> 
> Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> --

Thanks, LGTM. Should this be the first patch in the series though?
I wonder if after patch 1 if you would get failures without this
patch.

Acked-by: John Fastabend <john.fastabend@gmail.com>