All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kadam, Pallavi" <pallavi.kadam@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ranjit.menon@intel.com,
	Harini.Ramakrishnan@microsoft.com, Narcisa.Vasile@microsoft.com,
	dmitry.kozliuk@gmail.com, tbashar@mellanox.com
Subject: Re: [dpdk-dev] [PATCH 0/2] Windows logging
Date: Thu, 30 Apr 2020 15:18:23 -0700	[thread overview]
Message-ID: <4ca29fce-f431-6d24-923d-d6a639e77c43@intel.com> (raw)
In-Reply-To: <1680001.aGCPj5yezQ@thomas>



On 4/29/2020 11:48 PM, Thomas Monjalon wrote:
> 30/04/2020 01:24, Pallavi Kadam:
>> This patchset adds EAL logging support on Windows.
>> Logs will be sent to console output.
>>
>> Pallavi Kadam (2):
>>    eal: initialize eal logging on Windows
>>    eal: add fnmatch implementation on Windows
> 
> fnmatch is required to change the log level of logs
> specified with a globbing pattern.
> 
> I think it would be nicer to introduce fnmatch first,
> and state in the other patch that logging is supported on Windows.
> 
> Titles would be:
> eal/windows: add fnmatch implementation
> log: support on Windows
> 
> 
Ok, will interchange the sequence of the patches in v2.
Thanks,

  reply	other threads:[~2020-04-30 22:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 23:24 [dpdk-dev] [PATCH 0/2] Windows logging Pallavi Kadam
2020-04-29 23:24 ` [dpdk-dev] [PATCH 1/2] eal: initialize eal logging on Windows Pallavi Kadam
2020-04-29 23:24 ` [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation " Pallavi Kadam
2020-04-30  6:52   ` Thomas Monjalon
2020-04-30  7:30     ` Dmitry Kozlyuk
2020-05-01  1:08       ` Ranjit Menon
2020-05-04 16:51         ` Thomas Monjalon
2020-04-30  6:48 ` [dpdk-dev] [PATCH 0/2] Windows logging Thomas Monjalon
2020-04-30 22:18   ` Kadam, Pallavi [this message]
2020-05-06  1:30 ` [dpdk-dev] [PATCH v2 " Pallavi Kadam
2020-05-06  1:30   ` [dpdk-dev] [PATCH v2 1/2] eal: add fnmatch implementation Pallavi Kadam
2020-05-06  2:24     ` Narcisa Ana Maria Vasile
2020-05-06  1:30   ` [dpdk-dev] [PATCH v2 2/2] eal: add log support on Windows Pallavi Kadam
2020-05-06  2:20     ` Narcisa Ana Maria Vasile
2020-05-07 10:17     ` Thomas Monjalon
2020-05-07 10:19   ` [dpdk-dev] [PATCH v2 0/2] Windows logging Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ca29fce-f431-6d24-923d-d6a639e77c43@intel.com \
    --to=pallavi.kadam@intel.com \
    --cc=Harini.Ramakrishnan@microsoft.com \
    --cc=Narcisa.Vasile@microsoft.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=ranjit.menon@intel.com \
    --cc=tbashar@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.