On 05/09/2017 12:20 PM, Philippe Mathieu-Daudé wrote: > What about the other include, "hw/sysbus.h"? > The inlined function create_unimplemented_device() calls > sysbus_mmio_map_overlap(). Anyone willing to use "hw/misc/unimp.h" will > get a compilation failure if he does not include "hw/sysbus.h" and I > don't think it belongs to "qemu/osdep.h". That one's probably okay. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org