From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE37C10F13 for ; Sun, 14 Apr 2019 08:29:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2A00206B7 for ; Sun, 14 Apr 2019 08:29:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ci02gGpJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726283AbfDNI3e (ORCPT ); Sun, 14 Apr 2019 04:29:34 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:35641 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbfDNI3e (ORCPT ); Sun, 14 Apr 2019 04:29:34 -0400 Received: by mail-wm1-f68.google.com with SMTP id y197so4325002wmd.0 for ; Sun, 14 Apr 2019 01:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=KAaI6tBg7uM7ilsptTbncBLvlZZGDyjGS4KfGrNVheg=; b=Ci02gGpJebpIPpjz63RtUR53GSY4t0MXAzVu0xQUcC6TtJ1JO6XJgflZ0HX1K/ssYv oQWCGJnIohwt4hLNJD32uNO8ZhhV8P3KthTPFlyEPWGDOyKvCei3YmLiKb6uXVxNX+5G QfMFs/IqH0iEJh6BdQ/9pJQFzG/7FgmJc3RS/LJm9yueFxiVjP5uwhP+eW7VYLxwYa5F WijUzx+q6NXB/VFn7QJmRBFXKkWIJ8FfGwVf9MN43Lfbu88yguFAOR7lV8GZeCPecmr7 7HEabigyYdtsG3m+gIxe+AB9PW5NORolVFV8KhuOcp38+JONN7om4eHEmiAg56UpOzl6 3mbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=KAaI6tBg7uM7ilsptTbncBLvlZZGDyjGS4KfGrNVheg=; b=GzC1k9tKzOsvK5kXbo9SO1JvczUww6hiqwCl6FbB0nno+rYxOSCHKDxkPnTKc+iBIh mPa+aIzfYMmC+Losm2IRQ/4ur9yHu+a7APLgFfW4ydRqF1UnPZrE9x4jYrIQawl+t/aS 3ke/7qWqxKM+10+MopyJcU2J457E+h+/z3RyyvAlBnJ4h8sVf2GsbItINAeb3EDethDI ILRxCkH3fcgTcF/Cx8JCT1eZGkQPtOSKBg7sy8ECBnsXddupQ9nI9o9noyH+X3IPQqmO sAwc7GyRwt7UuqtGiVc/GTfhWuFYFZNOBfrP34Yux0FoeUSafIB63kJYRN/wLW9sJ+bd kMuA== X-Gm-Message-State: APjAAAUrrHtsEQoTsF6f2wVfPsMbjT1K40nFZ2N5LfYcQNAm5Jx6KSbC cxv1wQ5r5ONXWLH6jgZ1zFMo3fDn X-Google-Smtp-Source: APXvYqyeBEGEnBuH7+TyR5iyTzah8WzXaHQXtZwUm9xJtuKCFtRKp+EL/xziE9FA+fzoYluBysQfXg== X-Received: by 2002:a1c:6588:: with SMTP id z130mr18051837wmb.39.1555230572164; Sun, 14 Apr 2019 01:29:32 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:5700:9d34:bb86:3225:b2fd? (p200300EA8BD457009D34BB863225B2FD.dip0.t-ipconnect.de. [2003:ea:8bd4:5700:9d34:bb86:3225:b2fd]) by smtp.googlemail.com with ESMTPSA id h131sm19160725wmh.1.2019.04.14.01.29.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Apr 2019 01:29:31 -0700 (PDT) To: Realtek linux nic maintainers , David Miller From: Heiner Kallweit Subject: [PATCH net-next 0/2] r8169: create function pointer arrays for PHY and chip hw init functions Cc: "netdev@vger.kernel.org" Message-ID: <4cb6d89c-144b-6e9a-1a1e-1085452b96c2@gmail.com> Date: Sun, 14 Apr 2019 10:29:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Using function pointer arrays makes the code easier to read and better maintainable. AFAIK function pointer arrays cause some performance drawback due to Spectre mitigation, but we're not in a hot path. Heiner Kallweit (2): r8169: create function pointer array for PHY init functions r8169: create function pointer array for chip hw init functions drivers/net/ethernet/realtek/r8169.c | 401 +++++++++------------------ 1 file changed, 127 insertions(+), 274 deletions(-) -- 2.21.0