From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932434AbbDOWgg (ORCPT ); Wed, 15 Apr 2015 18:36:36 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:36883 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbbDOWg0 convert rfc822-to-8bit (ORCPT ); Wed, 15 Apr 2015 18:36:26 -0400 in-reply-to: <20150415173533.GA27779@dtor-ws> to: "Dmitry Torokhov" from: "Javier Martinez Canillas" message-id: <4cbc-552ee800-1-20d0ecc0@205580501> subject: =?utf-8?q?Re:_[PATCH_1/2]_Input:_atmel=5Fmxt=5Fts_-_add_support_for_Google_Pixel_2?= X-Forward: 95.21.185.221 date: Wed, 15 Apr 2015 23:36:09 +0100 MIME-Version: 1.0 content-type: text/plain; charset="utf-8" User-Agent: SOGoMail 2.2.17a cc: linux-kernel@vger.kernel.org, "Nick Dyer" , "Yufeng Shen" , "Benson Leung" , "Daniel Kurtz" , "Sjoerd Simons" , "Olof Johansson" , linux-input@vger.kernel.org content-transfer-encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Dmitry, On Wednesday, April 15, 2015 18:35 BST, Dmitry Torokhov wrote: > On Wed, Apr 15, 2015 at 05:58:04PM +0200, Javier Martinez Canillas wrote: > > > > This is an unrelated cleanup so probably should had been a separate patch? > > Fair enough. > > -- > Dmitry > > > Input: atmel_mxt_ts - use BIT() macro when reporting button state > > From: Dmitry Torokhov > > This makes the intent a tad more clear. > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 0d87ffc..0dcd455 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -726,15 +726,15 @@ static void mxt_input_button(struct mxt_data *data, u8 *message) > { > struct input_dev *input = data->input_dev; > const struct mxt_platform_data *pdata = data->pdata; > - bool button; > int i; > > - /* Active-low switch */ > for (i = 0; i < pdata->t19_num_keys; i++) { > if (pdata->t19_keymap[i] == KEY_RESERVED) > continue; > - button = !(message[1] & (1 << i)); > - input_report_key(input, pdata->t19_keymap[i], button); > + > + /* Active-low switch */ > + input_report_key(input, pdata->t19_keymap[i], > + !(message[1] & BIT(i))); > } > } > Patch looks good to me, thanks a lot for splitting the changes and sorry for the nitpicking. Reviewed-by: Javier Martinez Canillas Best regards, Javier