From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9F7C6FA82 for ; Tue, 13 Sep 2022 09:21:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231628AbiIMJVy (ORCPT ); Tue, 13 Sep 2022 05:21:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230526AbiIMJVv (ORCPT ); Tue, 13 Sep 2022 05:21:51 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A78486366 for ; Tue, 13 Sep 2022 02:21:49 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id cc5so9909922wrb.6 for ; Tue, 13 Sep 2022 02:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ec1g3CWrNzafhsMb+cfu9JbCUupSfipgUIO7L9IZBKU=; b=ox8Lw5bG4JhnlxvaRIVMOL97ZPochJEx8oU0kvBoP3mffOr6KjOlqa8yo0UT1zfpRn pol+FlGQRMQvxikfN3Vc1235pbaN6EFjZypZvImq3OezkeTx53jRoasj0SesNjhO+J+W yKRFOylIBnsztUmCu6JJkM61TLR1EDCV09WPNS02ORk8UV9k0y2VOJv93xzbIB6Frscf jCfnTmEfSX3w5WijMg1gg0jgFou0oG908cykxLe2pgfz0w0nsOlEbTvMio+lbfzE8wVv gq7UKPGlHmRZfI/DTNi2MSuBsXeA/uvmcKT9xeQEXwSk46u6Oo79Q/jyBJzpx/SJmB5+ qylA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ec1g3CWrNzafhsMb+cfu9JbCUupSfipgUIO7L9IZBKU=; b=CgV34Hgmg8apdcrgofkaObRo0Pog3DgndA8DTpBwXukn84EYfZXllT3Po5J9HVt6VT eOZa+E7Hople9OBer6sVoFjX3jdenTUYCVjMxG87QguBCbOy+Ug3iyzf9S0hPMJlvSDr gFc2dDFLQ2eufq3SKX++3OwI6jMIMsTN5mZJ9ehuxcvP4qI4TO1OPTtWl0mula7VMdBQ NKtJjMNFNpUGCN+bpwEChfE8uZLRI6IzaXyMeIF86w5MY18RXvkZV9oTWeHclC+GhzUj CwwAYQNxtBr86fWIPDXdhyLLha3ZTz7yWEeborerzC6JQ+vMWsiu0LUUQXp/hNEZopYl mOLg== X-Gm-Message-State: ACgBeo3TsKba6bm0Y3R3RPZjVAoOs59sDSFRIuvHKE5vUQBjRT5j1mZD h98zj5cnKUZYfjAEO2/mu7iICg== X-Google-Smtp-Source: AA6agR5+dW2n2bg76HDr6mbtyh9GZatzMKtyGqiqWgtb3HblKDx0HkuUFKI7JZ3gdaGefaQwBQ1tgg== X-Received: by 2002:adf:ec03:0:b0:228:76bd:76fc with SMTP id x3-20020adfec03000000b0022876bd76fcmr17648470wrn.533.1663060908297; Tue, 13 Sep 2022 02:21:48 -0700 (PDT) Received: from [10.119.22.201] ([89.101.193.70]) by smtp.gmail.com with ESMTPSA id ch16-20020a5d5d10000000b0022abd7d57b1sm1837250wrb.115.2022.09.13.02.21.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Sep 2022 02:21:47 -0700 (PDT) Message-ID: <4cc7a6d2-64ef-c176-21ad-4c3e66f664f7@linaro.org> Date: Tue, 13 Sep 2022 11:21:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt Content-Language: en-US To: Piyush Mehta , gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, balbi@kernel.org Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@amd.com, siva.durga.prasad.paladugu@amd.com, Manish Narani References: <20220912085730.390555-1-piyush.mehta@amd.com> From: Krzysztof Kozlowski In-Reply-To: <20220912085730.390555-1-piyush.mehta@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/2022 10:57, Piyush Mehta wrote: > From: Manish Narani > > The hibernation feature enabled for Xilinx ZynqMP SoC in DWC3 IP. > Added the below interrupt-names in the binding schema for the same. > > dwc_usb3: dwc3 core interrupt-names > otg: otg interrupt-names > hiber: hibernation interrupt-names This does not make sense in commit msg. Don't duplicate patch in commit msg. Where is the user (DTS) and implementation of this change? If this is specific to Xilinx, why you do not have device specific compatible? > > Signed-off-by: Manish Narani > Signed-off-by: Piyush Mehta > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index 1779d08ba1c0..618fa7bd32be 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -53,6 +53,8 @@ properties: > - const: dwc_usb3 > - items: > enum: [host, peripheral, otg] > + - items: > + enum: [dwc_usb3, otg, hiber] Best regards, Krzysztof