From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E14C43381 for ; Wed, 27 Feb 2019 00:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB851218FC for ; Wed, 27 Feb 2019 00:49:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="bb+WOE/P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729313AbfB0At3 (ORCPT ); Tue, 26 Feb 2019 19:49:29 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:35186 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727998AbfB0At3 (ORCPT ); Tue, 26 Feb 2019 19:49:29 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1R0hwm9064632; Wed, 27 Feb 2019 00:49:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=DmuCa+ywuju0LM7jh2Z7cHcazbiZaK4OhcgHeshoKwE=; b=bb+WOE/PavsJN7sTQkTLs9MBbM3Uc77nWjmURnd9mvYMdl7l2E70lFlmS7JKJNg5fOK+ QPVh++oyb+r+yWPVdZn8QzzQdzXFydbrJpqlcu8jrzbmNFaiKhfK8MeXXu2EcywNm7fR 4gsjpZmnT16/D5Vrh7L9qscXKyFc4y886+W8CGlwaP7qoG47XUfDR7JYCKBxQzdNvrg/ pvqc86nsaQCxrASCV9QmMXtn8ci0XwPQW8SohejGUGMlx3iVKgIKN/ctj/r3/VY0GVaC JJnxtg37GtyXzQhTlq1nOSnknCkF/MUXsibFONOwEmbHQRBmUGm2h4456diRPlh2i2SK RA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2qtwku7ynh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Feb 2019 00:49:16 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1R0nAb1014948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Feb 2019 00:49:10 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1R0n8gC009148; Wed, 27 Feb 2019 00:49:09 GMT Received: from [10.159.231.109] (/10.159.231.109) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 Feb 2019 16:49:08 -0800 Subject: Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) To: "Michael S. Tsirkin" , Stephen Hemminger References: <20180410142608.50f15b45@xeon-e3> <20180411075334.GK2028@nanopsycho> <20190221203808-mutt-send-email-mst@kernel.org> <581e4399-3969-aecd-e923-03bbc0880733@oracle.com> <91d4cbb1-be7a-b53c-6b2a-99bef07e7c53@intel.com> <20190222100753-mutt-send-email-mst@kernel.org> <20190225173912.26b93422@shemminger-XPS-13-9360> <20190225210428-mutt-send-email-mst@kernel.org> Cc: "Samudrala, Sridhar" , Siwei Liu , Jiri Pirko , David Miller , Netdev , virtualization@lists.linux-foundation.org, virtio-dev , "Brandeburg, Jesse" , Alexander Duyck , Jakub Kicinski , Jason Wang , liran.alon@oracle.com From: si-wei liu Organization: Oracle Corporation Message-ID: <4cd67675-b4d5-aca7-9df4-f5fc6bfa4c99@oracle.com> Date: Tue, 26 Feb 2019 16:49:06 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20190225210428-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9179 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902270003 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/25/2019 6:05 PM, Michael S. Tsirkin wrote: > On Mon, Feb 25, 2019 at 05:39:12PM -0800, Stephen Hemminger wrote: >>>>>> Moreover, you were suggesting hiding the lower slave devices anyway. There was some discussion >>>>>> about moving them to a hidden network namespace so that they are not visible from the default namespace. >>>>>> I looked into this sometime back, but did not find the right kernel api to create a network namespace within >>>>>> kernel. If so, we could use this mechanism to simulate a 1-netdev model. >>>>> Yes, that's one possible implementation (IMHO the key is to make 1-netdev >>>>> model as much transparent to a real NIC as possible, while a hidden netns is >>>>> just the vehicle). However, I recall there was resistance around this >>>>> discussion that even the concept of hiding itself is a taboo for Linux >>>>> netdev. I would like to summon potential alternatives before concluding >>>>> 1-netdev is the only solution too soon. >>>>> >>>>> Thanks, >>>>> -Siwei >>>> Your scripts would not work at all then, right? >>> At this point we don't claim images with such usage as SR-IOV live >>> migrate-able. We would flag it as live migrate-able until this ethtool >>> config issue is fully addressed and a transparent live migration >>> solution emerges in upstream eventually. >> The hyper-v netvsc with 1-dev model uses a timeout to allow udev to do its rename. >> I proposed a patch to key state change off of the udev rename, but that patch was >> rejected. > Of course that would mean nothing works without udev - was > that the objection? Could you help me find that discussion pls? Yeah, the kernel should work with and without udev rename - typically the kernel is agnostic of upcoming rename. User may opt out for kernel provided names (particularly on older distros) then no rename would ever happen. I ever thought about this approach but didn't think it would fit. But, what is the historical reason that prevents slave from being renamed after being opened? Could we specialize a code path for this kernel created device, as net_failover shouldn't carry over any history burden? Thanks, -Siwei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-5536-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 14A0B985DCC for ; Wed, 27 Feb 2019 00:49:26 +0000 (UTC) References: <20180410142608.50f15b45@xeon-e3> <20180411075334.GK2028@nanopsycho> <20190221203808-mutt-send-email-mst@kernel.org> <581e4399-3969-aecd-e923-03bbc0880733@oracle.com> <91d4cbb1-be7a-b53c-6b2a-99bef07e7c53@intel.com> <20190222100753-mutt-send-email-mst@kernel.org> <20190225173912.26b93422@shemminger-XPS-13-9360> <20190225210428-mutt-send-email-mst@kernel.org> From: si-wei liu Message-ID: <4cd67675-b4d5-aca7-9df4-f5fc6bfa4c99@oracle.com> Date: Tue, 26 Feb 2019 16:49:06 -0800 MIME-Version: 1.0 In-Reply-To: <20190225210428-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) To: "Michael S. Tsirkin" , Stephen Hemminger Cc: "Samudrala, Sridhar" , Siwei Liu , Jiri Pirko , David Miller , Netdev , virtualization@lists.linux-foundation.org, virtio-dev , "Brandeburg, Jesse" , Alexander Duyck , Jakub Kicinski , Jason Wang , liran.alon@oracle.com List-ID: On 2/25/2019 6:05 PM, Michael S. Tsirkin wrote: > On Mon, Feb 25, 2019 at 05:39:12PM -0800, Stephen Hemminger wrote: >>>>>> Moreover, you were suggesting hiding the lower slave devices anyway. There was some discussion >>>>>> about moving them to a hidden network namespace so that they are not visible from the default namespace. >>>>>> I looked into this sometime back, but did not find the right kernel api to create a network namespace within >>>>>> kernel. If so, we could use this mechanism to simulate a 1-netdev model. >>>>> Yes, that's one possible implementation (IMHO the key is to make 1-netdev >>>>> model as much transparent to a real NIC as possible, while a hidden netns is >>>>> just the vehicle). However, I recall there was resistance around this >>>>> discussion that even the concept of hiding itself is a taboo for Linux >>>>> netdev. I would like to summon potential alternatives before concluding >>>>> 1-netdev is the only solution too soon. >>>>> >>>>> Thanks, >>>>> -Siwei >>>> Your scripts would not work at all then, right? >>> At this point we don't claim images with such usage as SR-IOV live >>> migrate-able. We would flag it as live migrate-able until this ethtool >>> config issue is fully addressed and a transparent live migration >>> solution emerges in upstream eventually. >> The hyper-v netvsc with 1-dev model uses a timeout to allow udev to do its rename. >> I proposed a patch to key state change off of the udev rename, but that patch was >> rejected. > Of course that would mean nothing works without udev - was > that the objection? Could you help me find that discussion pls? Yeah, the kernel should work with and without udev rename - typically the kernel is agnostic of upcoming rename. User may opt out for kernel provided names (particularly on older distros) then no rename would ever happen. I ever thought about this approach but didn't think it would fit. But, what is the historical reason that prevents slave from being renamed after being opened? Could we specialize a code path for this kernel created device, as net_failover shouldn't carry over any history burden? Thanks, -Siwei --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org