From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECD1C04AB5 for ; Mon, 3 Jun 2019 23:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E6C726518 for ; Mon, 3 Jun 2019 23:18:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pu7fe05u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726163AbfFCXSR (ORCPT ); Mon, 3 Jun 2019 19:18:17 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46395 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfFCXSQ (ORCPT ); Mon, 3 Jun 2019 19:18:16 -0400 Received: by mail-pg1-f195.google.com with SMTP id v9so9123830pgr.13 for ; Mon, 03 Jun 2019 16:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EUXhgTEYtGABT/45PYDr+36gG4MeHzs4BYxMsQ4kJbo=; b=pu7fe05uneoe3G/NPQClfZM0d626ET/Vktv3UKmgzIZUXEbWQks1CizuG9I8nQql1D 03doDCBmSmM/yPuWyyHrBmnMu04BIRIHWEDECkfAgA0yZXng+BDYgRYG6Tq52gIa9JSl 8XIuoKz6jvGHkRyyMteyg+M/Ra6rm16XrSuKw4BmSIWEAGPiC2oZCjLCsOmXxOKpZs9D 2UwAyE/j32uuMm787NKaoavI7VjJuuDH54ENKmDVfAlTMWdvKjVqTJAX++viqaMsBazl 62M/SbZWYsk86HIVcfg1SdTbKX4QSSrxxg68kWVZYz1AqXAaKNR3tRUjLAPMBcIfwXlo VWuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EUXhgTEYtGABT/45PYDr+36gG4MeHzs4BYxMsQ4kJbo=; b=hOV8EmWIAMpwuUJWoy/kue7uxvQpOEWxtQshETKO+xc+Nbw3kX5QKYXp8Xq8RU7kt0 qn+Dl8maSmqskPb+xn7UgdPoCBo+mvbDh/yI8fbSAXj+t7CWNjxiP0jZXYq4b7Goo6NZ 8rJ57owC6ty0P7ZTNLDGUPwhf0ieKxyEP6K1I69F5barYCTmUhpricGHEi17t4Kuqi9s ndwqW+o5vcL4LXPBqtklYYeWqivyrB13RMv+Gh4n60azYglCIVn/ZusF2BusBbUoMB3A Zm9PYd/R3e8NiJmP7ZLQOcRvZShlXHY2t/X7GaNxPReiM53ye8P+08zjkwNm1JNBemwY 7N3Q== X-Gm-Message-State: APjAAAUhoIQ0uErHmTE3ug1nKXbWEWHOuP2+n75jgxNbnM2RXCOEToDi QHfyMxXfC7CHGUbqoh9WKlc= X-Google-Smtp-Source: APXvYqwKMwQErsTGmJba+xqGC668fbOvoGXho6EieQ/hdXA+wJpDoe1FdW1euKo3YnnkonCbGupY1Q== X-Received: by 2002:aa7:8b49:: with SMTP id i9mr6844153pfd.74.1559603896315; Mon, 03 Jun 2019 16:18:16 -0700 (PDT) Received: from [172.27.227.197] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id j72sm17067482pje.12.2019.06.03.16.18.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 16:18:15 -0700 (PDT) Subject: Re: [PATCH v2 net-next 4/7] ipv6: Plumb support for nexthop object in a fib6_info To: Wei Wang Cc: David Ahern , "David S . Miller" , Linux Kernel Network Developers , idosch@mellanox.com, saeedm@mellanox.com, Martin KaFai Lau References: <20190603040817.4825-1-dsahern@kernel.org> <20190603040817.4825-5-dsahern@kernel.org> <5263d3ae-1865-d935-cb03-f6dfd4604d15@gmail.com> From: David Ahern Message-ID: <4cdcdf65-4d34-603e-cb21-d649b399d760@gmail.com> Date: Mon, 3 Jun 2019 17:18:11 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/3/19 5:05 PM, Wei Wang wrote: > On Mon, Jun 3, 2019 at 3:35 PM David Ahern wrote: >> >> On 6/3/19 3:58 PM, Wei Wang wrote: >>> Hmm... I am still a bit concerned with the ip6_create_rt_rcu() call. >>> If we have a blackholed nexthop, the lookup code here always tries to >>> create an rt cache entry for every lookup. >>> Maybe we could reuse the pcpu cache logic for this? So we only create >>> new dst cache on the CPU if there is no cache created before. >> >> I'll take a look. >> BTW, I am only updating ip6_pol_route to use pcpu routes for blackhole nexthops. ip6_pol_route_lookup will continue as is. That function does not use pcpu routes and will stay as is.