All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/proj: fix build failure due to gcc bug 68485(C++)
Date: Wed, 1 Jan 2020 17:00:01 +0100	[thread overview]
Message-ID: <4ceb6ec2-4908-ad5b-b126-e7cfd21b390c@benettiengineering.com> (raw)
In-Reply-To: <20200101165417.37ed565d@windsurf>

On 1/1/20 4:54 PM, Thomas Petazzoni wrote:
> On Tue, 31 Dec 2019 16:09:57 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> +PROJ_CXXFLAGS = $(TARGET_CXXFLAGS)
>> +
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
>> +PROJ_CXXFLAGS += -O0
>> +endif
>> +
>> +PROJ_CONF_ENV += CXXFLAGS="$(PROJ_CXXFLAGS)"
> 
> The duplication of the condition was really not necessary, you can use
> the same condition to tweak the CFLAGS/CXXFLAGS values.

Oops, you're right.

> I've adjusted that and applied. Thanks!

Thank you!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

      reply	other threads:[~2020-01-01 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31 15:09 [Buildroot] [PATCH] package/proj: fix build failure due to gcc bug 68485(C++) Giulio Benetti
2020-01-01 15:54 ` Thomas Petazzoni
2020-01-01 16:00   ` Giulio Benetti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ceb6ec2-4908-ad5b-b126-e7cfd21b390c@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.