Re: [RFC PATCH 8/8] WIP: .azure-pipelines.yml: Remove evb-ast2600

[Stefan Roese <sr@denx.de>]

Hi Joel,

On 02.09.22 08:14, Stefan Roese wrote:
> Hi Joel,
> 
> On 02.09.22 08:00, Joel Stanley wrote:
>> On Fri, 2 Sept 2022 at 04:09, Joel Stanley <joel@jms.id.au> wrote:
>>>
>>> On Mon, 29 Aug 2022 at 06:23, Stefan Roese <sr@denx.de> wrote:
>>>>
>>>> The evb-ast2600 target always runs into an timeout error when run via
>>>> Azure CI. For test purpose only, this patch removes this CI build
>>>> target so that the world build can be run.
>>>>
>>>> Joel, Chia-Wei, could you perhaps take a look at this and help to fix
>>>> the problems that I'm seeing with this build target here?
>>>
>>> Where does it hang? Can you attach the logs?
>>
>> The hang appears to be in the timer code, where the spl hangs due to a
>> div by zero. When inspecting, gd->arch.timer_rate_hz is zero at this
>> point.
>>
>> However I also noticed the cycling code introduces a symbol that ends
>> up in BSS. If I give cyclic_running a non-zero value it moves back
>> into the data section, and the SPL and u-boot proper make it all the
>> way through.
> 
> I might rework the code a bit, so that cyclic does not introduce new
> static variables but uses a new data pointer in struct global_data
> instead.
> 
>> This suggests there's still something wrong with the BSS handling for
>> the 2600 SPL (not resolved by f6810b749f2e ("aspeed/ast2600: Fix SPL
>> linker script") or the follow up fix). If I use the common arm spl
>> linker script, the system boots.
> 
> Thanks for looking into this.

Using the GD for the cyclic data and instead of new static variables in
this cyclic code seems to fix this CI build issue AFAICT. I'll send an
updates patchset later today.

Thanks,
Stefan

> 
>> Chai Wei, I think we need a different solution for placing the BSS
>> outside of the flash.
> 
> Thanks,
> Stefan
> 
>> Cheers,
>>
>> Joel
>>
>>>
>>> What kind of debugging have you tried to date?
>>>
>>> Cheers,
>>>
>>> Joel
>>>
>>>>
>>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>>> Cc: Joel Stanley <joel@jms.id.au>
>>>> Cc: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
>>>> ---
>>>>   .azure-pipelines.yml | 3 ---
>>>>   1 file changed, 3 deletions(-)
>>>>
>>>> diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
>>>> index 0fa92479b4c4..e48f1667f8de 100644
>>>> --- a/.azure-pipelines.yml
>>>> +++ b/.azure-pipelines.yml
>>>> @@ -261,9 +261,6 @@ stages:
>>>>           evb_ast2500:
>>>>             TEST_PY_BD: "evb-ast2500"
>>>>             TEST_PY_ID: "--id qemu"
>>>> -        evb_ast2600:
>>>> -          TEST_PY_BD: "evb-ast2600"
>>>> -          TEST_PY_ID: "--id qemu"
>>>>           vexpress_ca9x4:
>>>>             TEST_PY_BD: "vexpress_ca9x4"
>>>>             TEST_PY_ID: "--id qemu"
>>>> -- 
>>>> 2.37.2
>>>>
> 
> Viele Grüße,
> Stefan Roese
> 

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de