From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH 2/5] drm/i915: Refactor PSR status debugfs Date: Mon, 10 Dec 2018 22:51:32 -0800 Message-ID: <4d0a8bd1fd7f37e66936ef380d02da9a4c140552.camel@intel.com> References: <20181204230032.6352-1-jose.souza@intel.com> <20181204230032.6352-2-jose.souza@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id A154B89EA9 for ; Tue, 11 Dec 2018 06:51:35 +0000 (UTC) In-Reply-To: <20181204230032.6352-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza , intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE4LTEyLTA0IGF0IDE1OjAwIC0wODAwLCBKb3PDqSBSb2JlcnRvIGRlIFNvdXph IHdyb3RlOgo+IFRoZSBvbGQgZGVidWdmcyBmaWVsZHMgd2FzIG5vdCBmb2xsb3dpbmcgYSBuYW1p bmcgcGFydGVybiBhbmQgaXQgd2FzCj4gYSBiaXQgY29uZnVzaW5nLgo+IAo+IFNvIGl0IHdlbnQg ZnJvbToKPiB+JCBzdWRvIG1vcmUgL3N5cy9rZXJuZWwvZGVidWcvZHJpLzAvaTkxNV9lZHBfcHNy X3N0YXR1cwo+IFNpbmtfU3VwcG9ydDogeWVzCj4gUFNSIG1vZGU6IFBTUjEKPiBFbmFibGVkOiB5 ZXMKPiBCdXN5IGZyb250YnVmZmVyIGJpdHM6IDB4MDAwCj4gTWFpbiBsaW5rIGluIHN0YW5kYnkg bW9kZTogbm8KPiBIVyBFbmFibGVkICYgQWN0aXZlIGJpdDogeWVzCj4gU291cmNlIFBTUiBzdGF0 dXM6IDB4MjQwNTAwMDYgW1NSRE9OQUNLXQo+IAo+IFRvOgo+IH4kIHN1ZG8gbW9yZSAvc3lzL2tl cm5lbC9kZWJ1Zy9kcmkvMC9pOTE1X2VkcF9wc3Jfc3RhdHVzCj4gU2luayBzdXBwb3J0OiB5ZXMg WzB4MDAwMDAwMDNdCj4gU3RhdHVzOiBQU1IxIGVuYWJsZWQKPiBTb3VyY2UgUFNSIGN0bDogZW5h YmxlZCBbMHg4MWYwMGUyNl0KPiBTb3VyY2UgUFNSIHN0YXR1czogU1JERU5UIFsweDQwMDQwMDA2 XQo+IEJ1c3kgZnJvbnRidWZmZXIgYml0czogMHgwMDAwMDAwMAo+IAo+IFRoZSAnTWFpbiBsaW5r IGluIHN0YW5kYnkgbW9kZScgd2FzIHJlbW92ZWQgYXMgaXQgaXMgbm90IHVzZWZ1bCBidXQKPiBp ZiBuZWVkZWQgYnkgc29tZW9uZSB0aGUgaW5mb3JtYXRpb24gaXMgc3RpbGwgaW4gdGhlIHJlZ2lz dGVyIHZhbHVlCj4gb2YgJ1NvdXJjZSBQU1IgY3RsJyBpbnNpZGUgb2YgdGhlIGJyYWNrZXRzLCBQ U1IgbW9kZSBhbmQgRW5hYmxlZCB3YXMKPiBzcXVhc2hlZCBpbnRvIFN0YXR1cywgc29tZSByZW5h bWVzIGFuZCByZW9yZGVycyBhbmQgd2UgaGF2ZSB0aGlzCj4gY2xlYW5lciB2ZXJzaW9uLiBUaGlz IHdpbGwgYWxzbyBtYWtlIGVhc3kgdG8gcGFyc2UgZGVidWdmcyBmb3IgSUdUCj4gdGVzdHMuCj4g Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBDYzogRGhpbmFr YXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gU3VnZ2VzdGVk LWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4K PiBTaWduZWQtb2ZmLWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVs LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgfCA5NiAr KysrKysrKysrKysrKystLS0tLS0tLS0tCj4gLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDkgaW5z ZXJ0aW9ucygrKSwgNDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYwo+IGluZGV4IDM4ZGNlZTFjYTA2Mi4uODYzMDNiYTAyNjY2IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtMjY2NSw3ICsyNjY1LDggQEAgREVGSU5FX1NI T1dfQVRUUklCVVRFKGk5MTVfcHNyX3Npbmtfc3RhdHVzKTsKPiAgc3RhdGljIHZvaWQKPiAgcHNy X3NvdXJjZV9zdGF0dXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBzdHJ1Y3Qg c2VxX2ZpbGUKPiAqbSkKPiAgewo+IC0JdTMyIHZhbCwgcHNyX3N0YXR1czsKPiArCXUzMiB2YWws IHN0YXR1c192YWw7Cj4gKwljb25zdCBjaGFyICpzdGF0dXMgPSAidW5rbm93biI7Cj4gIAo+ICAJ aWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkKSB7Cj4gIAkJc3RhdGljIGNvbnN0IGNoYXIg KiBjb25zdCBsaXZlX3N0YXR1c1tdID0gewo+IEBAIC0yNjgxLDE0ICsyNjgyLDExIEBAIHBzcl9z b3VyY2Vfc3RhdHVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gKmRldl9wcml2LCBzdHJ1Y3Qg c2VxX2ZpbGUgKm0pCj4gIAkJCSJCVUZfT04iLAo+ICAJCQkiVEdfT04iCj4gIAkJfTsKPiAtCQlw c3Jfc3RhdHVzID0gSTkxNV9SRUFEKEVEUF9QU1IyX1NUQVRVUyk7Cj4gLQkJdmFsID0gKHBzcl9z dGF0dXMgJiBFRFBfUFNSMl9TVEFUVVNfU1RBVEVfTUFTSykgPj4KPiAtCQkJRURQX1BTUjJfU1RB VFVTX1NUQVRFX1NISUZUOwo+IC0JCWlmICh2YWwgPCBBUlJBWV9TSVpFKGxpdmVfc3RhdHVzKSkg ewo+IC0JCQlzZXFfcHJpbnRmKG0sICJTb3VyY2UgUFNSIHN0YXR1czogMHgleCBbJXNdXG4iLAo+ IC0JCQkJICAgcHNyX3N0YXR1cywgbGl2ZV9zdGF0dXNbdmFsXSk7Cj4gLQkJCXJldHVybjsKPiAt CQl9Cj4gKwkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1IyX1NUQVRVUyk7Cj4gKwkJc3RhdHVzX3Zh bCA9ICh2YWwgJiBFRFBfUFNSMl9TVEFUVVNfU1RBVEVfTUFTSykgPj4KPiArCQkJICAgICAgRURQ X1BTUjJfU1RBVFVTX1NUQVRFX1NISUZUOwo+ICsJCWlmIChzdGF0dXNfdmFsIDwgQVJSQVlfU0la RShsaXZlX3N0YXR1cykpCj4gKwkJCXN0YXR1cyA9IGxpdmVfc3RhdHVzW3N0YXR1c192YWxdOwo+ ICAJfSBlbHNlIHsKPiAgCQlzdGF0aWMgY29uc3QgY2hhciAqIGNvbnN0IGxpdmVfc3RhdHVzW10g PSB7Cj4gIAkJCSJJRExFIiwKPiBAQCAtMjcwMCw3NCArMjY5OCw3OCBAQCBwc3Jfc291cmNlX3N0 YXR1cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ICpkZXZfcHJpdiwgc3RydWN0IHNlcV9maWxl ICptKQo+ICAJCQkiU1JET0ZGQUNLIiwKPiAgCQkJIlNSREVOVF9PTiIsCj4gIAkJfTsKPiAtCQlw c3Jfc3RhdHVzID0gSTkxNV9SRUFEKEVEUF9QU1JfU1RBVFVTKTsKPiAtCQl2YWwgPSAocHNyX3N0 YXR1cyAmIEVEUF9QU1JfU1RBVFVTX1NUQVRFX01BU0spID4+Cj4gLQkJCUVEUF9QU1JfU1RBVFVT X1NUQVRFX1NISUZUOwo+IC0JCWlmICh2YWwgPCBBUlJBWV9TSVpFKGxpdmVfc3RhdHVzKSkgewo+ IC0JCQlzZXFfcHJpbnRmKG0sICJTb3VyY2UgUFNSIHN0YXR1czogMHgleCBbJXNdXG4iLAo+IC0J CQkJICAgcHNyX3N0YXR1cywgbGl2ZV9zdGF0dXNbdmFsXSk7Cj4gLQkJCXJldHVybjsKPiAtCQl9 Cj4gKwkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1JfU1RBVFVTKTsKPiArCQlzdGF0dXNfdmFsID0g KHZhbCAmIEVEUF9QU1JfU1RBVFVTX1NUQVRFX01BU0spID4+Cj4gKwkJCSAgICAgIEVEUF9QU1Jf U1RBVFVTX1NUQVRFX1NISUZUOwo+ICsJCWlmIChzdGF0dXNfdmFsIDwgQVJSQVlfU0laRShsaXZl X3N0YXR1cykpCj4gKwkJCXN0YXR1cyA9IGxpdmVfc3RhdHVzW3N0YXR1c192YWxdOwo+ICAJfQo+ ICAKPiAtCXNlcV9wcmludGYobSwgIlNvdXJjZSBQU1Igc3RhdHVzOiAweCV4IFslc11cbiIsIHBz cl9zdGF0dXMsCj4gInVua25vd24iKTsKPiArCXNlcV9wcmludGYobSwgIlNvdXJjZSBQU1Igc3Rh dHVzOiAlcyBbMHglMDh4XVxuIiwgc3RhdHVzLCB2YWwpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50 IGk5MTVfZWRwX3Bzcl9zdGF0dXMoc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ICB7 Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBub2RlX3RvX2k5MTUobS0+ cHJpdmF0ZSk7Cj4gLQl1MzIgcHNycGVyZiA9IDA7Cj4gLQlib29sIGVuYWJsZWQgPSBmYWxzZTsK PiAtCWJvb2wgc2lua19zdXBwb3J0Owo+ICsJc3RydWN0IGk5MTVfcHNyICpwc3IgPSAmZGV2X3By aXYtPnBzcjsKPiArCWNvbnN0IGNoYXIgKnN0YXR1czsKPiArCWJvb2wgZW5hYmxlZDsKPiArCXUz MiB2YWw7Cj4gIAo+ICAJaWYgKCFIQVNfUFNSKGRldl9wcml2KSkKPiAgCQlyZXR1cm4gLUVOT0RF VjsKPiAgCj4gLQlzaW5rX3N1cHBvcnQgPSBkZXZfcHJpdi0+cHNyLnNpbmtfc3VwcG9ydDsKPiAt CXNlcV9wcmludGYobSwgIlNpbmtfU3VwcG9ydDogJXNcbiIsIHllc25vKHNpbmtfc3VwcG9ydCkp Owo+IC0JaWYgKCFzaW5rX3N1cHBvcnQpCj4gKwlzZXFfcHJpbnRmKG0sICJTaW5rIHN1cHBvcnQ6 ICVzIiwgeWVzbm8ocHNyLT5zaW5rX3N1cHBvcnQpKTsKPiArCWlmICghcHNyLT5zaW5rX3N1cHBv cnQpIHsKPiArCQlzZXFfcHV0cyhtLCAiXG4iKTsKPiAgCQlyZXR1cm4gMDsKPiArCX0KPiAgCj4g IAlpbnRlbF9ydW50aW1lX3BtX2dldChkZXZfcHJpdik7Cj4gKwltdXRleF9sb2NrKCZwc3ItPmxv Y2spOwo+ICAKPiAtCW11dGV4X2xvY2soJmRldl9wcml2LT5wc3IubG9jayk7Cj4gLQlzZXFfcHJp bnRmKG0sICJQU1IgbW9kZTogJXNcbiIsCj4gLQkJICAgZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJs ZWQgPyAiUFNSMiIgOiAiUFNSMSIpOwo+IC0Jc2VxX3ByaW50ZihtLCAiRW5hYmxlZDogJXNcbiIs IHllc25vKGRldl9wcml2LT5wc3IuZW5hYmxlZCkpOwo+IC0Jc2VxX3ByaW50ZihtLCAiQnVzeSBm cm9udGJ1ZmZlciBiaXRzOiAweCUwM3hcbiIsCj4gLQkJICAgZGV2X3ByaXYtPnBzci5idXN5X2Zy b250YnVmZmVyX2JpdHMpOwo+ICsJc2VxX3ByaW50ZihtLCAiIFsweCUwOHhdXG4iLCBwc3ItPmRw LT5wc3JfZHBjZFswXSk7ClRoaXMgY2FuIGJlIG1vdmVkIGNsb3NlciB0byB3aGVyZSAiU2luayBz dXBwb3J0IiBpcyBwcmludGVkLiBBbHNvLCAgdGhlCmV4dHJhIHplcm9lcyB0aGF0IGdldCBwcmlu dGVkIGR1ZSB0byAiJTA4eCIgbG9vayBvZGQsIHBsZWFzZSBjb25zaWRlcgpjaGFuZ2luZyBpdCB0 byAiJTAyeCIuCgo+ICAKPiAtCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkKPiAtCQll bmFibGVkID0gSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCkgJiBFRFBfUFNSMl9FTkFCTEU7Cj4gKwlp ZiAocHNyLT5lbmFibGVkKQo+ICsJCXN0YXR1cyA9IHBzci0+cHNyMl9lbmFibGVkID8gIlBTUjIg ZW5hYmxlZCIgOiAiUFNSMQo+IGVuYWJsZWQiOwo+ICAJZWxzZQo+IC0JCWVuYWJsZWQgPSBJOTE1 X1JFQUQoRURQX1BTUl9DVEwpICYgRURQX1BTUl9FTkFCTEU7Cj4gKwkJc3RhdHVzID0gImRpc2Fi bGVkIjsKPiArCXNlcV9wcmludGYobSwgIlN0YXR1czogJXNcbiIsIHN0YXR1cyk7CkNhbiB3ZSBq dXN0IHVzZSB0aGUgY3RsIGZpZWxkIGFuZCBnZXQgcmlkIG9mIHRoaXM/IFRoaXMgc3RhdHVzIGFu ZCBhbmQKdGhlIG9uZSBiZWxvdyBjYW4gYmUgY29uZnVzaW5nIHRvIHRob3NlIG5vdCBmYW1pbGlh ciB3aXRoIHRoZSBjb2RlCmJhc2UuCgpXZSBzaG91bGQgYmUgYWJsZSB0byBwYXJzZSBhbGwgdGhl IGluZm9ybWF0aW9uIHdlIG5lZWQgZnJvbSB0d28gbGluZXMKU291cmNlIFBTUiBjdGw6CQlbUFNS MSxQU1IyXSBlbmFibGVkIDxyZWcgdmFsdWU+ClNvdXJjZSBQU1Igc3RhdHVzOgk8c3RhdGU+IDxy ZWcgdmFsdWU+CgoKCj4gIAo+IC0Jc2VxX3ByaW50ZihtLCAiTWFpbiBsaW5rIGluIHN0YW5kYnkg bW9kZTogJXNcbiIsCj4gLQkJICAgeWVzbm8oZGV2X3ByaXYtPnBzci5saW5rX3N0YW5kYnkpKTsK PiArCWlmICghcHNyLT5lbmFibGVkKQo+ICsJCWdvdG8gdW5sb2NrOwo+ICAKPiAtCXNlcV9wcmlu dGYobSwgIkhXIEVuYWJsZWQgJiBBY3RpdmUgYml0OiAlc1xuIiwgeWVzbm8oZW5hYmxlZCkpOwo+ ICsJaWYgKHBzci0+cHNyMl9lbmFibGVkKSB7Cj4gKwkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1Iy X0NUTCk7Cj4gKwkJZW5hYmxlZCA9IHZhbCAmIEVEUF9QU1IyX0VOQUJMRTsKPiArCX0gZWxzZSB7 Cj4gKwkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKTsKPiArCQllbmFibGVkID0gdmFsICYg RURQX1BTUl9FTkFCTEU7Cj4gKwl9Cj4gKwlzZXFfcHJpbnRmKG0sICJTb3VyY2UgUFNSIGN0bDog JXMgWzB4JTA4eF1cbiIsCj4gKwkJICAgZW5hYmxlZGRpc2FibGVkKGVuYWJsZWQpLCB2YWwpOwo+ ICsJcHNyX3NvdXJjZV9zdGF0dXMoZGV2X3ByaXYsIG0pOwo+ICsJc2VxX3ByaW50ZihtLCAiQnVz eSBmcm9udGJ1ZmZlciBiaXRzOiAweCUwOHhcbiIsCj4gKwkJICAgcHNyLT5idXN5X2Zyb250YnVm ZmVyX2JpdHMpOwo+ICAKPiAgCS8qCj4gIAkgKiBTS0wrIFBlcmYgY291bnRlciBpcyByZXNldCB0 byAwIGV2ZXJ5dGltZSBEQyBzdGF0ZSBpcwo+IGVudGVyZWQKPiAgCSAqLwo+ICAJaWYgKElTX0hB U1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiAtCQlwc3JwZXJm ID0gSTkxNV9SRUFEKEVEUF9QU1JfUEVSRl9DTlQpICYKPiAtCQkJRURQX1BTUl9QRVJGX0NOVF9N QVNLOwo+IC0KPiAtCQlzZXFfcHJpbnRmKG0sICJQZXJmb3JtYW5jZV9Db3VudGVyOiAldVxuIiwg cHNycGVyZik7Cj4gKwkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1JfUEVSRl9DTlQpICYKPiBFRFBf UFNSX1BFUkZfQ05UX01BU0s7Cj4gKwkJc2VxX3ByaW50ZihtLCAiUGVyZm9ybWFuY2UgY291bnRl cjogJXVcbiIsIHZhbCk7Cj4gIAl9Cj4gIAo+IC0JcHNyX3NvdXJjZV9zdGF0dXMoZGV2X3ByaXYs IG0pOwo+IC0JbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cHNyLmxvY2spOwo+IC0KPiAtCWlmIChS RUFEX09OQ0UoZGV2X3ByaXYtPnBzci5kZWJ1ZykgJiBJOTE1X1BTUl9ERUJVR19JUlEpIHsKPiAr CWlmIChwc3ItPmRlYnVnICYgSTkxNV9QU1JfREVCVUdfSVJRKSB7Cj4gIAkJc2VxX3ByaW50Ziht LCAiTGFzdCBhdHRlbXB0ZWQgZW50cnkgYXQ6ICVsbGRcbiIsCj4gLQkJCSAgIGRldl9wcml2LT5w c3IubGFzdF9lbnRyeV9hdHRlbXB0KTsKPiAtCQlzZXFfcHJpbnRmKG0sICJMYXN0IGV4aXQgYXQ6 ICVsbGRcbiIsCj4gLQkJCSAgIGRldl9wcml2LT5wc3IubGFzdF9leGl0KTsKPiArCQkJICAgcHNy LT5sYXN0X2VudHJ5X2F0dGVtcHQpOwo+ICsJCXNlcV9wcmludGYobSwgIkxhc3QgZXhpdCBhdDog JWxsZFxuIiwgcHNyLT5sYXN0X2V4aXQpOwo+ICAJfQo+ICAKPiArdW5sb2NrOgo+ICsJbXV0ZXhf dW5sb2NrKCZwc3ItPmxvY2spOwo+ICAJaW50ZWxfcnVudGltZV9wbV9wdXQoZGV2X3ByaXYpOwo+ ICsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==