All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic
Date: Fri, 18 Nov 2016 19:20:50 +0100	[thread overview]
Message-ID: <4d1b0863-8c51-079a-b74e-8950c51060ff@redhat.com> (raw)
In-Reply-To: <1479394547-15249-3-git-send-email-pbonzini@redhat.com>

Am 17.11.2016 um 15:55 schrieb Paolo Bonzini:
> kvm_arch_set_irq is unused since commit b97e6de9c96.  Merge
> its functionality with kvm_arch_set_irq_inatomic.
>
> Reported-by: Jiang Biao <jiang.biao2@zte.com.cn>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

As you said, it is unused. Therefore the functionality is superfluous. 
Why merge it?

We can still introduce this later if we ever need it. Or do you have a 
concrete user in mind?

The patch in general looks good to me. Just wondering if we can't simply 
rip out that single function.

-- 

David

  reply	other threads:[~2016-11-18 18:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 14:55 [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic Paolo Bonzini
2016-11-18 18:20 ` David Hildenbrand [this message]
2016-11-18 19:20   ` Paolo Bonzini
2016-11-18 19:25     ` David Hildenbrand
2016-11-19 19:30 ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d1b0863-8c51-079a-b74e-8950c51060ff@redhat.com \
    --to=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.