All of lore.kernel.org
 help / color / mirror / Atom feed
From: liruozhu <liruozhu@huawei.com>
To: Guixin Liu <kanie@linux.alibaba.com>, <kbusch@kernel.org>,
	<axboe@fb.com>, <hch@lst.de>, <sagi@grimberg.me>
Cc: <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme-pci: use nvme core helper to cancel requests in tagset
Date: Fri, 8 Jul 2022 17:59:37 +0800	[thread overview]
Message-ID: <4d25ed5e-ef2c-2700-03ee-2bb1aca2cbbe@huawei.com> (raw)
In-Reply-To: <1657249477-88304-1-git-send-email-kanie@linux.alibaba.com>

On 2022/7/8 11:04, Guixin Liu wrote:

> Use nvme core helper nvme_cancel_tagset and nvme_cancel_admin_tagset
> instead of same logic code.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
>   drivers/nvme/host/pci.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index e7af223..ab4facf 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2720,10 +2720,8 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown)
>   	nvme_pci_disable(dev);
>   	nvme_reap_pending_cqes(dev);
>   
> -	blk_mq_tagset_busy_iter(&dev->tagset, nvme_cancel_request, &dev->ctrl);
> -	blk_mq_tagset_busy_iter(&dev->admin_tagset, nvme_cancel_request, &dev->ctrl);
> -	blk_mq_tagset_wait_completed_request(&dev->tagset);
> -	blk_mq_tagset_wait_completed_request(&dev->admin_tagset);
> +	nvme_cancel_tagset(&dev->ctrl);
> +	nvme_cancel_admin_tagset(&dev->ctrl);
>   
>   	/*
>   	 * The driver will not be starting up queues again if shutting down so

Looks good to me,

Reviewed-by:Ruozhu Li <liruozhu@huawei.com>



  reply	other threads:[~2022-07-08 10:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08  3:04 [PATCH] nvme-pci: use nvme core helper to cancel requests in tagset Guixin Liu
2022-07-08  9:59 ` liruozhu [this message]
2022-07-10 11:05 ` Sagi Grimberg
2022-07-12 15:36 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d25ed5e-ef2c-2700-03ee-2bb1aca2cbbe@huawei.com \
    --to=liruozhu@huawei.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kanie@linux.alibaba.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.