All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: monish.kumar.r@intel.com, gregkh@linuxfoundation.org,
	olebowle@gmx.com, oneukum@suse.com, vpalatin@chromium.org,
	wangjm221@gmail.com, chris.chiu@canonical.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: abhijeet.rao@intel.com
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
Date: Thu, 5 May 2022 12:21:55 +0200	[thread overview]
Message-ID: <4d30b811-b452-cbf0-a3e3-00e400ba76ef@suse.com> (raw)
In-Reply-To: <20220505101459.7804-1-monish.kumar.r@intel.com>



On 05.05.22 12:14, monish.kumar.r@intel.com wrote:
> From: Monish Kumar R <monish.kumar.r@intel.com>
>
> Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>  
>  	/* INTEL VALUE SSD */
>  	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>         
> +	/*DELL USB GEN2 */
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME },
>  
>

Hi,

could you please

1) keep the list in nummerical order from lowest device ID to largest
2) combine both quirks with a binary OR
3) provide a short reason for this patch like "found in own testing" or
"reported on list"

    Regards
        Oliver
 


  reply	other threads:[~2022-05-05 10:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 10:14 [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration monish.kumar.r
2022-05-05 10:21 ` Oliver Neukum [this message]
2022-05-05 12:17 ` Greg KH
2022-05-06  5:28   ` R, Monish Kumar
2022-05-20 13:00 monish.kumar.r
2022-05-20 19:19 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d30b811-b452-cbf0-a3e3-00e400ba76ef@suse.com \
    --to=oneukum@suse.com \
    --cc=abhijeet.rao@intel.com \
    --cc=chris.chiu@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=monish.kumar.r@intel.com \
    --cc=olebowle@gmx.com \
    --cc=vpalatin@chromium.org \
    --cc=wangjm221@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.