From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 871C6C48BDF for ; Tue, 22 Jun 2021 13:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F7476137D for ; Tue, 22 Jun 2021 13:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231132AbhFVNz5 (ORCPT ); Tue, 22 Jun 2021 09:55:57 -0400 Received: from esa.microchip.iphmx.com ([68.232.153.233]:36424 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbhFVNz4 (ORCPT ); Tue, 22 Jun 2021 09:55:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1624370020; x=1655906020; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=N+sS5iWqomWqs35o/HzwmRYlU0AVuRGn1OIuvMkrR0w=; b=kDtPrTJD/qXXchy82z3zYTqZ3rEbwnM4rStWS5w0rLWz7mScN5e+oGqn 0N8DAD2UvTzXyVq05kKQ5nnbLZIVUf/rlcfVyOmBVz8ofm2ko3FVPrJ0J ak1hJB/JCSACANtA4NiPvZ5rRo5mbaXw+5Hsbw5UylVfwIJfdfMTPPdL1 nrT5RLf3Pd7644nac4fA1y1VdqbQqvCwjhK1wj8+GU/Rzm5PKEefFA6TU PRkAu3frpecISuxqMYjMbSW2UIuHlFveWLJiKYRqrRdWuBjEzjiP9OvwX o/HitMUCqtU+QXbh/8z2nkblJRW8vsEaNmM0hXg9fn767fqTk7ZtfJjWb Q==; IronPort-SDR: xOwIE68OalmjixTRvD/jNNVt1J4e+XBTrI4QdB7hrVFK6nL+LiELAWwHjBvxuvqw8x/YzeFIoS atspCSmkG+IfRkkqqDD3aNcC/NXGbiH/T5kMJ6gTeb1IALoAQZXGb4J/Vxn2chaYP/mAZHREe5 aljW01qHXb2aaZW9AdTTAywyo3sf6Dwtf0vMrN5Yjg3A1JiGKeCEG568MRht5Phz7TLGM7fEvW SwMsTYZfpnaNuQh9BuVH0jckJrHQYcnol8LVmFzsKUsdVNFuHIC80IJTE3YXHei8OmL5IDKZyF jUU= X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="126209312" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Jun 2021 06:53:40 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 22 Jun 2021 06:53:40 -0700 Received: from [10.171.246.67] (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 22 Jun 2021 06:53:38 -0700 Subject: Re: [PATCH] ARM: dts: at91: sama5d4_xplained: Mark optional AT25DF321A as disabled To: Tudor Ambarus , , CC: , , , References: <20210622134222.107806-1-tudor.ambarus@microchip.com> From: Nicolas Ferre Organization: microchip Message-ID: <4d631b4c-7d0c-3a04-5ab6-00d09c792438@microchip.com> Date: Tue, 22 Jun 2021 15:53:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210622134222.107806-1-tudor.ambarus@microchip.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tudor, On 22/06/2021 at 15:42, Tudor Ambarus wrote: > sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A), > which does not come populated on board by default. Mark it as disabled > to avoid the following probe error: > spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00 > > Signed-off-by: Tudor Ambarus > --- > arch/arm/boot/dts/at91-sama5d4_xplained.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts > index 0b3ad1b580b8..f397e2a68e5c 100644 > --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts > @@ -40,7 +40,7 @@ uart0: serial@f8004000 { > > spi0: spi@f8010000 { > cs-gpios = <&pioC 3 0>, <0>, <0>, <0>; > - status = "okay"; > + status = "disabled"; > m25p80@0 { > compatible = "atmel,at25df321a"; > spi-max-frequency = <50000000>; What about keeping SPI enabled and just having the status of m25p80 as disabled: honestly, I don't know if it works and if it's desirable, but might be closer to reality. Tell me what you think. Regards, Nicolas -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9BCC2B9F4 for ; Tue, 22 Jun 2021 13:55:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11CC860FF4 for ; Tue, 22 Jun 2021 13:55:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11CC860FF4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BSQ31/cBg/PPgy7/RGpEE+D2AE2++Wov9GP9o4zLe0c=; b=dFdZxAh/emyrgCOLDM9iDlQANV DyQUpGzIRsJ/5p7AliHwqDWTmmUq9GGhKhCaEGtJePEWEtUCo1Xv7JNnj3UeabCit6A0vWyIAInEX 13Ikf3raGp79IuBdCLx8hjk4wLJ1wl3uRiVGPtJPpUkd4dPGbSs//whMKM5kXpCA3BV7ascrfVbzW PBXA84pCVQrSkPLHIWfw5aRCg6CJsKntKlE1QIbWOfCAtGvFWrCahLylO+XlkzRbFrO6lTSTYDnAM rh6KUw1O5rx/iaO9jbjBli8JF5dxj2aOoDyR+xMbXPoXJBebIkOFrjNvRW73tyoD2TUmF/HRRXgPs gxwI/WCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvgqW-007N1m-QW; Tue, 22 Jun 2021 13:53:44 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvgqT-007N19-Ir for linux-arm-kernel@lists.infradead.org; Tue, 22 Jun 2021 13:53:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1624370021; x=1655906021; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=N+sS5iWqomWqs35o/HzwmRYlU0AVuRGn1OIuvMkrR0w=; b=Pqt+yo33G0lQsAZeXoF6eOHn+zlEA3mRA8Ehy9COUnCWW1FbfLTUtLkF 816o5abeH+jX3y/K/lb1gEMtbZS40CXI8YEiPxVHls76h8yOKAUYXqvWF j7NjaRRDguTywrCPNM3CQaPNZ13sEiH2d9CCId/CYWqqouxJMCpB/trtX wzBKZPP2jX+ecmB9LxqjvTkWPQxfV2wYRBUTRbn+YBOrDfcpo4g59Oaft Y0hCNADl1LNqaE1l8bgwlBROds9UKY7s9HpEoZ0vCdTx1GoX6AxhJWIrM f04oU2cy00X++xwGR8ygBzkOwSPRB3QhzUXshQ+/Y0qIgFdxWAOiHBVKk Q==; IronPort-SDR: xOwIE68OalmjixTRvD/jNNVt1J4e+XBTrI4QdB7hrVFK6nL+LiELAWwHjBvxuvqw8x/YzeFIoS atspCSmkG+IfRkkqqDD3aNcC/NXGbiH/T5kMJ6gTeb1IALoAQZXGb4J/Vxn2chaYP/mAZHREe5 aljW01qHXb2aaZW9AdTTAywyo3sf6Dwtf0vMrN5Yjg3A1JiGKeCEG568MRht5Phz7TLGM7fEvW SwMsTYZfpnaNuQh9BuVH0jckJrHQYcnol8LVmFzsKUsdVNFuHIC80IJTE3YXHei8OmL5IDKZyF jUU= X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="126209312" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Jun 2021 06:53:40 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 22 Jun 2021 06:53:40 -0700 Received: from [10.171.246.67] (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 22 Jun 2021 06:53:38 -0700 Subject: Re: [PATCH] ARM: dts: at91: sama5d4_xplained: Mark optional AT25DF321A as disabled To: Tudor Ambarus , , CC: , , , References: <20210622134222.107806-1-tudor.ambarus@microchip.com> From: Nicolas Ferre Organization: microchip Message-ID: <4d631b4c-7d0c-3a04-5ab6-00d09c792438@microchip.com> Date: Tue, 22 Jun 2021 15:53:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210622134222.107806-1-tudor.ambarus@microchip.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_065341_693245_08BB961E X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tudor, On 22/06/2021 at 15:42, Tudor Ambarus wrote: > sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A), > which does not come populated on board by default. Mark it as disabled > to avoid the following probe error: > spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00 > > Signed-off-by: Tudor Ambarus > --- > arch/arm/boot/dts/at91-sama5d4_xplained.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts > index 0b3ad1b580b8..f397e2a68e5c 100644 > --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts > @@ -40,7 +40,7 @@ uart0: serial@f8004000 { > > spi0: spi@f8010000 { > cs-gpios = <&pioC 3 0>, <0>, <0>, <0>; > - status = "okay"; > + status = "disabled"; > m25p80@0 { > compatible = "atmel,at25df321a"; > spi-max-frequency = <50000000>; What about keeping SPI enabled and just having the status of m25p80 as disabled: honestly, I don't know if it works and if it's desirable, but might be closer to reality. Tell me what you think. Regards, Nicolas -- Nicolas Ferre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel