From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317BCC433FE for ; Fri, 14 Jan 2022 01:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238718AbiANBql (ORCPT ); Thu, 13 Jan 2022 20:46:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233397AbiANBqk (ORCPT ); Thu, 13 Jan 2022 20:46:40 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3E89C061574 for ; Thu, 13 Jan 2022 17:46:39 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id z3so11983471plg.8 for ; Thu, 13 Jan 2022 17:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bkqHKFcqNq4gb3jt/dwVidqQ5ehBpW6sVTKKduTND5U=; b=bw/xTIGkLnDSX9jnLJvwk5GLgnDjyrWwq8Y3tVvHRP6pWVepDvUpb24R90CZqhCC9L aPDuN+fjx5ZNM0lh6Ev1Rdp4FW9LQb33SYHXU/i36i7j63RSdUSEMkqSEA++xM1uPNqV StKVAv05ywvQcPh5touaCbEXJCmFgXsvK6N0KqdBzM1f06SgAVOAiKA6wnUrjGh+1pkZ II8T7YG2HfpxuY7x8xiehN6DY67dV2M4AyZiCLEvFd+uVW/sDwMW8qmu4OQr/Bm715bX 85ItrhYElmFILfdvKOBwMu6otmSLygtM3c7AqcLmHK/BN7pWlStOp7FR0HmGMDn/1OFP 2dJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bkqHKFcqNq4gb3jt/dwVidqQ5ehBpW6sVTKKduTND5U=; b=r6HkcI4spaDj33AFN36JPiF86NYjgDM3bkCWr3sbT2RUYMWjgA9z5EWrd02Pk8UZzF 3gMvqcHMv8CezyqjJQTYNxupn19EcqEtLCmL1vCke6LQdCqk3cpxpoHqx67EHFN/D+9j 3UhfrpcdR6eFJkt6ngrDcmx2Gx8GEEBL0l+xM5+OivlaBhyw44/qgyhOIyO3jvh0NXpr GSOwWjZx1O/yy+e7W+9St+mOjjsP6172Ugy7+Ec+UXh3LuNks1jFoZgGGgaKHGkwHfMB 5CLgufvWigTQP7C0n3YC6bKW2nlIOLUHh+zJGNJddyfyNXix8KfvnwYHp/qf9ZSHvlIk v8QA== X-Gm-Message-State: AOAM532au/VOmtujSfsDmdu1F+CuT6SMXHVVYJNBvDW7DjBYJf+9MAgP R1aNp3YLPJEmJJF3+71wY34V9w== X-Google-Smtp-Source: ABdhPJx1n2buo+IEu0BN44/SXSTvAhCpZgcA1x+30GjD3bQ1/gPeJucU2x/Go977cYZdYlI7KOzxEg== X-Received: by 2002:a17:90b:3a87:: with SMTP id om7mr16573934pjb.16.1642124798972; Thu, 13 Jan 2022 17:46:38 -0800 (PST) Received: from [10.16.129.73] (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id a9sm3713554pfo.169.2022.01.13.17.46.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 17:46:38 -0800 (PST) Message-ID: <4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp> Date: Fri, 14 Jan 2022 10:46:31 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout Content-Language: en-US To: Daniel Stone Cc: dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Ben Skeggs , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Simon Ser , Qingqing Zhuo , Bas Nieuwenhuizen , Mark Yacoub , Sean Paul , Evan Quan , Andy Shevchenko , Petr Mladek , Sakari Ailus , Lee Jones , Abhinav Kumar , Dmitry Baryshkov , Rob Clark , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, Laurent Pinchart , Damian Hobson-Garcia , Takanari Hayama References: <20220113094419.12433-1-etom@igel.co.jp> From: Esaki Tomohito In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel-san, Thank you for your comments. On 2022/01/13 22:44, Daniel Stone wrote: > Hi Esaki-san, > > On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki wrote: >> Some drivers whose planes only support linear layout fb do not support format >> modifiers. >> These drivers should support modifiers, however the DRM core should handle this >> rather than open-coding in every driver. >> >> In this patch series, these drivers expose format modifiers based on the >> following suggestion[1]. > > Thanks for the series, it looks like the right thing to do. > > Can you please change the patch ordering though? At the moment there > will be a bisection break at patch #1, because the legacy drivers will > suddenly start gaining modifier support, before it is removed in patch > #2. > > I think a better order would be: > 1: add fb_modifiers_not_supported flag to core and drivers > 2: add default modifiers (and set allow_fb_modifiers) if > fb_modifiers_not_supported flag is not set > 3: remove allow_fb_modifiers flag > I agree to your proposal. I will fix these patches. -- -------------------------- 株式会社イーゲル 江崎　朋人 etom@igel.co.jp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E02CCC433F5 for ; Fri, 14 Jan 2022 01:46:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C60310EB49; Fri, 14 Jan 2022 01:46:41 +0000 (UTC) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by gabe.freedesktop.org (Postfix) with ESMTPS id 626A410EB44 for ; Fri, 14 Jan 2022 01:46:39 +0000 (UTC) Received: by mail-pl1-x631.google.com with SMTP id c3so12008214pls.5 for ; Thu, 13 Jan 2022 17:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bkqHKFcqNq4gb3jt/dwVidqQ5ehBpW6sVTKKduTND5U=; b=bw/xTIGkLnDSX9jnLJvwk5GLgnDjyrWwq8Y3tVvHRP6pWVepDvUpb24R90CZqhCC9L aPDuN+fjx5ZNM0lh6Ev1Rdp4FW9LQb33SYHXU/i36i7j63RSdUSEMkqSEA++xM1uPNqV StKVAv05ywvQcPh5touaCbEXJCmFgXsvK6N0KqdBzM1f06SgAVOAiKA6wnUrjGh+1pkZ II8T7YG2HfpxuY7x8xiehN6DY67dV2M4AyZiCLEvFd+uVW/sDwMW8qmu4OQr/Bm715bX 85ItrhYElmFILfdvKOBwMu6otmSLygtM3c7AqcLmHK/BN7pWlStOp7FR0HmGMDn/1OFP 2dJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bkqHKFcqNq4gb3jt/dwVidqQ5ehBpW6sVTKKduTND5U=; b=mnpTR4GF6H8vEhe146oe2l6W5gJxXT6FX/Yak8P4+8t3GP8tGKhdDkA1UHNx3pspq5 5Gqd5x3BoVIWYqZf7N4W1T5RUX3S6JMxdGr/+0Y4FBYv2yDuvyMt6UTYCIjiAqcm2kiO gbXfQB+5g0Up+LUb27gSP8SNqpXrn1X73eKYStxlq0vJS+3qWx4V03rE6sJbdIIBe/4K n9g24UdD0r0o+sWJjYJuRrGhhkW4cE9E8AXQaceB/0SbA9gi0OSMOq+2Kn0Smus0kjhz fEsaAXjYoFhWTlweKNfsHkJWHI091tKaeWghm4AwtCBdDcpJctzRJa5u0uPvplPN0pks +Mrg== X-Gm-Message-State: AOAM530uwyCdReUwBTxmdBdXZHUACWyg7jznIL6zTDbl023vCRTdsUyC lqvsVEjBkSO54qAimZOyUox0eQ== X-Google-Smtp-Source: ABdhPJx1n2buo+IEu0BN44/SXSTvAhCpZgcA1x+30GjD3bQ1/gPeJucU2x/Go977cYZdYlI7KOzxEg== X-Received: by 2002:a17:90b:3a87:: with SMTP id om7mr16573934pjb.16.1642124798972; Thu, 13 Jan 2022 17:46:38 -0800 (PST) Received: from [10.16.129.73] (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id a9sm3713554pfo.169.2022.01.13.17.46.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 17:46:38 -0800 (PST) Message-ID: <4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp> Date: Fri, 14 Jan 2022 10:46:31 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout Content-Language: en-US To: Daniel Stone References: <20220113094419.12433-1-etom@igel.co.jp> From: Esaki Tomohito In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Michel_D=c3=a4nzer?= , Laurent Pinchart , Lee Jones , Rob Clark , Evan Quan , amd-gfx@lists.freedesktop.org, Ben Skeggs , Petr Mladek , Sakari Ailus , Abhinav Kumar , Dmitry Baryshkov , Takanari Hayama , Sean Paul , Andy Shevchenko , Mark Yacoub , Qingqing Zhuo , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Thomas Zimmermann , Alex Deucher , Damian Hobson-Garcia , =?UTF-8?Q?Christian_K=c3=b6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel-san, Thank you for your comments. On 2022/01/13 22:44, Daniel Stone wrote: > Hi Esaki-san, > > On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki wrote: >> Some drivers whose planes only support linear layout fb do not support format >> modifiers. >> These drivers should support modifiers, however the DRM core should handle this >> rather than open-coding in every driver. >> >> In this patch series, these drivers expose format modifiers based on the >> following suggestion[1]. > > Thanks for the series, it looks like the right thing to do. > > Can you please change the patch ordering though? At the moment there > will be a bisection break at patch #1, because the legacy drivers will > suddenly start gaining modifier support, before it is removed in patch > #2. > > I think a better order would be: > 1: add fb_modifiers_not_supported flag to core and drivers > 2: add default modifiers (and set allow_fb_modifiers) if > fb_modifiers_not_supported flag is not set > 3: remove allow_fb_modifiers flag > I agree to your proposal. I will fix these patches. -- -------------------------- 株式会社イーゲル 江崎　朋人 etom@igel.co.jp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DE6EC433EF for ; Fri, 14 Jan 2022 01:46:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A1F7B10EB44; Fri, 14 Jan 2022 01:46:40 +0000 (UTC) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62FDE10EB47 for ; Fri, 14 Jan 2022 01:46:39 +0000 (UTC) Received: by mail-pj1-x102d.google.com with SMTP id hv15so12094830pjb.5 for ; Thu, 13 Jan 2022 17:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bkqHKFcqNq4gb3jt/dwVidqQ5ehBpW6sVTKKduTND5U=; b=bw/xTIGkLnDSX9jnLJvwk5GLgnDjyrWwq8Y3tVvHRP6pWVepDvUpb24R90CZqhCC9L aPDuN+fjx5ZNM0lh6Ev1Rdp4FW9LQb33SYHXU/i36i7j63RSdUSEMkqSEA++xM1uPNqV StKVAv05ywvQcPh5touaCbEXJCmFgXsvK6N0KqdBzM1f06SgAVOAiKA6wnUrjGh+1pkZ II8T7YG2HfpxuY7x8xiehN6DY67dV2M4AyZiCLEvFd+uVW/sDwMW8qmu4OQr/Bm715bX 85ItrhYElmFILfdvKOBwMu6otmSLygtM3c7AqcLmHK/BN7pWlStOp7FR0HmGMDn/1OFP 2dJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bkqHKFcqNq4gb3jt/dwVidqQ5ehBpW6sVTKKduTND5U=; b=kETes6j9HYLxs/3QM7NogIZ81gLMwrmJrIsr0ceMsvnP0vT0E4ZdrRV/fZ8q3m4U00 WSg0jR+K3kN/9ITjKOWdI206rntZCkULbup+btYN7lPVgJCbMPHuP91+d1eWHSpSrQCZ R0rgQITDOU5Byj1sDyuDDOSXtPOP1ppGxPapOjZVUSozbJ+crRmL1GjOYTYmypjuMftw QLwy+wFPtWUk1K3PZkxdNwKK7xbf/mSBGhJpiBApQqYE7EhPPKmpN0Du/gA1GuKf75xS OV6vhPEJsJbXTu94eWUHJiCycTuSA1MSc6bvsB7ltvwoYvmkc60WSofVmzSDwwjYnJI1 fmwg== X-Gm-Message-State: AOAM531Cdf9/TSGpx9DvfgJ3DeiiWV2wRb+9dv2v/CZ5GBUHa+XuJ+YC rhPK6KRALhuWApy8YMm70EEKlQ== X-Google-Smtp-Source: ABdhPJx1n2buo+IEu0BN44/SXSTvAhCpZgcA1x+30GjD3bQ1/gPeJucU2x/Go977cYZdYlI7KOzxEg== X-Received: by 2002:a17:90b:3a87:: with SMTP id om7mr16573934pjb.16.1642124798972; Thu, 13 Jan 2022 17:46:38 -0800 (PST) Received: from [10.16.129.73] (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id a9sm3713554pfo.169.2022.01.13.17.46.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 17:46:38 -0800 (PST) Message-ID: <4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp> Date: Fri, 14 Jan 2022 10:46:31 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout Content-Language: en-US To: Daniel Stone References: <20220113094419.12433-1-etom@igel.co.jp> From: Esaki Tomohito In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Michel_D=c3=a4nzer?= , Laurent Pinchart , Lee Jones , Rob Clark , Evan Quan , amd-gfx@lists.freedesktop.org, Ben Skeggs , Petr Mladek , Sakari Ailus , Bas Nieuwenhuizen , Maarten Lankhorst , Abhinav Kumar , Dmitry Baryshkov , Takanari Hayama , Sean Paul , Maxime Ripard , Daniel Vetter , Andy Shevchenko , Mark Yacoub , Qingqing Zhuo , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Thomas Zimmermann , Simon Ser , Alex Deucher , Damian Hobson-Garcia , =?UTF-8?Q?Christian_K=c3=b6nig?= Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Daniel-san, Thank you for your comments. On 2022/01/13 22:44, Daniel Stone wrote: > Hi Esaki-san, > > On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki wrote: >> Some drivers whose planes only support linear layout fb do not support format >> modifiers. >> These drivers should support modifiers, however the DRM core should handle this >> rather than open-coding in every driver. >> >> In this patch series, these drivers expose format modifiers based on the >> following suggestion[1]. > > Thanks for the series, it looks like the right thing to do. > > Can you please change the patch ordering though? At the moment there > will be a bisection break at patch #1, because the legacy drivers will > suddenly start gaining modifier support, before it is removed in patch > #2. > > I think a better order would be: > 1: add fb_modifiers_not_supported flag to core and drivers > 2: add default modifiers (and set allow_fb_modifiers) if > fb_modifiers_not_supported flag is not set > 3: remove allow_fb_modifiers flag > I agree to your proposal. I will fix these patches. -- -------------------------- 株式会社イーゲル 江崎　朋人 etom@igel.co.jp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7F02C433EF for ; Fri, 14 Jan 2022 18:43:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DBB110E1CB; Fri, 14 Jan 2022 18:43:44 +0000 (UTC) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A6CD10EB49 for ; Fri, 14 Jan 2022 01:46:39 +0000 (UTC) Received: by mail-pj1-x102d.google.com with SMTP id pf13so12215624pjb.0 for ; Thu, 13 Jan 2022 17:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bkqHKFcqNq4gb3jt/dwVidqQ5ehBpW6sVTKKduTND5U=; b=bw/xTIGkLnDSX9jnLJvwk5GLgnDjyrWwq8Y3tVvHRP6pWVepDvUpb24R90CZqhCC9L aPDuN+fjx5ZNM0lh6Ev1Rdp4FW9LQb33SYHXU/i36i7j63RSdUSEMkqSEA++xM1uPNqV StKVAv05ywvQcPh5touaCbEXJCmFgXsvK6N0KqdBzM1f06SgAVOAiKA6wnUrjGh+1pkZ II8T7YG2HfpxuY7x8xiehN6DY67dV2M4AyZiCLEvFd+uVW/sDwMW8qmu4OQr/Bm715bX 85ItrhYElmFILfdvKOBwMu6otmSLygtM3c7AqcLmHK/BN7pWlStOp7FR0HmGMDn/1OFP 2dJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bkqHKFcqNq4gb3jt/dwVidqQ5ehBpW6sVTKKduTND5U=; b=AgkKdktkPBctFguJGONUTgTwamQyEjBIjckPRNPb5dCITzPH6aVhnG2wk/M3qR7n0g 6ylKHIXPamcNTwp+q9JxJluHQjRRhBXI2QZG/WPuxgQ4pHjxQjmVjUknnBsLS1lQ2LoQ sHIribvBXrZNlHqmGJsoUNGsfniLWV5l3PONdWVddREdKWRh0XNkDHuGa8bC4B+hffyj MR8MszeUE8P+uDXKYzGJtWp3eQbwOWZ0ckAj7vylGkpiSd4lZGNJxtCx+8ovWIU3aPch 5R6oNlth4GS++DNF5eHGdeemIXKrb+I3iyMolpV8T9tMM1fSk627txxAHWTxVH81cjZL CEGA== X-Gm-Message-State: AOAM533L/NbcEUMTz5e3ZT+tBIwXiLXVhkFkzgu2R/GAEDwwovOebVRO NcW5W9jfAO/evXSrDxXGKvbgxQ== X-Google-Smtp-Source: ABdhPJx1n2buo+IEu0BN44/SXSTvAhCpZgcA1x+30GjD3bQ1/gPeJucU2x/Go977cYZdYlI7KOzxEg== X-Received: by 2002:a17:90b:3a87:: with SMTP id om7mr16573934pjb.16.1642124798972; Thu, 13 Jan 2022 17:46:38 -0800 (PST) Received: from [10.16.129.73] (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id a9sm3713554pfo.169.2022.01.13.17.46.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 17:46:38 -0800 (PST) Message-ID: <4d77b583-ce3f-89e5-75e1-ccfd661c5198@igel.co.jp> Date: Fri, 14 Jan 2022 10:46:31 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: Daniel Stone References: <20220113094419.12433-1-etom@igel.co.jp> From: Esaki Tomohito In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 14 Jan 2022 18:43:39 +0000 Subject: Re: [Nouveau] [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Michel_D=c3=a4nzer?= , Laurent Pinchart , Lee Jones , Rob Clark , Evan Quan , amd-gfx@lists.freedesktop.org, Ben Skeggs , Petr Mladek , Sakari Ailus , Bas Nieuwenhuizen , Maarten Lankhorst , Abhinav Kumar , Dmitry Baryshkov , Takanari Hayama , Sean Paul , Maxime Ripard , Daniel Vetter , Andy Shevchenko , Mark Yacoub , Qingqing Zhuo , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Simon Ser , Alex Deucher , Damian Hobson-Garcia , =?UTF-8?Q?Christian_K=c3=b6nig?= Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Hi Daniel-san, Thank you for your comments. On 2022/01/13 22:44, Daniel Stone wrote: > Hi Esaki-san, > > On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki wrote: >> Some drivers whose planes only support linear layout fb do not support format >> modifiers. >> These drivers should support modifiers, however the DRM core should handle this >> rather than open-coding in every driver. >> >> In this patch series, these drivers expose format modifiers based on the >> following suggestion[1]. > > Thanks for the series, it looks like the right thing to do. > > Can you please change the patch ordering though? At the moment there > will be a bisection break at patch #1, because the legacy drivers will > suddenly start gaining modifier support, before it is removed in patch > #2. > > I think a better order would be: > 1: add fb_modifiers_not_supported flag to core and drivers > 2: add default modifiers (and set allow_fb_modifiers) if > fb_modifiers_not_supported flag is not set > 3: remove allow_fb_modifiers flag > I agree to your proposal. I will fix these patches. -- -------------------------- 株式会社イーゲル 江崎　朋人 etom@igel.co.jp