Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument

[Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]


Em 07/04/21 06:37, Greg KH escreveu:
> On Tue, Apr 06, 2021 at 09:00:07PM +0100, Beatriz Martins de Carvalho wrote:
>> Em 06/04/21 20:36, Greg KH escreveu:
>>> On Tue, Apr 06, 2021 at 08:34:09PM +0100, Beatriz Martins de Carvalho wrote:
>>>> Cleans up check of "Lines should not end with a '('"
>>>> with argument present in next line in file emxx_udc.c
>>>>
>>>> Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
>>>> ---
>>>>    drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------
>>>>    1 file changed, 4 insertions(+), 7 deletions(-)
>>> Why is this a [RESEND] ?
>>>
>>> What happened to the first version?
>> Sorry, I didn't receive your review, and in kernelnewbies tutorial, they say
>> if not receive a response, may have missed the patch, so I resent it.
> Do you have a pointer to your previous patch in the lore.kernel.org
> archives anywhere?  I can't seem to find it.


I found this, it's what is you need?

https://lore.kernel.org/linux-staging/20210401195457.24512-1-martinsdecarvalhobeatriz@gmail.com/

>
>>> Also, your subject is odd, please look at the documentation for how to
>>> write good subject lines for patches.
>> Yes, I know. It was my second patch, and I was learning, and when I resent
>> it, I didn't know if I can change the subject.
> Of course you can always fix up things you know you did incorrectly,
> don't make others review stuff that you know is wrong, that just wastes
> everyone's time.


Thank you, I will start to do this from now.

>
> thanks,
>
> greg k-h
Beatriz Martins de Carvalho

[-- Attachment #2: Type: text/html, Size: 3183 bytes --]