From: Thara Gopinath <thara.gopinath@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
rui.zhang@intel.com, daniel.lezcano@linaro.org,
rjw@rjwysocki.net, robh+dt@kernel.org, steev@kali.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [Patch v4 3/6] cpufreq: qcom-cpufreq-hw: Add dcvs interrupt support
Date: Thu, 29 Jul 2021 07:13:19 -0400 [thread overview]
Message-ID: <4d80594c-9088-5d36-44cd-19a98145095c@linaro.org> (raw)
In-Reply-To: <20210729061713.kzhka7nymo53zw2o@vireshk-i7>
On 7/29/21 2:17 AM, Viresh Kumar wrote:
> On 28-07-21, 18:19, Thara Gopinath wrote:
>> Ha! I was too lazy to write this down! So how about I make this a mutex and
>
> mutex may not work as you come here from irq.
Hi!
So the interrupt handler is a threaded handler. I moved it in v4 since
one of the "_opp" api has an underlying mutex and was causing issues. So
using a mutex should be pretty safe in this case.
>
>> put mod_delayed_work() inside the lock. So it will be something like below
>>
>> qcom_lmh_dcvs_notify() qcom_cpufreq_hw_lmh_exit()
>>
>> mutex_lock() mutex_lock()
>> if (data->cancel_throttle) { cancel_throttle = true
>> mutex_unlock() mutex_unlock()
>> return cancel_delayed_work_sync()
>> } free_irq()
>> enable_irq() / mod_delayed_work()
>> mutex_unlock()
>>
>> I will let you break it!
>
> I can't any further :)
>
> Consider merging below to this patch, it fixes sever other minor
> issues I see in the code.
IIUC, the main change you are suggesting below is to include
enable_irq() / mod_delayed_work() under the spin_lock as well. Is that
right ? In which case isn't a mutex better than spinlock?
>
--
Warm Regards
Thara (She/Her/Hers)
next prev parent reply other threads:[~2021-07-29 11:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 15:25 [Patch v4 0/6] Introduce LMh driver for Qualcomm SoCs Thara Gopinath
2021-07-27 15:25 ` [Patch v4 1/6] firmware: qcom_scm: Introduce SCM calls to access LMh Thara Gopinath
2021-07-27 15:25 ` [Patch v4 2/6] thermal: qcom: Add support for LMh driver Thara Gopinath
2021-07-27 15:25 ` [Patch v4 3/6] cpufreq: qcom-cpufreq-hw: Add dcvs interrupt support Thara Gopinath
2021-07-28 3:50 ` Viresh Kumar
2021-07-28 22:19 ` Thara Gopinath
2021-07-29 6:17 ` Viresh Kumar
2021-07-29 11:13 ` Thara Gopinath [this message]
2021-07-29 11:15 ` Viresh Kumar
2021-07-27 15:25 ` [Patch v4 4/6] arm64: dts: qcom: sdm45: Add support for LMh node Thara Gopinath
2021-07-27 15:25 ` [Patch v4 5/6] arm64: dts: qcom: sdm845: Remove cpufreq cooling devices for CPU thermal zones Thara Gopinath
2021-07-27 15:25 ` [Patch v4 6/6] dt-bindings: thermal: Add dt binding for QCOM LMh Thara Gopinath
2021-07-27 18:26 ` Rob Herring
2021-07-28 16:10 ` Rob Herring
2021-08-02 21:29 ` Thara Gopinath
2021-07-27 17:44 ` [Patch v4 0/6] Introduce LMh driver for Qualcomm SoCs Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d80594c-9088-5d36-44cd-19a98145095c@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=steev@kali.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.