From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Philippe Brucker Subject: Re: [PATCH 28/37] iommu/arm-smmu-v3: Maintain a SID->device structure Date: Wed, 14 Mar 2018 13:09:10 +0000 Message-ID: <4d83c676-604c-6003-5284-81e3535689a8@arm.com> References: <20180212183352.22730-1-jean-philippe.brucker@arm.com> <20180212183352.22730-29-jean-philippe.brucker@arm.com> <20180308183431.00005f86@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180308183431.00005f86-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jonathan Cameron Cc: Mark Rutland , "ilias.apalodimas-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "xuzaibo-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , Will Deacon , "okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "bharatku-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org" , "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Catalin Marinas , "rfranz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org" , "lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , rjw@rjwyso List-Id: linux-acpi@vger.kernel.org On 08/03/18 17:34, Jonathan Cameron wrote: >> static int arm_smmu_add_device(struct device *dev) >> @@ -2198,6 +2298,7 @@ static int arm_smmu_add_device(struct device *dev) >> >> group = iommu_group_get_for_dev(dev); >> if (!IS_ERR(group)) { >> + arm_smmu_insert_master(smmu, master); > There are some error cases it would be good to take notice off when > inserting the master. Admittedly the same is true of iommu_device_link > so I guess you are keeping with the existing code style. > > Would also be nice if the later bit of rework to drop these out > of the if statement was done before this patch in the series. Not sure that's worth a separate patch, maybe we can do it here. Thanks, Jean > >> iommu_group_put(group); >> iommu_device_link(&smmu->iommu, dev); >> } >> @@ -2218,6 +2319,7 @@ static void arm_smmu_remove_device(struct device *dev) >> smmu = master->smmu; >> if (master && master->ste.assigned) >> arm_smmu_detach_dev(dev); >> + arm_smmu_remove_master(smmu, master); >> iommu_group_remove_device(dev); >> iommu_device_unlink(&smmu->iommu, dev); >> kfree(master); >> @@ -2527,6 +2629,9 @@ static int arm_smmu_init_structures(struct arm_smmu_device *smmu) >> int ret; >> >> atomic_set(&smmu->sync_nr, 0); >> + mutex_init(&smmu->streams_mutex); >> + smmu->streams = RB_ROOT; >> + >> ret = arm_smmu_init_queues(smmu); >> if (ret) >> return ret; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 28/37] iommu/arm-smmu-v3: Maintain a SID->device structure To: Jonathan Cameron References: <20180212183352.22730-1-jean-philippe.brucker@arm.com> <20180212183352.22730-29-jean-philippe.brucker@arm.com> <20180308183431.00005f86@huawei.com> From: Jean-Philippe Brucker Message-ID: <4d83c676-604c-6003-5284-81e3535689a8@arm.com> Date: Wed, 14 Mar 2018 13:09:10 +0000 MIME-Version: 1.0 In-Reply-To: <20180308183431.00005f86@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "xieyisheng1@huawei.com" , "ilias.apalodimas@linaro.org" , "kvm@vger.kernel.org" , "linux-pci@vger.kernel.org" , "xuzaibo@huawei.com" , Will Deacon , "okaya@codeaurora.org" , "yi.l.liu@intel.com" , Lorenzo Pieralisi , "ashok.raj@intel.com" , "tn@semihalf.com" , "joro@8bytes.org" , "robdclark@gmail.com" , "bharatku@xilinx.com" , "linux-acpi@vger.kernel.org" , Catalin Marinas , "rfranz@cavium.com" , "lenb@kernel.org" , "devicetree@vger.kernel.org" , "jacob.jun.pan@linux.intel.com" , "alex.williamson@redhat.com" , "robh+dt@kernel.org" , "thunder.leizhen@huawei.com" , "bhelgaas@google.com" , "linux-arm-kernel@lists.infradead.org" , "shunyong.yang@hxt-semitech.com" , "dwmw2@infradead.org" , "liubo95@huawei.com" , "rjw@rjwysocki.net" , "jcrouse@codeaurora.org" , "iommu@lists.linux-foundation.org" , "hanjun.guo@linaro.org" , Sudeep Holla , Robin Murphy , "christian.koenig@amd.com" , "nwatters@codeaurora.org" Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On 08/03/18 17:34, Jonathan Cameron wrote: >> static int arm_smmu_add_device(struct device *dev) >> @@ -2198,6 +2298,7 @@ static int arm_smmu_add_device(struct device *dev) >> >> group = iommu_group_get_for_dev(dev); >> if (!IS_ERR(group)) { >> + arm_smmu_insert_master(smmu, master); > There are some error cases it would be good to take notice off when > inserting the master. Admittedly the same is true of iommu_device_link > so I guess you are keeping with the existing code style. > > Would also be nice if the later bit of rework to drop these out > of the if statement was done before this patch in the series. Not sure that's worth a separate patch, maybe we can do it here. Thanks, Jean > >> iommu_group_put(group); >> iommu_device_link(&smmu->iommu, dev); >> } >> @@ -2218,6 +2319,7 @@ static void arm_smmu_remove_device(struct device *dev) >> smmu = master->smmu; >> if (master && master->ste.assigned) >> arm_smmu_detach_dev(dev); >> + arm_smmu_remove_master(smmu, master); >> iommu_group_remove_device(dev); >> iommu_device_unlink(&smmu->iommu, dev); >> kfree(master); >> @@ -2527,6 +2629,9 @@ static int arm_smmu_init_structures(struct arm_smmu_device *smmu) >> int ret; >> >> atomic_set(&smmu->sync_nr, 0); >> + mutex_init(&smmu->streams_mutex); >> + smmu->streams = RB_ROOT; >> + >> ret = arm_smmu_init_queues(smmu); >> if (ret) >> return ret; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: jean-philippe.brucker@arm.com (Jean-Philippe Brucker) Date: Wed, 14 Mar 2018 13:09:10 +0000 Subject: [PATCH 28/37] iommu/arm-smmu-v3: Maintain a SID->device structure In-Reply-To: <20180308183431.00005f86@huawei.com> References: <20180212183352.22730-1-jean-philippe.brucker@arm.com> <20180212183352.22730-29-jean-philippe.brucker@arm.com> <20180308183431.00005f86@huawei.com> Message-ID: <4d83c676-604c-6003-5284-81e3535689a8@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/03/18 17:34, Jonathan Cameron wrote: >> static int arm_smmu_add_device(struct device *dev) >> @@ -2198,6 +2298,7 @@ static int arm_smmu_add_device(struct device *dev) >> >> group = iommu_group_get_for_dev(dev); >> if (!IS_ERR(group)) { >> + arm_smmu_insert_master(smmu, master); > There are some error cases it would be good to take notice off when > inserting the master. Admittedly the same is true of iommu_device_link > so I guess you are keeping with the existing code style. > > Would also be nice if the later bit of rework to drop these out > of the if statement was done before this patch in the series. Not sure that's worth a separate patch, maybe we can do it here. Thanks, Jean > >> iommu_group_put(group); >> iommu_device_link(&smmu->iommu, dev); >> } >> @@ -2218,6 +2319,7 @@ static void arm_smmu_remove_device(struct device *dev) >> smmu = master->smmu; >> if (master && master->ste.assigned) >> arm_smmu_detach_dev(dev); >> + arm_smmu_remove_master(smmu, master); >> iommu_group_remove_device(dev); >> iommu_device_unlink(&smmu->iommu, dev); >> kfree(master); >> @@ -2527,6 +2629,9 @@ static int arm_smmu_init_structures(struct arm_smmu_device *smmu) >> int ret; >> >> atomic_set(&smmu->sync_nr, 0); >> + mutex_init(&smmu->streams_mutex); >> + smmu->streams = RB_ROOT; >> + >> ret = arm_smmu_init_queues(smmu); >> if (ret) >> return ret; > >