From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9422C433DB for ; Mon, 15 Feb 2021 08:29:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 923F164E51 for ; Mon, 15 Feb 2021 08:29:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 923F164E51 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.85085.159511 (Exim 4.92) (envelope-from ) id 1lBZFp-000608-6w; Mon, 15 Feb 2021 08:29:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 85085.159511; Mon, 15 Feb 2021 08:29:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lBZFp-000601-3R; Mon, 15 Feb 2021 08:29:13 +0000 Received: by outflank-mailman (input) for mailman id 85085; Mon, 15 Feb 2021 08:29:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lBZFo-0005zw-AJ for xen-devel@lists.xenproject.org; Mon, 15 Feb 2021 08:29:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fec3e451-c3fc-4633-aef3-05a460a88629; Mon, 15 Feb 2021 08:29:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8BD59AE03; Mon, 15 Feb 2021 08:29:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fec3e451-c3fc-4633-aef3-05a460a88629 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1613377749; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbWKccuo2a3z5eO8bLDWyss52tPylGtvuT6EX1VGiGk=; b=Dw5oEpDGrFciPPG6xRO//TnP2MkmSBCnTP0N9Xx6mtm7iolQLIK5tAGza/3SrTh6NPXGj7 mJie/LMCgs/ElOez5z+U3H2UIyujmVWg7BTmVqFO2rF4TUF+ZWXW6RPuGtfGGrOJ5dZ3US G6ARbWNcVBm99Vw0Y1V6yfSztoRZIac= Subject: Re: [PATCH] firmware: don't build hvmloader if it is not needed To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, cardoe@cardoe.com, andrew.cooper3@citrix.com, wl@xen.org, iwj@xenproject.org, anthony.perard@citrix.com, Stefano Stabellini References: <20210213020540.27894-1-sstabellini@kernel.org> <20210213135056.GA6191@mail-itl> From: Jan Beulich Message-ID: <4d9200cd-bd4b-e429-5c96-7a4399bb00b4@suse.com> Date: Mon, 15 Feb 2021 09:29:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210213135056.GA6191@mail-itl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 13.02.2021 14:50, Marek Marczykowski-Górecki wrote: > On Fri, Feb 12, 2021 at 06:05:40PM -0800, Stefano Stabellini wrote: >> If rombios, seabios and ovmf are all disabled, don't attempt to build >> hvmloader. > > What if you choose to not build any of rombios, seabios, ovmf, but use > system one instead? Wouldn't that exclude hvmloader too? Even further - one can disable all firmware and have every guest config explicitly specify the firmware to use, afaict. > This heuristic seems like a bit too much, maybe instead add an explicit > option to skip hvmloader? +1 (If making this configurable is needed at all - is having hvmloader without needing it really a problem?) Jan